From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CE80D3858C56 for ; Fri, 14 Oct 2022 07:36:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CE80D3858C56 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-119-y7KMrQgGMba-jt1gzzpeYQ-1; Fri, 14 Oct 2022 03:36:16 -0400 X-MC-Unique: y7KMrQgGMba-jt1gzzpeYQ-1 Received: by mail-wm1-f69.google.com with SMTP id 2-20020a05600c268200b003c4290989e1so1777404wmt.2 for ; Fri, 14 Oct 2022 00:36:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b/VxrNXJHwsrhcJQLtTJtxyOZBP1eFjPA4qCFQGqH+U=; b=673NpvbhbjpVPcrz/l2vYZbCBKDBmSNmgdwRSAr1/11CzBl1vsJoGKbpsiIyTkcClp VLAGIqePxIlR/2k2p89dgYF7esvKE85O1QEP6P8KO/1wIohNMJTMchFFz8ovD4Xp5ldW rhGMAxC4/Ul908sI2YaeqGhSzsfwfR3VRqI83gxEtb05he2Y3p/M2DwM0FMCKOFEtXcC bAiKerGFOWe7i37KrUX8X0hrLSIyrTIIZCVeLkwy2detGILfjgzGGtVXdaHTY7disd7F rUyKNfeYtokeZRhN1vZcEOzMKpop/ysVXj/RGkD98eRClnBEhfxnKaYH9EHuKxj7UA/8 bNkw== X-Gm-Message-State: ACrzQf0ZVVFH2I8Kz2AkGb7EfyTaptYBuOPromS6lCoED/szqzbl+jYJ C+gbDAZevPmlSYShS4bqvgcvx4EsOti0V92ZVvJIzyMQQ7iOh0X5WwI6XMxmG8rVDVYFOGk+NFB zXHwCqtWJNzCOvA5evwRCWg== X-Received: by 2002:a05:6000:15c5:b0:22e:44cb:65ca with SMTP id y5-20020a05600015c500b0022e44cb65camr2382686wry.286.1665732975261; Fri, 14 Oct 2022 00:36:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4ATFL5GzhJGs8QWb9IjmnwBdefXplUc+XJaagclNXmutrkJN8w88RrfmrAFGUBuX9O79nKvQ== X-Received: by 2002:a05:6000:15c5:b0:22e:44cb:65ca with SMTP id y5-20020a05600015c500b0022e44cb65camr2382672wry.286.1665732975079; Fri, 14 Oct 2022 00:36:15 -0700 (PDT) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id j16-20020adfea50000000b00228d6bc8450sm1489102wrn.108.2022.10.14.00.36.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Oct 2022 00:36:14 -0700 (PDT) Message-ID: <72b91a65-a1df-f754-bd3e-e36314aa5778@redhat.com> Date: Fri, 14 Oct 2022 09:36:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 2/2] PowerPC, fix support for printing the function return value for non-trivial values. To: Kevin Buettner , Carl Love via Gdb-patches Cc: Ulrich Weigand References: <28ce795ca489f69829207b2a7a535cf7f77f6dd8.camel@us.ibm.com> <8decd662134d57e8caf43960a1cdc47723e2bfe3.camel@us.ibm.com> <79d82ed277308ed5ce312bff398e770ab234390a.camel@us.ibm.com> <63f21a897f452d81a73fb386cb99110a359ef0b7.camel@de.ibm.com> <97275f61ef101a12cde8e5a45008ed8e479424eb.camel@us.ibm.com> <191f5826b228a7614c084c9704b086851d418c78.camel@us.ibm.com> <5405a79ecd6ed34646ad77eed0779063ee222d37.camel@de.ibm.com> <1d55efe113cdcf96b812055ee45196a554c4ca78.camel@us.ibm.com> <20221013194959.7164bb86@f35-zws-1> From: Bruno Larsen In-Reply-To: <20221013194959.7164bb86@f35-zws-1> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2022 07:36:43 -0000 On 14/10/2022 04:49, Kevin Buettner via Gdb-patches wrote: > Hi Carl, > > While running "git am" to apply your patch, I ran into the following > problems... > > 1) The patch didn't apply cleanly due to some changes in gdb/dwarf2/loc.c. > It seemed to me that it was likely due to this commit: > > bd2b40ac129 Change GDB to use frame_info_ptr To expand on this, wherever you used frame_info *, you should switch to frame_info_ptr, unless you are dealing with guile. As far as I could see in your patch, that simple change should be enough. Cheers, Bruno