From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 74EE5385626B for ; Fri, 24 Jun 2022 17:54:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74EE5385626B Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-626-eIR_0eXOMZWiQnLcPlfVhw-1; Fri, 24 Jun 2022 13:54:31 -0400 X-MC-Unique: eIR_0eXOMZWiQnLcPlfVhw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A8BAA2919EC0; Fri, 24 Jun 2022 17:54:30 +0000 (UTC) Received: from [10.97.116.33] (ovpn-116-33.gru2.redhat.com [10.97.116.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CCD61121314; Fri, 24 Jun 2022 17:54:29 +0000 (UTC) Message-ID: <72c04cae-b2ad-5b65-42c4-5bdd44b0820a@redhat.com> Date: Fri, 24 Jun 2022 14:54:28 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] gdb/testsuite: modernize gdb.base/maint.exp To: Keith Seitz , Pedro Alves , Andrew Burgess , gdb-patches@sourceware.org References: <20220509180431.31032-1-blarsen@redhat.com> <87edzic8v1.fsf@redhat.com> <2d43e796-7228-f69a-c15b-5463653fe07b@palves.net> From: Bruno Larsen In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 17:54:35 -0000 On 6/24/22 14:51, Keith Seitz wrote: > On 6/24/22 08:22, Pedro Alves wrote: >> On 2022-06-21 16:52, Andrew Burgess via Gdb-patches wrote: >>>> +                pass "$test_name 1" >>> You could use: >>> >>>      pass "$gdb_test_name, pattern 1" >>> >>> here, and similar, with ', pattern 2' for the next 'pass' call. >>> >> >> How about >> >>     pass "$gdb_test_name (pattern 1)" >> >>     pass "$gdb_test_name (pattern 2)" >> >> ? >> >> The idea being that the text in the trail parens is not considered part of the >> test name, so when comparing gdb.sum files and matching test names, that parens part >> should be discarded.  Whether this test passes with pattern 1 or 2 should make >> no difference IIUC, thus I think it should not be part of the (part that counts >> as real) test name. >> > I think it no surprise that I disdain this " (whatever)" idiom in test names. There > is also a long-standing guideline in the wiki against this: > > https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages > > Has there been some unannounced, sekrit change to this policy? > > How is, e.g., "- pattern 1" any less desirable/informative than "(pattern 1)"? Taking this further, knowing which pattern was matched is actually useful in this situation? When first making the change, I just blindly applied the gdb_test_multiple without seeing what was going on, but looking at it again, it will just show which of the correct "spellings" GDB used to respond to the command. Personally, I don't see why it matters. Am I missing something? Cheers! Bruno Larsen > > Keith >