From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by sourceware.org (Postfix) with ESMTPS id DCA88385840D for ; Tue, 23 Apr 2024 19:36:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DCA88385840D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DCA88385840D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713900976; cv=none; b=QJzHEUBI00mTldXAMHJ0KeRNZjNHMpX5W8+DYBVoXkITR5faD+WZ59uICmCAyHnGBEPmeD5mRV921rlIiNIo2Wmx3Cc00oVU9z7zaiP2FzmMW+vA6X9W7XzWzmS2a8j5Vkd+FPrCSGvJITXjZ+Wd7MizTCBJNB7ehus2GIqKs6M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713900976; c=relaxed/simple; bh=GcjTFI7P9WsygmItqxW6h04IoaT5vcgIT1hj23lkkNk=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=SbCbH9j911jCfMo5bAZySh5a65daQkqOI7qfMTkq3Fasypi2D7NwgPqUYeHHw1WWDYQy76d7R+LLKm6pcBNuid6MD1ef/ttZj3l/oaYfl2mCxb2BhXPGRm3pL2WkMDvmCRXzzP9MVEb/A/zdKAm+i646H+kLdRzu+fDHF4auwxs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-41a523e2888so19919695e9.1 for ; Tue, 23 Apr 2024 12:36:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713900974; x=1714505774; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Lt9J3/Atct0uX1moQ+wsRAcrF5lv68Ge5p+4XHl0O0M=; b=JJJQBRTr7nN0/Pll1AhcHHQWul2jixSJsglf4i2/RR8EktuK4IdqwwJcnouIm5aPLQ dnJTsBPlBi/jd7D7X9TgffdZEi+7gfsTaJ6v61irfHZ6hU1lZLo++Gk8stM5gqok0FV7 x8SDpgXZR2hw6V0vtrraQDTTP9t4OzJmu7mCgjxwRF9vpkLjvNdxz2P/RZTS1fZ6NsNM 7athx2XeAndKi9H3WM4k8naq+4rRQlqw68sn9tBRN4EJfPIlbhn1A7WY+czGFXisJqpQ vVjg41TIxwNgkckOiv3hVMdUfi6BGrVIZytjmA+T/CetPNJiBhSv3iLkLYhbfJ+JI3p5 gtmA== X-Forwarded-Encrypted: i=1; AJvYcCX5fe89sjYyP/WOh0V9t3XUlyih4PxL3w3GICUQ97OGQkAJpesf1rgCZf0KyZwjrIZMV72qj6YMe8t7/e2qOkAG1ex4ys5eEr8Q9Q== X-Gm-Message-State: AOJu0YyfvyQM5bdPSZ9sNkLCMDfUMuGuw0gJM/JWRjcDEzai/xIya3Et C0Nc0nOygDz7bLvaYqc5JAZn2YOHXfORT0xoSp/C2NO+hwVSDJVEnt6k1g== X-Google-Smtp-Source: AGHT+IGejcSnhVKH9n77cYnWnC2N+qilWEeeWFYqqAY4I8ziNZW5Q5bcv9fuLkfdyMemiCh5pnozKA== X-Received: by 2002:a05:600c:1e1d:b0:418:a5fc:5a5b with SMTP id ay29-20020a05600c1e1d00b00418a5fc5a5bmr176177wmb.36.1713900973485; Tue, 23 Apr 2024 12:36:13 -0700 (PDT) Received: from ?IPV6:2001:8a0:f93d:b900:4f86:481:20cb:27d? ([2001:8a0:f93d:b900:4f86:481:20cb:27d]) by smtp.gmail.com with ESMTPSA id m16-20020a05600c3b1000b0041496734318sm25133148wms.24.2024.04.23.12.36.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Apr 2024 12:36:13 -0700 (PDT) Message-ID: <72c908ba-26c4-48c1-bedb-b75aad0c3733@palves.net> Date: Tue, 23 Apr 2024 20:36:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] Change message when reaching end of reverse history. To: Alex Chronopoulos , gdb-patches@sourceware.org References: <20240414193653.3289837-1-achronop@gmail.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <20240414193653.3289837-1-achronop@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Sorry for not chiming in earlier... On 2024-04-14 20:36, Alex Chronopoulos wrote: > In a record session, when we move backward, GDB switches from normal > execution to simulation. Moving forward again, the emulation continues > until the end of the reverse history. When the end is reached, the > execution stops, and a warning message is shown. This message has been > modified to indicate that the forward emulation has reached the end, but > the execution can continue as normal, and the recording will also continue. > > Before this patch, the warning message shown in that case was the same as > in the reverse case. This meant that when the end of history was reached in > either backward or forward emulation, the same message was displayed: > > "No more reverse-execution history." > > This message remains for backward emulation. However, in forward emulation, > it has been modified to: > > "End of recorded history; following steps will be added to history." > IMO, "steps" here is confusing. It's ambiguous with stepping. Like as if you're saying that the following "step" commands will be added to history. "But what about if I continue??" It also isn't true that "following steps will be added to history.". If the user does "reverse-continue" for example, they won't, they're already there... The following tweak would be more accurate and not have that "step" confusion, IMO: "End of recorded history; following forward execution will be added to history." and it's still under 80 chars. Except it fells a bit awkward, for not stating that we're stopping before talking about following execution. This would be clearer to me: Reached end of recorded history; stopping. Following forward execution will be added to history. Also, with the patch, we have these two messages, for the forward case: End of recorded history; following steps will be added to history. and for the reverse case: No more reverse-execution history. I read the v1/v2 discussions, and I have to say that I don't understand how the potential user confusion that led to changing the "No more reverse-execution" wording in the forward case doesn't apply to the reverse case... I think we should be consistent. With my suggestion above, we could have: forward: Reached end of recorded history; stopping. Following forward execution will be added to history. backward: Reached end of recorded history; stopping. or, backward: Reached end of recorded history; stopping. Backward execution from here not possible.