From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 38BED3885C3B for ; Thu, 27 Oct 2022 02:00:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 38BED3885C3B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 9B8BA300089; Thu, 27 Oct 2022 02:00:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com; s=2017s01; t=1666836057; bh=YFV9Zfnp/0wLhnqxHnVZj5bt+h22DnRdl3rK4NLtyyw=; h=Message-ID:Date:Mime-Version:Subject:To:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=Fq2BdJWbgR5V9lt7w/RJ9yFWpMt8xhdnBFk5Q0YdDvNYk5ePyK58gXit1lCl9ww+M 7cwAdx1mJXCCYWMfw51pUMf2IDxlAg+c5sFkD3VZqOz4moK5UI8K670USymcNPGAO9 vYi++TrwxhOgTSgWws6BW9JwD6VOioO0gdEqSDYY= Message-ID: <72d8f582-4e89-b256-b830-1da228b2bbde@irq.a4lg.com> Date: Thu, 27 Oct 2022 11:00:55 +0900 Mime-Version: 1.0 Subject: Re: [PATCH 26/40] sim/ppc: Remove getrusage declarations if possible Content-Language: en-US To: Mike Frysinger , gdb-patches@sourceware.org References: <4f666ba3e017785495a6d9e1242c827b4f74424c.1666258361.git.research_trasio@irq.a4lg.com> From: Tsukasa OI In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022/10/24 0:04, Mike Frysinger wrote: > On 20 Oct 2022 09:32, Tsukasa OI wrote: >> Clang generates a warning if there is a function declaration/definition >> with zero arguments. Such declarations/definitions without a prototype (an >> argument list) are deprecated forms of indefinite arguments >> ("-Wdeprecated-non-prototype"). On the default configuration, it causes a >> build failure (unless "--disable-werror" is specified). >> >> This commit removes redundant and indefinite getrusage function declarations >> if the known getrusage declaration is found. > > just delete the code and be done. don't keep it around for ancient irrelevant > systems that we never test on. > -mike I'm concerned what kind of machines / environments to preserve behavior but it seems we no longer have to worry about such pre-POSIX environments (also, sim requires ISO C11 support). Removing getrusage declarations without prototype is simpler and easier for me too, so I agree to delete them. Thanks, Tsukasa