public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Bruno Larsen <blarsen@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] gdb/cli: Improve UX when using list with no args
Date: Tue, 20 Jun 2023 15:46:20 +0200	[thread overview]
Message-ID: <72e04013-9a92-cde5-2312-61e5d5bc4f3d@redhat.com> (raw)
In-Reply-To: <83ttv25jw0.fsf@gnu.org>

On 20/06/2023 15:43, Eli Zaretskii wrote:
>> Cc: Bruno Larsen <blarsen@redhat.com>
>> Date: Tue, 20 Jun 2023 14:29:12 +0200
>> From: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
>>
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -78,6 +78,11 @@
>>     functionality is also available for dprintf when dprintf-style is
>>     'gdb'.
>>   
>> +* Using the 'list' command with no arguments in a situation where the
>> +  command would attempt to list past the end of the file, instead of
>> +  erroring out, it will now warn the user that the end of file has been
>> +  reached and the default location.
>               ^^^^^^^^^^^^^^^^^^^^^^^^
> What is that "and the default location" part about?  It looks
> misplaced.
>
Oops. It is incomplete. It should have been "And the default location 
will be printed", default location being either where the inferior is 
(if it has started already) or around the main function.

-- 
Cheers,
Bruno


  reply	other threads:[~2023-06-20 13:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 12:29 [PATCH 0/3] Small changes to "list" command Bruno Larsen
2023-06-20 12:29 ` [PATCH 1/3] gdb/cli: Factor out code to list lines for the first time Bruno Larsen
2023-06-20 12:29 ` [PATCH 2/3] gdb/cli: Improve UX when using list with no args Bruno Larsen
2023-06-20 13:43   ` Eli Zaretskii
2023-06-20 13:46     ` Bruno Larsen [this message]
2023-06-20 13:48       ` Eli Zaretskii
2023-06-20 13:49         ` Bruno Larsen
2023-06-20 12:29 ` [PATCH 3/3] gdb/cli: add '.' as an argument for 'list' command Bruno Larsen
2023-06-20 13:42   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72e04013-9a92-cde5-2312-61e5d5bc4f3d@redhat.com \
    --to=blarsen@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).