From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2066.outbound.protection.outlook.com [40.107.236.66]) by sourceware.org (Postfix) with ESMTPS id 09D653882ACB for ; Tue, 18 Jun 2024 21:01:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09D653882ACB Authentication-Results: sourceware.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 09D653882ACB Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.236.66 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1718744514; cv=pass; b=NvpDSQJVkPCiAOCiNtyl8YHWvJkv5S/Rq9O61yVekynuAVL5cF4NcY2iYGhJ+AlPzMffWM+A9y1iFKckiEHhFjygf5OeJEZQmiiXG3CskvSFWege0KqNWzEet24DSyIGLy190jM9thCmlMwifgE4mqcVPV7dKkW5C8nY6vu0ssI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1718744514; c=relaxed/simple; bh=bjaJBjjPSnm/5vo8aypXP7/m3Hq+wEhLcKYC8wSkMWE=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=gzS2f36utlOLzmyTy1MR1YSb5MFe4pLrL+YfM01TMWpKrrUDLKh8/dvwSrR0Da9gOZn/nuKsUCEdBU1jDweJQxj3jhgr5PzqR6NTmmvTUMOGirQRv11xT2/8A37bpkSNQyMLrLTfursV2iNe7HD00ELPq+G5gE3ZPM6KxDCQ7mE= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ktz7mNdknOiMwvpRm+OuWb8ptS2Am4WpClIavTiiODEax2UC4ikQj852rrcI14uutTq1IMmd84D5DxoNx3cDwiYaHTuuUWy3t1NARMYVJEAGIIf1vkImAIfE4auwh60YTv88kEokiNlHwFvx/QgwaXRmi25NfqoPdhwFXMdIVsYMGtbL5hdE2sSGzyAJDTbnstajcxpsEtMzoSagaNVtfZuZg8RSbUm5Bgc3Kol86BprNr9hIvy4yK2itB89SY16NMljltnSNU8H5oAaxIRoJck+ZYiRWgwSfC8bErab1IyYPwGNbvxIRsqxPegF+O6yOAfjst+4aYFSJTCyxk8z1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F769KcwwOuw4C7/Vh9ocV2v/eNOLqG7/a3YRRV3olLs=; b=ZrDbGrUVjkMfC8CBcHcFbaxBsFJ3hfn702NF7LtCTPz53f3yCvF0buAyXzMrvWHqNKJRbFoRx1C3CSqwDFeavruf5RmbVrKgBuP8K0SO/YPO21cqrQtpIVkRfhZYy6/XdrHVuyZOex7gZHaUBQ+kxQbG46xoEQ5k/bXk+lZlaye0c8QFpt5yMF4qPdibXfinmYSgB+5xx75JkfqtfAf+Cn5u0FhXNKHdY8GVAA7e8tF+XKzD4Pboyna8do7xCdcb0Lqv33fbm2ZNP89LfBk4HSv5rlqmiBGRoly0hgf9Wlh8uoQ+Nrx3UwJ5hsC+5/V0r7hUDp5O0pQaEiPCipZmfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F769KcwwOuw4C7/Vh9ocV2v/eNOLqG7/a3YRRV3olLs=; b=yzKkaFswL+uMBRkfJx+zwes6LS/8BGS9w3P5sqnfXrD6flF8pxMa+lKGxN1JrG5Z1HWBTdxARceuGxlpTRfadW9vEwIsakPlKvaQLkVQROwZ+2IxC+w8k/jcfm5Be2luKKVECT9fonmfdNWUSmLScsCya41GtQZtM2gcIl8ckcQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by MW3PR12MB4410.namprd12.prod.outlook.com (2603:10b6:303:5b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31; Tue, 18 Jun 2024 21:01:47 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::8c67:8cec:7c4a:ccaa]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::8c67:8cec:7c4a:ccaa%5]) with mapi id 15.20.7698.017; Tue, 18 Jun 2024 21:01:47 +0000 Message-ID: <72ea54a7-b6de-42b3-8889-f8921c0d2074@amd.com> Date: Tue, 18 Jun 2024 22:01:42 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/python/python-internal.h: avoid uninitialized constexpr To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240618090952.537478-1-lancelot.six@amd.com> <8734pacjju.fsf@tromey.com> <2317caf4-6fdb-46d1-b2aa-caffed3faffe@amd.com> <87wmmmxcat.fsf@tromey.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: <87wmmmxcat.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR5P281CA0048.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f0::16) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|MW3PR12MB4410:EE_ X-MS-Office365-Filtering-Correlation-Id: 17ddde0b-bc67-4f28-a69a-08dc8fd9ddb7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SFhqYytucUM0RGhsNUo5VGgvb3Q2OWhLRk0yM0FhUHg4WkVhR2Zma1ovOFEw?= =?utf-8?B?QmdGaG93Z2t6MWRzUk1CbTRGbEpxYkJkbFN0dHhMdE43Q244d3BXTEtXS1hB?= =?utf-8?B?NHo1UG9WUXNXQU9ZRkI5dDMyUS85bCtEU1Y1RU95VEtrZUMvck02MEFlenJa?= =?utf-8?B?Rjd0VXFoUVh4WlRmYmx1d25ETXhDeFJUZ1ZQSlJHSU4zSFRvMysvdEh2UXdv?= =?utf-8?B?ZG5jNkxQY1R1QTBLSHpZaWhFeTNyT2ZTUWZSbGxLNjJBV25UMmJob2FPWmpC?= =?utf-8?B?T1lZTEpXM1FPRUtNWklTY3cybW11Zmt0dzVZeDI0Yll5ZngvdWtWc0ttMGdz?= =?utf-8?B?ODc3SjMwWk8xK3BZR0hRV0gyemlNc3B5QVY5TTB3ZTZaU21wNHBKelBzdjVV?= =?utf-8?B?ZXhIVlNReHNOMUViVUR1bHFRdzlBLzYzMWVjRnhFSWd5QThTWkhGRWFLcnp4?= =?utf-8?B?UDBIcEhGLzBMRXdieHFMWEdPN3pUcG5yOXBJRHFjb3N2Z2ZWR21oRUtzMjNL?= =?utf-8?B?QVJHWHBlS2pva0ZXNlBIQ2doQ0M2MnRaMzFEdVFYbWVQdi9RWDB2Vkd6NnR1?= =?utf-8?B?M1J1UmFUaC9WdnZSaHRpT2VVVmtyK1BoSmxheURRY2o5MUZsZVhHcFBzc0pB?= =?utf-8?B?Rzl4aDQ2UDVLckx2WGI1U1lxaW5SUmtoS3ljQVdwZnc5cEpCamZpMkdUOWs4?= =?utf-8?B?ZkIzY3pmK0lHNzF5UTVUMDdFOWtKVVYybXNvbWJPUlYzaGNWQy81dU94U2Ra?= =?utf-8?B?MG91Z3lScXpyTittaG5obXpjRmdHRWM5Zm4zRytyTk95SUlSZGQzMUZsWHh4?= =?utf-8?B?eHNEMjlpRHVTd2FvVWkwZWR5R1JSZldZb01heGhTNS9yNzU4SnhyTElpSXJ2?= =?utf-8?B?NmZFcUlKR01CMUtnRXlLNld0ckh0OGRRdHBPMlRCbGt5bkRKSEEwK1JBejUv?= =?utf-8?B?RnpCZzNNdUtxdjVDK1gvcEl5NFZLdEIrOE1aU3paNFF2Ty9SSXA1VzRqYm54?= =?utf-8?B?OUxRcmh3MU5xVGxkWjdnL05OMkc4cWdlaklEQ2pmcW5mb1A1djY4MytMKzFl?= =?utf-8?B?dFlsZlFua3ltanlwcHFHWG9HcVRnU1ZpTGFoQ1BTMVBYZEhRa1o3dWhpeWUw?= =?utf-8?B?TVJ4aENldmpHanlnaUI3OVhLaFBrRndmYVZuaDJDUXhPSkhUa0xIUm5sWklp?= =?utf-8?B?MEs1V1VqSzVkRVlRZVVXdzBsR3lxeXl4KzZQQUFlazlFc2cvK0IvT2o5K0ly?= =?utf-8?B?NFhUZU45QncrTUl1aVNCZVUyNjNUWWFLWEsrNjh4c0kwMGpiTkRUY1FOSy9h?= =?utf-8?B?Sk1hbzZXQ2JOaWc0ZTBnY0pYTXdVcnovRllJalZJS0xjVkhxVlVZSm5raEVx?= =?utf-8?B?U0tOTE91Sjlpc2FaT0s2QlFzclBwYlNTU2xKWUtneXNMQ1YvRnF4OExqYng3?= =?utf-8?B?YlBHdGJONFA2bjNRQ1JnaHJINVVuTnJGY0NYWGlXY1RtSFppSzNCVENjdVZF?= =?utf-8?B?MjJ5M0o3dTdPMlFGRWVjZk9HNS9vd3pUaE5nVVlPaUo5eEVvWDh0S2FIMFdj?= =?utf-8?B?aHdyRTFUamUrQkF5MWgwT1hiaFZQTzJpbWllaEkwQk9Obmt0eEJYT1dsZHov?= =?utf-8?B?bHYrRVFMYXF6WnZ0T24raWJCZVRPKzVRMm4zZVFiZDhQQ3BoRUdaVzlxUlZE?= =?utf-8?B?ZHh4T1FTT241czNxWWo2Z0YzckVjdzJHN1ppTTJvTWIxQlhvKy9JRmtjaDBF?= =?utf-8?Q?2cdsOZ8RTjsgBxJxUr9g87nR82j5Q7gXkwMvFMX?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR12MB9079.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230037)(366013)(376011)(1800799021);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkJWZW5Sc0Erc3hpbFFrVU5JNS9PM3RsTGdlR0N6bzR6alR1Q3MrZHV3K2ZZ?= =?utf-8?B?ZjEvQWF4M3pHUzhhTjBnSnV6RnRlMWY2NzRBRjFCTC8vM1VEbWp5MUpQQmZv?= =?utf-8?B?Q0IvaXhodkxWaFVyOGVmZS9PVzVmT1hiSkFPVGtnOU9xeHNEOGJqbG5YRG16?= =?utf-8?B?aTcrazdlUUxNL3FqZFFnUlNHZk0vSUVraHI0QWZ1c1VOQW5TUGV1bzNyL1Y0?= =?utf-8?B?NHJKTXQ5L1Q4bmFleUpCRzhSaHVzTzFhY01HTFREL0FZbmZ0b3FwZzZ3MlZW?= =?utf-8?B?ODV4L0JvUjV0eWJ2aU8zWFZuYngyS1BwWUJrRU8xRGRvZFZUa1h4U1I1UHp3?= =?utf-8?B?Yng5a0h4WlVXcmQ2aDZYZjhqMU02TzBqSUQyRUdOT200d1gybUFnMG1PWmpw?= =?utf-8?B?b2E4bjVJV1dGQS9xQkxwZXVCcW1iczh6Ti85Vlh0THUzcGxSaUJ5clptSGJn?= =?utf-8?B?UDFnSnJockN4Y1Y0cm1GUlUvTjlnRWwzcGc0b1BBMzBNUFYzcWJZZEFZckFP?= =?utf-8?B?eHlYOUpzbnpYeHBYWVkvNDFacXdGbHV4Vy9KSE1yZ2RBYmJLWS9aOHhJUmpn?= =?utf-8?B?YW9mU2JlME1SU21PL0lPQnhxZXZIOE0rRWhNMWpLbU54ek1adWFTQ2xISC9Y?= =?utf-8?B?Z05ublpQVVRMTWl4RDUzQ3RPQTJJbVdpbUdkNlRNM0Vwd2NZVE94TXpUQ2xm?= =?utf-8?B?SkZ2U1pQUytnQ1RjSGhRVVd4YUhrdkxhTFM2WUhleHJMVkdSc20vOG9wdEJE?= =?utf-8?B?alpGckFhcDJaSXdFZi9STFJ5eXcybjNWTGt3M1NqRmFtNDZiN2V0Mk84S3Jw?= =?utf-8?B?Q1AzOTA5b0ZtbUt6TkEzd1FrbEh0TVZkbC82WCs0Tzh5VTNHZkxUdndhNmpL?= =?utf-8?B?VU5HUDN1VUIvV2cyNDlGTFNtbDhJNE5qS0RrWGREcXdkV2FPc3h5QWVBQTFP?= =?utf-8?B?ZS9CK01MREQ3KzZBUlArMmx3RDBVUlVnQlNiSi9qREo1TVU4N2ordTJOcktP?= =?utf-8?B?Nzh5S0VLUlUxaWx4QzJOUWZVL044Tzhwajg2OXFDTytaRTBEZS9LZ1RGN3h3?= =?utf-8?B?RXNVdHpqalFXczNDVSt2WGR3V1QxUnVwUE1ldUlmZi94SW5VT1o1WktWVUpP?= =?utf-8?B?SVcxdDBlWWhobWdDMXdTL2xqdkZIUVdiKzhFR3Q4TWk2WjQzaWtTcVF6bkUv?= =?utf-8?B?RUszTDNKeTZndkV2OXVsVjE5Z2U2Uy81Nk9TbytUeExYR1ZwMGllMTRhNmNC?= =?utf-8?B?RXJLODE2aG5jVFA2Q29zRnl2aXRHV0dHV0xUTnluaElYR1FWU2toeC9qYnBu?= =?utf-8?B?RE8ybnpCcE0xOGsvRWtmNG9lZktYcUpkZS9SVVl0elY5QWxJNmt3QTdFTkE2?= =?utf-8?B?OEM5Z3hMRWpXMUtSVEd0MUp5SlNqVWpFRkpjai9vcXlkZmgvNFJnWGZhRzlW?= =?utf-8?B?NitDTWJ2ZnFIci9QdmI2MHp0UGt5NVorekk1RmI2bzY2RTloY2MxUTVHZlBr?= =?utf-8?B?cEUzRy9wQ05PdG5GNUdHcmNSOHd5clREZ09pOHpFQzQycVlMdXhKajlBQWpt?= =?utf-8?B?UG1VWHVLeFBPS1dRYXJoSTNSVmdBZjdxU1F1QUt3cndLMHpyc0YwUldGZ1ha?= =?utf-8?B?R1dBS0drc0dIc2pYL1lsUjhnWU80NG5LblU4Mlo0WGNCKzFwZjhsSUlOMUVz?= =?utf-8?B?T3VhNmtxK0s1YmhDNGdyQjBocmdBc05CSWQvVncrVDVlYUlWelN6MlBKUU1J?= =?utf-8?B?c1c4REdRNlR5ZHVPMFJNdmpTNzNsRjhWc2tRaTFIbjVOeENmMExMY0UrRksy?= =?utf-8?B?QmpKMDJHdWpyajErWHBuWlVPcGNFUnNac0FMMm84eVBCUi9ndGZyTmFCRUZW?= =?utf-8?B?ODJqWS9qOFNIZjFlVnVyeW10bzBEbXJKYjFUY2Uxa28wY3VIRlhWRnowODQz?= =?utf-8?B?eCtzQWdXVllHb3pUY0F2OVgwTnRvNjczVnAvZlpWVEdsbjE5YUVka1BpSklE?= =?utf-8?B?aVFyb2ZqNFhTL0gvNlNJYVJxTkFjYi83dmRoVjJPZlphU3VCQTk5RU85dVB2?= =?utf-8?B?M0x0KzJjbDJ0SVArT05MUFRqQmFwcEk5eEdPUkwvUW9lVDBPMVdYUDdGb2tB?= =?utf-8?Q?PLYN7T6erG0rCqySGUVaV0eVZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17ddde0b-bc67-4f28-a69a-08dc8fd9ddb7 X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2024 21:01:47.2487 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5sl8T3LUjnLV9qqd+XupJwxuCh2/cJ8xplmQlncaBIROvZibldDfN5HEVEY7qGF4GC/VFoE4mjL4+bhPIh+mww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4410 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18/06/2024 20:48, Tom Tromey wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > Lancelot> Just gave a try to this approach, I end up linker errors regarding > Lancelot> duplicated symbols: > > Lancelot> I have not really looked if there is a way to work-around that. > > I think s/constexpr/extern probably works. > Would you mind trying that? > > Tom G++ complains that "explicit template specialization cannot have a storage class": In file included from ../../gdb/python/py-arch.c:23: ../../gdb/python/python-internal.h:154:13: error: ‘gdbpy_method_format’ initialized and declared ‘extern’ [-Werror] 154 | extern char gdbpy_method_format = GDB_PY_LL_ARG[0]; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../gdb/python/python-internal.h:154:1: error: explicit template specialization cannot have a storage class 154 | extern char gdbpy_method_format = GDB_PY_LL_ARG[0]; | ^~~~~~ Clang++ complains because "'extern' variable has an initializer". I know the empty struct as a base template, and add static constexpr members for template specializations is a bit verbose, but to the best of my knowledge it is the "c++ way". Lancelot.