From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08on2042.outbound.protection.outlook.com [40.107.102.42]) by sourceware.org (Postfix) with ESMTPS id 047023858D28 for ; Wed, 3 Nov 2021 15:11:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 047023858D28 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RFkxw8JSiboHW2EjVK+MAnjlkBwxSCAz6HMpUZyF1eG8GWhiJ+1DdbdaFbwQHZy9kOIXsiYu3DEvJZuuG50DfGmGp6id6KOB02+HCdS203hbbwsWJA9+PQ4tHci9UiCsYliGMEhYkOzgAGZo6n716aG5EAqaJ2ot9hlUvnInwIlwKG7i1pPeqRpD6iD3tFF6/8Pep+FYpBwNBqGeVZ+EJk4V0jUpRDhEu47J8vaUtsOE1LwKAB63P1ItLbrafxFpDbqrz3hvaqlOMrLsPoTfPmgT970DT9n3EvASSAxFhNaXlqjtnFLrEynWZjEj+E+XQmNjIhjkDm5vgby6ILTPpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qvLQSCFbTvrtOFzwiSJKxnz1AJBsr8ngwuWZZgheOzc=; b=hKAYpidF0okNtC/edAh5sf+Gdwx+RbeGR86iLJ97Pf/IMwmj8FGf8whwBJg17c+khFoq7GeudJjAJEsQ95Vnj/xWLHbUDfpJhYWMNFAr8dppotmy2rVnKHaIqalkxQPDioU4VwV7GLGjSEaB11XxT7344dBDYwlXXlQEFq8JmWAetZ5lAfztNotGekCfXJZgFX8gWa+Ro65nfx9kQ1RAqClD/GKxj2Any0PHxndHW389jYBGXE5kz9S9NOTaHlM3283iMaunkix1pNJEfMH58QcwXpBOdYlguoH0AnHKLjY6RNwmjTvPkbvcl75+srrED9unF25HrbSc/v3ArXuzbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) by BN9PR12MB5292.namprd12.prod.outlook.com (2603:10b6:408:105::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10; Wed, 3 Nov 2021 15:11:37 +0000 Received: from BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::f908:e014:a94:a35]) by BN9PR12MB5065.namprd12.prod.outlook.com ([fe80::f908:e014:a94:a35%5]) with mapi id 15.20.4649.019; Wed, 3 Nov 2021 15:11:37 +0000 Subject: Re: [PATCH v3 12/28] Add indirect_implicit_ptr to dwarf_location class To: Lancelot SIX Cc: gdb-patches@sourceware.org References: <20211014093235.69756-1-zoran.zaric@amd.com> <20211014093235.69756-13-zoran.zaric@amd.com> <20211026205207.4clp32vexbfxejme@ubuntu.lan> From: Zoran Zaric Message-ID: <72febeb5-2a64-37f3-37eb-15cf34d78d12@amd.com> Date: Wed, 3 Nov 2021 15:11:32 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20211026205207.4clp32vexbfxejme@ubuntu.lan> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0116.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::32) To BN9PR12MB5065.namprd12.prod.outlook.com (2603:10b6:408:132::12) MIME-Version: 1.0 Received: from [IPv6:2a00:23c7:1093:6301:29cb:eb34:5531:f90a] (2a00:23c7:1093:6301:29cb:eb34:5531:f90a) by LO2P265CA0116.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Wed, 3 Nov 2021 15:11:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 728d6f38-1db9-4c83-2eb4-08d99edc3b2a X-MS-TrafficTypeDiagnostic: BN9PR12MB5292: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fvyT4DXQwAOekpNNOWPL5oAdhnkBsF5wYIzYAyu3Qp76bLhmoYwo+mLS9AeCBY9ea4TcTkBb69drKdiko+EX7l7yiiunUo2qmKlBinpS4ZfgOGLheSGNKvfOJSALmAkwS2FGPNW7oLqDzpw4fv8opJF006wxfObqvCHZzFZF0OiUuHxizpqWEeTnMFnXysl8rkIXVSDEAtiDc0VlefRZpc+zEpXWHXi9+bmlQEniMc/4aTlRzVgloL/xd5zYENEKJ67Wvz0myIQeMX7IsTaCx4DhdCaoyiSw+8KDbeeQKOkBa5iV6xF5geDDWYCVvjSVSp85KyW1uz3OOKMLwlWHmLVZxfmYiCaaSDqYf7Ob2Qo7vy/Bpr3hKMW1hR2brbTXhLjdW+ltD+v/RwgqwX92gW8DnksxP++c5UlmveQdWqEQ7zORFraozYQ3Tv/a9cfw1S4q5kBaycd19WEZAmlnIGeBHrgkeIcTqiqtKvaKqiyQsmn1bgNL495myjCp8x/iXY0y98JZpklqOng3dTUqLcOU6AkfKlrW/pPdVU6MJlxGOgCYXDfeKan8k51m1mrsabrEfAgST9sBAHTVO8da5CmSYrTx6SlS8Mo9nHShysm2o/3KhYgqavoZ8MRFuqWIkvxEQ0MfjHvKBHFgTMpx8WDZReeOTviZ+X2GJBrLRSf18aFIjUvs/jNTxzolG60rMRjFW+f52bXCUuK5pPlqJn23ZL2Yn1vQdCSchdLQ09Y= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5065.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(36756003)(31686004)(6486002)(508600001)(316002)(186003)(31696002)(44832011)(6916009)(66476007)(66946007)(66556008)(38100700002)(6666004)(2906002)(8936002)(4326008)(5660300002)(8676002)(2616005)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjRmaHVNczFobFJjSFIxeVNmR0Jiby82WkcxdWZiMFhVbDY2M3psWkIydWpt?= =?utf-8?B?UFJMWnlYOUxSWHJwUXBvY1RrcnRNVlhNMkNPTWg5RXJKQkNXTHkyQ2hBcFl5?= =?utf-8?B?ZnZJdUVpV2FvandvK1lPWi9LOVJoZmNkQW9hS3ZZQ1U1bDZEa2NJMTRVbmww?= =?utf-8?B?SlNuQy9vb3ZGdWVKT3hoWXZPM0VrcjZHL0R3bG5kTXJmNlhnNERWK3l1U1lu?= =?utf-8?B?dXlURjNPaEdiK0lhUFNwUXhtNSs0OGhMQzgxbFc4UkI5SnVMcTUxWEpRVFJV?= =?utf-8?B?cCtWckNYbUUxM1JUd0JEWjRIblJQOWlTN3JmQkJiY25UbmRHQ2FkUzJmVlp6?= =?utf-8?B?YU9VQXdsd2J2WFZDWjVoTUw2eE05T0dPR3U1cjVTaWhmdG9uZ0hmY3piemh0?= =?utf-8?B?RitkRHdNZWdYaFpKOG04dmxiazlGa285NlBDenRYY0t4TDBYcEtGUUh3REFQ?= =?utf-8?B?cFZNN29TYWI1UjhsMzdaZWJLc2x2VCtCL1QyMFBlQy96d0gyekxIdXNqYnJQ?= =?utf-8?B?Q0VJMi9qQ2hzZGtyV0E3a3VOczBSbC8zUENUaUVlLzZDYU1pV2FGcGd4ZHpk?= =?utf-8?B?OTBwb0FUaldWSXBrcUs3K2k0MDhsY25rMWNtQXhpMkRKZ3JPUjJFSEFVc2x0?= =?utf-8?B?WHM0TzVITjhzZUpkbWNSc0hVcjg0UW1iL3hRbXE5YVdMMG81Rnd5dUFUaElC?= =?utf-8?B?T0Q5T2g1em52VG4vU1lLZTFmM2VKbm1BZE5zdzkveDJwT05QUTUzVXpkaVAy?= =?utf-8?B?Tk1FUHQ0VXZITlJnRWRQSlQ0RUc0R1ozMXlWdzZILzJMVktnbGhneWdKQ1lS?= =?utf-8?B?aVBFV0Q4RGVNaHBTTVFpT0hiZnBMNThlQW1hNXg3ZHI0bUdRMldGNkhINGNx?= =?utf-8?B?MFhSeTN0d2tlTjNHd2ZTUm4xemcwRW5jZlpXZXJwWm1OUGdrdFBvUnpGT1RB?= =?utf-8?B?ODI0TVRlMm5GTjNIZmNROHdWR1NHY3pCTjlGV1QyMi92U0lHdVhHRENWS1E0?= =?utf-8?B?aytGZWJpTndlcVNndWVTZTM3cjd0MkJpMGgxd0FxcmpROHgrNkp1OFUxZC9w?= =?utf-8?B?ekxyc2JlRnJGNE03T0M3Zmo2aFBKZDhZcEw4UjNqWUJHVVB6QUpmV0tkcUFB?= =?utf-8?B?N0tvK3MrOTdYMHc4KzhGSVdSVkM0b3JzLzlEd0RaTDNRZ0R2aG1zaGcyRVg0?= =?utf-8?B?dGVQRUJrQnJFU2tFaTdtVU13L0JDUFV6QlZONHBEY01tS0NianFsS1NlT3Y2?= =?utf-8?B?bVRBZU8wWjBPeXRkQzc2WjEvYmNhTE9Oc3BZMElhUk5WWTN2cE5DTXlTeisz?= =?utf-8?B?VWVhZWN4YnlFUENzeHFFSlRNRVhGanR4OXg5T0syMlo1b3JSVnVXUnZkTzFt?= =?utf-8?B?Q1B0Q0poS2VHb1MxV0xCTlNLQzBobTA0ejFjMWJsaVZ1bnh3NlZtNzFWSDJk?= =?utf-8?B?RWc1YUlJMy9ORDQrTGx3Rk5ZcmU2RnRCeHRvWXJIeHYwVmNIM2JMVm5VM25o?= =?utf-8?B?bFovNVo0bVZqbGF4Ym5jdk9QWGNaZTgyMUV1RlZlbmU5Q2E3Qm9tMHA2OWpr?= =?utf-8?B?cE55bHZDZXVyVG5JdWlwMEZIT0RXL0xVUkF2WDgzZGRaUDlpVUh0OU9kWllM?= =?utf-8?B?TmZXT3YwL1VLV1VpOXlTaUlDWW1yM2pESnd2V2ZiVDJzQmI5dThkVms0YzBn?= =?utf-8?B?czNMdUVicFk0TDZMUFg1SG9QNXFCTVBadGF4V05lbzdMd2NoTGYydGlYQ2Iw?= =?utf-8?B?RUs3M0pUakNURUdXNnFkZzZ4NDFBOUVUbU16Z1ltVE9jWnRJaUJlZ1M3TUZL?= =?utf-8?B?ZDd2ajNFYjJRa2RaT0R2NmNnQ3diUTMzVllWTjFqSjlDVHE1V1ErVFR6M3lG?= =?utf-8?B?TkVLOHdPWVo2SnVXaUlkM0F4OGg3cnZTbkZhd2I5V2xGT1lFSFlyaDBpWHhU?= =?utf-8?B?eUZJaXEvR3BJdzUrWi9HcldzSUJlT0FzTVZNUWd0MVpXcXFxY29EM3Y0bGpS?= =?utf-8?B?OTlEdGdEZU9Ec2I3VGJRcVAxR0t2ZE90a3JIS3lnWXNqMXg2R3ZDZE16V0Qw?= =?utf-8?B?K1NHZWVlNGpVaWVudDk3djNYeWM1eitTWjBFRmVDSHVyWTRxTkdZemNMaWhv?= =?utf-8?B?Y3JEejlYZldmSDZCZlNaWkxHdkFLbXorR3FwTE5lWFpmYlQ3WFlwRng5NUpS?= =?utf-8?B?bDFoZmFvZDRWRFlnR1NnTU1ZcUlPNGNjZDM0a2c2TWovZzRFK0JCalhtallh?= =?utf-8?Q?Hzvl6wg8NbCdyacpkudcKn7sNfAT+F1+8WTtMCLyS4=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 728d6f38-1db9-4c83-2eb4-08d99edc3b2a X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5065.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2021 15:11:37.4509 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Nj57kIz2Gz3stA5ZLIF6B0SJ1UHRLdufghQljTzpWDj6qmK52wqHub3RL5YaoXOWrVIm99BsIH4CzqIs4+W1yg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5292 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Nov 2021 15:11:42 -0000 >> >> Similarly to the is_implicit_ptr_at method, the existing function >> callback interface of the computed struct value, requiers a way to >> apply indirection to an implicit pointer on a given offset of a given >> length of an underlying location description. >> >> This is different then reading from a struct value object (previously > > then -> than > >> described write_to_gdb_value method) in a way that the result of this >> operation is expected to be a struct value of a pointed source level >> variable instead of reading the value of that variable. >> >> In the same way this is also different operation then the deref method > > then -> than > >> >> + /* Recursive indirecting of the implicit pointer location description >> + if that location is or encapsulates an implicit pointer. The >> + operation is performed in a given FRAME context, using the TYPE as >> + the type of the pointer. Where POINTER_OFFSET is an offset >> + applied to that implicit pointer location description before the >> + operation. BIT_OFFSET is a bit offset applied to the location and > ^^ > Two spaces after the '.' here. > > Best, > Lancelot. > All good points. Thank you. Zoran