From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by sourceware.org (Postfix) with ESMTPS id 984583858430 for ; Tue, 9 Nov 2021 17:52:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 984583858430 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f44.google.com with SMTP id u1so34410580wru.13 for ; Tue, 09 Nov 2021 09:52:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=KSqBkDpQSGMJtYzs6YRzR+efFNt/ROT6M5n+7fRNWbA=; b=EJYMACgPkiyEIbbhM5qr6oF+1iD8rzLHKuGd8eSUoyjIxN/8/JN6CGSQW1WgebwBPZ 40qASI+3R6wP8x6TiRoEUo4Ra7ExAoIs5EFfeOV6sO4bv/4hWwFBhHLmcwNuJWhpX6/T qeMOJGjTsLw0/MuA33PZ4N+e3Z0KEKY2sP/eoRyKIn+p3sEqB8EYpstaezEk2sWMjGX4 yBTeFc2hUdP2BPv6TfvXlRhqRAMlSIjWv49pJvBWOUMaujslWMA5ESMCOnUnMhzHwtd0 ZbRyQG+GeU2IKRbXwLos0HN1/LsOz3BoTTSn5jcUAQv7zYVWPbzAQ7ehvsy0cGom4qLu P6XA== X-Gm-Message-State: AOAM5313jNLPr0vvVmWMNyGv+MvuncIDEhyjdqFcQOBcT8W1woE0CjwF lHj1P+6b4nbOKGFhXYNOrzJ8fzZPW9zw7A== X-Google-Smtp-Source: ABdhPJz6y1qOewUw+D50Nt88mAF5t5Nr/RIhx3zTxWHBtc+SYDkvOteOfcsRc0QdgjSq4ZMkSGs6Fw== X-Received: by 2002:a5d:59aa:: with SMTP id p10mr11504615wrr.210.1636480342738; Tue, 09 Nov 2021 09:52:22 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:fb57:3faf:e98:b979? ([2001:8a0:f912:1a00:fb57:3faf:e98:b979]) by smtp.gmail.com with ESMTPSA id r8sm25420263wrz.43.2021.11.09.09.52.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 09:52:21 -0800 (PST) Message-ID: <7300bb4f-c171-8646-41ec-3753a77cad4b@palves.net> Date: Tue, 9 Nov 2021 17:52:20 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: [PATCH] gdb::array_view slicing/container selftest - test std::array too (Re: [PATCH v2 2/2] Improve gdb::array_view ctor from contiguous containers) Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <8acafb4f-ef32-2de8-e71f-8243386b8159@palves.net> <20211103222015.50988-1-lsix@lancelotsix.com> <20211108230217.sejrgqlvs4ju2c2c@ubuntu.lan> From: Pedro Alves In-Reply-To: <20211108230217.sejrgqlvs4ju2c2c@ubuntu.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Nov 2021 17:52:25 -0000 On 2021-11-08 23:02, Lancelot SIX via Gdb-patches wrote: >> Alternatively, you could mirror the comment from the built-in array tests: >> >> /* Check that there's no container->view conversion for containers of derived >> types or subclasses. */ >> >> >> In any case, this is OK. Thanks for fixing this! > > Hi, > > I just pushed this. Thanks. Looking again, I noticed we don't exercise construction from std::array containers, unlike other tests. This adds it. WDYT? >From 5da7a3deab00d81df9c5fa708520fc05d6a22ffa Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Tue, 9 Nov 2021 17:48:50 +0000 Subject: [PATCH] gdb::array_view slicing/container selftest - test std::array too Change-Id: I2141b0b8a09f6521a59908599eb5ba1a19b18dc6 --- gdb/unittests/array-view-selftests.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gdb/unittests/array-view-selftests.c b/gdb/unittests/array-view-selftests.c index 43b7434d10f..fe211a647b5 100644 --- a/gdb/unittests/array-view-selftests.c +++ b/gdb/unittests/array-view-selftests.c @@ -137,8 +137,13 @@ check_ctor_from_container () } /* namespace no_slicing */ +/* std::array with only one template argument, so we can pass it to + check_ctor_from_container. */ +template using StdArray1 = std::array; + static_assert (no_slicing::check (), ""); static_assert (no_slicing::check_ctor_from_container (), ""); +static_assert (no_slicing::check_ctor_from_container (), ""); static_assert (no_slicing::check_ctor_from_container (), ""); /* Check that array_view implicitly converts from std::vector. */ base-commit: f0bbba7886f5dba158a143bebbd0691591f22b9f -- 2.26.2