public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Tsukasa OI <research_trasio@irq.a4lg.com>,
	Andrew Burgess <aburgess@redhat.com>,
	Mike Frysinger <vapier@gentoo.org>,
	Stephane Carrez <Stephane.Carrez@gmail.com>,
	"Frank Ch . Eigler" <fche@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: [PATCH 3/7] sim/erc32: Add ATTRIBUTE_PRINTF
Date: Sun, 25 Sep 2022 08:44:13 +0000	[thread overview]
Message-ID: <7348f2c7752509c5f784b04a40ffec029d6bc559.1664095452.git.research_trasio@irq.a4lg.com> (raw)
In-Reply-To: <cover.1664095452.git.research_trasio@irq.a4lg.com>

Clang generates a warning if the format string of a printf-like function is
not a literal ("-Wformat-nonliteral").  On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).

To avoid warnings on the printf-like wrapper, it requires proper
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.

This commit adds ATTRIBUTE_PRINTF to the printf-like functions.

sim/ChangeLog:

	* erc32/interf.c (fprintf_styled): Add ATTRIBUTE_PRINTF.
	* erc32/sis.c (fprintf_styled): Likewise.
---
 sim/erc32/interf.c | 2 +-
 sim/erc32/sis.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sim/erc32/interf.c b/sim/erc32/interf.c
index f433b9d55ac..fe8e9e822dd 100644
--- a/sim/erc32/interf.c
+++ b/sim/erc32/interf.c
@@ -156,7 +156,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis)
     return TIME_OUT;
 }
 
-static int
+static int ATTRIBUTE_PRINTF(3, 4)
 fprintf_styled (void *stream, enum disassembler_style style,
 		const char *fmt, ...)
 {
diff --git a/sim/erc32/sis.c b/sim/erc32/sis.c
index 1d3ea139c23..d66f5c4dc9e 100644
--- a/sim/erc32/sis.c
+++ b/sim/erc32/sis.c
@@ -138,7 +138,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis)
     return TIME_OUT;
 }
 
-static int
+static int ATTRIBUTE_PRINTF(3, 4)
 fprintf_styled (void *stream, enum disassembler_style style,
 		const char *fmt, ...)
 {
-- 
2.34.1


  parent reply	other threads:[~2022-09-25  8:44 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-25  8:44 [PATCH 0/7] sim, sim/ARCH: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 1/7] sim: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 2/7] sim/cris: " Tsukasa OI
2022-09-25  8:44 ` Tsukasa OI [this message]
2022-09-25  8:44 ` [PATCH 4/7] sim/m32c: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 5/7] sim/m68hc11: " Tsukasa OI
2022-09-25  8:44 ` [PATCH 6/7] sim/ppc: " Tsukasa OI
2022-10-05 10:57   ` Andrew Burgess
2022-10-06  5:32     ` Tsukasa OI
2022-09-25  8:44 ` [PATCH 7/7] sim/rl78: " Tsukasa OI
2022-10-06  6:36 ` [PATCH v2 0/7] sim, sim/ARCH: " Tsukasa OI
2022-10-06  6:36   ` [PATCH v2 1/7] sim: " Tsukasa OI
2022-10-11 14:24     ` Andrew Burgess
2022-10-06  6:36   ` [PATCH v2 2/7] sim/cris: " Tsukasa OI
2022-10-06  6:36   ` [PATCH v2 3/7] sim/erc32: " Tsukasa OI
2022-10-06  6:36   ` [PATCH v2 4/7] sim/m32c: " Tsukasa OI
2022-10-06  6:36   ` [PATCH v2 5/7] sim/m68hc11: " Tsukasa OI
2022-10-11 14:25     ` Andrew Burgess
2022-10-06  6:36   ` [PATCH v2 6/7] sim/ppc: " Tsukasa OI
2022-10-11 14:27     ` Andrew Burgess
2022-10-12  8:29       ` Jan-Benedict Glaw
2022-10-12  9:39         ` Andrew Burgess
2022-10-12 10:36           ` Jan-Benedict Glaw
2022-10-12 12:15             ` Jan-Benedict Glaw
2022-10-12 12:50             ` Jan-Benedict Glaw
2022-10-12 13:16               ` Tsukasa OI
2022-10-12 12:38           ` [PATCH 0/1] sim/ppc: Fix erroneous error calls (supplement) Tsukasa OI
2022-10-12 12:38             ` [PATCH 1/1] sim/ppc: Fix core_find_mapping diagnostics Tsukasa OI
2022-10-12 13:50               ` Andrew Burgess
2022-10-23 12:46           ` [PATCH v2 6/7] sim/ppc: Add ATTRIBUTE_PRINTF Mike Frysinger
2022-10-06  6:36   ` [PATCH v2 7/7] sim/rl78: " Tsukasa OI
2022-10-11 14:23   ` [PATCH v2 0/7] sim, sim/ARCH: " Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7348f2c7752509c5f784b04a40ffec029d6bc559.1664095452.git.research_trasio@irq.a4lg.com \
    --to=research_trasio@irq.a4lg.com \
    --cc=Stephane.Carrez@gmail.com \
    --cc=aburgess@redhat.com \
    --cc=fche@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).