From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 05CBB3858284 for ; Sun, 25 Sep 2022 08:44:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 05CBB3858284 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 4660B300089; Sun, 25 Sep 2022 08:44:56 +0000 (UTC) From: Tsukasa OI To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Stephane Carrez , "Frank Ch . Eigler" Cc: gdb-patches@sourceware.org Subject: [PATCH 3/7] sim/erc32: Add ATTRIBUTE_PRINTF Date: Sun, 25 Sep 2022 08:44:13 +0000 Message-Id: <7348f2c7752509c5f784b04a40ffec029d6bc559.1664095452.git.research_trasio@irq.a4lg.com> In-Reply-To: References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Sep 2022 08:44:59 -0000 Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to the printf-like functions. sim/ChangeLog: * erc32/interf.c (fprintf_styled): Add ATTRIBUTE_PRINTF. * erc32/sis.c (fprintf_styled): Likewise. --- sim/erc32/interf.c | 2 +- sim/erc32/sis.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/erc32/interf.c b/sim/erc32/interf.c index f433b9d55ac..fe8e9e822dd 100644 --- a/sim/erc32/interf.c +++ b/sim/erc32/interf.c @@ -156,7 +156,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis) return TIME_OUT; } -static int +static int ATTRIBUTE_PRINTF(3, 4) fprintf_styled (void *stream, enum disassembler_style style, const char *fmt, ...) { diff --git a/sim/erc32/sis.c b/sim/erc32/sis.c index 1d3ea139c23..d66f5c4dc9e 100644 --- a/sim/erc32/sis.c +++ b/sim/erc32/sis.c @@ -138,7 +138,7 @@ run_sim(struct pstate *sregs, uint64_t icount, int dis) return TIME_OUT; } -static int +static int ATTRIBUTE_PRINTF(3, 4) fprintf_styled (void *stream, enum disassembler_style style, const char *fmt, ...) { -- 2.34.1