From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94578 invoked by alias); 21 Mar 2018 16:17:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 94568 invoked by uid 89); 21 Mar 2018 16:17:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Pedro, pedro, xavier, Alves X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Mar 2018 16:17:26 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id C181381392; Wed, 21 Mar 2018 17:17:24 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vr96lU_sQvOt; Wed, 21 Mar 2018 17:17:24 +0100 (CET) Received: from Xaviers-MacBook-Pro.local (unknown [10.10.8.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id E1D7B81386; Wed, 21 Mar 2018 17:17:23 +0100 (CET) Subject: Re: [RFA v2] (x86) Fix watchpoint using hardware breakpoint for some distro To: Pedro Alves , gdb-patches@sourceware.org Cc: brobecker@adacore.com References: <1521209212-11264-1-git-send-email-roirand@adacore.com> <9c7c8586-2940-bea9-d3fb-a13b0d38a32e@adacore.com> From: Xavier Roirand Message-ID: <736c9dbb-4583-c425-f20f-fd3bc5cf84e8@adacore.com> Date: Wed, 21 Mar 2018 16:17:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00383.txt.bz2 Hello Pedro, Le 3/20/18 à 4:11 PM, Pedro Alves a écrit : > On 03/20/2018 02:28 PM, Xavier Roirand wrote: > Hmm, that's TRAP_BRKPT nowadays. What was '1' supposed to mean in > kernels of such vintage? What was it's symbolic name back then? As far as I can see in header file (/usr/include/bits/siginfo.h), this is the same value, it's: TRAP_BRKPT = 1, /* Process breakpoint. */ > In the table in linux-ptrace.h, we see that modern kernels report > TRAP_BRKPT/1 for the "single-stepping a syscall" case. What do > those older kernels report in that case then? When "single-stepping" syscall, the same value (TRAP_BRKPT) is reported. > What do those kernels report for hardware _breakpoints_? Is it 1 too? Yes, I've checked this and it's 1 also. > Wondering whether we should make GDB_ARCH_IS_TRAP_HWBKPT return > true for 1 too... > > Please provide a more complete picture. > Is it enough or do you think I need to provide more info ? > Thanks, > Pedro Alves > Regards.