From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] C++-ify parser_state
Date: Thu, 30 Nov 2017 05:49:00 -0000 [thread overview]
Message-ID: <737f8c6ee396927a68c00c74610c8cac@polymtl.ca> (raw)
In-Reply-To: <a0f4739f7fb6e8d5447211ffb771ac7e@polymtl.ca>
On 2017-11-29 22:54, Simon Marchi wrote:
> On 2017-11-29 22:29, Tom Tromey wrote:
>> Simon> Passing a pointer or reference to the unique_ptr would allow
>> Simon> the implementations of la_post_parser to modify it directly,
>> Simon> and avoid the .release ().release ().
>>
>> I'll look into it.
>> The realloc thing may be an issue here as well.
>
> I think this should be enough (the commit on top):
>
> https://github.com/simark/binutils-gdb/commits/parser_state
>
> Simon
Oops, I realized I only answered half the question. I added a second
patch on top.
Simon
next prev parent reply other threads:[~2017-11-30 5:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 17:40 Tom Tromey
2017-11-27 14:17 ` Sergio Durigan Junior
2017-11-27 16:41 ` Simon Marchi
2017-11-30 3:29 ` Tom Tromey
2017-11-30 3:54 ` Simon Marchi
2017-11-30 5:49 ` Simon Marchi [this message]
2017-12-09 4:41 ` Tom Tromey
2017-12-10 21:23 ` Simon Marchi
2017-12-31 0:04 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=737f8c6ee396927a68c00c74610c8cac@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).