From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Eliminate the 'stop_pc' global
Date: Thu, 21 Jun 2018 20:10:00 -0000 [thread overview]
Message-ID: <739c53ba491566e6f64440d45d3d40bc@polymtl.ca> (raw)
In-Reply-To: <20180621165501.17051-1-palves@redhat.com>
On 2018-06-21 12:55, Pedro Alves wrote:
> In my multi-target work, I need to add a few more
> scoped_restore_current_thread and switch_to_thread calls in some
> places, and in some lower-level places I was fighting against the fact
> that switch_to_thread reads/refreshes the stop_pc global.
>
> Instead of piling on workarounds, let's just finally eliminate the
> stop_pc global. We already have the per-thread
> thread_info->suspend.stop_pc field, so it's mainly a matter of using
> that more/instead.
Ohh nice. I don't know much about this area, but I read the patch and
nothing caught my attention, so it LGTM.
Simon
next prev parent reply other threads:[~2018-06-21 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 16:55 Pedro Alves
2018-06-21 20:10 ` Simon Marchi [this message]
2018-06-22 16:56 ` Sergio Durigan Junior
2018-06-28 16:39 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=739c53ba491566e6f64440d45d3d40bc@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).