From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109312 invoked by alias); 21 Jun 2018 20:10:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109291 invoked by uid 89); 21 Jun 2018 20:10:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Jun 2018 20:10:46 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w5LKAe1O028187 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 21 Jun 2018 16:10:44 -0400 Received: by simark.ca (Postfix, from userid 112) id ECCB31EF29; Thu, 21 Jun 2018 16:10:39 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 2F1431E059; Thu, 21 Jun 2018 16:10:39 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 21 Jun 2018 20:10:00 -0000 From: Simon Marchi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Eliminate the 'stop_pc' global In-Reply-To: <20180621165501.17051-1-palves@redhat.com> References: <20180621165501.17051-1-palves@redhat.com> Message-ID: <739c53ba491566e6f64440d45d3d40bc@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 21 Jun 2018 20:10:40 +0000 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00534.txt.bz2 On 2018-06-21 12:55, Pedro Alves wrote: > In my multi-target work, I need to add a few more > scoped_restore_current_thread and switch_to_thread calls in some > places, and in some lower-level places I was fighting against the fact > that switch_to_thread reads/refreshes the stop_pc global. > > Instead of piling on workarounds, let's just finally eliminate the > stop_pc global. We already have the per-thread > thread_info->suspend.stop_pc field, so it's mainly a matter of using > that more/instead. Ohh nice. I don't know much about this area, but I read the patch and nothing caught my attention, so it LGTM. Simon