From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2041.outbound.protection.outlook.com [40.107.94.41]) by sourceware.org (Postfix) with ESMTPS id 475AE3858423 for ; Fri, 27 Jan 2023 16:03:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 475AE3858423 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HJU6kd8dyibY9cxucdm9go+VzAkGvhD6xOc5De9km0Z+3hmuk2DjhYP66uiMXLZu969t8zlWtNzbEzRXs9sGgBEYt6fVTbweisoB1d6bU7djOXsMWZIs/6U7VgsGmemHfwQ8kx2Bsb3bGITfESEv0xJV54Llqsc+L6eKtGR6QtjggKia0eid6etMM2ucXntQ72Gnt9Fsi0xHCIh/D/9C4+EjxZLyaZ68ErNVlTOvtZe1mA7YEpHm5SZzaIyx2Gcn/E0zCps71M4tZSuPDOrga4jXm195fZJ+dFty6nxLVfNPu2OhaDKRlOt81/yMbsNMBSDSOjZqlFsaOxSqLTgLWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uytus4eDqYAzc9s61GujCf0U1qf2dKpyVs3UZsGtTwE=; b=Mx/AC87pvz0cMfBlK7EO1KXJ2VTzpc3RozVfDbL2ZPhrFhhwXYw1ux7HkB5z8AJKZneZ99t2krmyEYx7NlFkOSbUkV2x3Tw83Aq0LSbA0Rx1UClpLFPZunVlm9T6bfnjV+m8UH8j8l0uJCitZmz0OmN50ZaSVuXVUlrY8dpmH3BMiWTFIaOuM1VmZJm8X2nKv8vPQF9EF1+dU6JSjIrqf3+18Nr4ziRh6CSA5UrlcjJ31gzIfW7vfMMM9PHAna3KjjqIz+T8S1HgmqKdmq5G+QKWSfKCOMDi8wFPivimXpyBPfpTbJ/xaHpITNAhRvAH2J8Huh2zZDzpSVcK/Up5Aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uytus4eDqYAzc9s61GujCf0U1qf2dKpyVs3UZsGtTwE=; b=E87kB6XLq7oj1uphpvkRYmB6TbsEbAK6hO1CJPqIBPjcEVzoyzMhhZLynN1xFWFlbh4sspAQn/ahGQ2oZZ/OHImWrR8LkKP03Tv6W6q/TwFCPB0Un0+kONoI8a6zWhfeE65lzJGU86fVdj2tBRRpodbSk8rZg4Ma+Hf5iW+M9ri5mne2GmEBVVqrrqU/yoSv13qVZKMOS4NoHelNgRlLpoZXQr5G0Vz6gB/p1KmXGzezvfB82RmIIrtYKPXKHlryNGzJzmGvWF5YyIdlh8sZxW47okchmkpxHnbLYtr0nXzX6go7Jc3GthMiUVzJ9+sdy0CcPIlTJxGM2Bc553ZMvw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB8513.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:9e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.23; Fri, 27 Jan 2023 16:03:05 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::ca4c:b759:c2f5:c976]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::ca4c:b759:c2f5:c976%5]) with mapi id 15.20.6043.022; Fri, 27 Jan 2023 16:03:05 +0000 Message-ID: <73cc8a21-9511-ac28-c8c1-45e4195dd880@efficios.com> Date: Fri, 27 Jan 2023 11:03:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] gdb/dwarf: dump cooked index contents in cooked_index_functions::dump Content-Language: fr To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20230127051317.700077-1-simon.marchi@polymtl.ca> <87mt64qcmh.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87mt64qcmh.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQXPR0101CA0021.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:15::34) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB8513:EE_ X-MS-Office365-Filtering-Correlation-Id: 54832762-fa7b-45b4-06db-08db007ff96e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vdoYMhUYJGHUU9EAsVtgGw4LumStJBrQV49zI8dUCjPJbHbbmXWs41dqrS2e5tflyirQXlPCgO5GWgTNHmA9aXj4fViraP0p3FRwb0kMNCJ4YUL6RbC7361DD76ym+AEKL09lp3tQWmlP5HbPBAbJrdLcjj3TcvFy29KGIMsLNK3uXW4Pm3FQm7UsxnnNKOHDqaCjuxbTG62fj3f2GXcHqZYdot4h1MVInS4qMOe4EmUFKjE6aAWpbUTwi4gHcCTRklFC6xJli3Oyb+qTTHYwSuHFczFRj9BWkFIpRXbntD1Tg6lcFmuHW/L9+YO/EpFq9wvpqDgQsfsfrSO9kgEhuuQZSlHjkxF0IwlEvfz7ObrteGXA4cYS0QxYjx0F2Ppp7KwLvQfTuDfmrEwZzZCpqYmmEraR1TZ4dAFcp0Js3wEum94A7M+kB6+amxOiNmBpCUxPod73DJTVaIZEPvYPyKDGoi/meS64Qxr+Ojy8+xi/8Ntce+sYrGXZOkCGuZ94Q/inrYdpYpQiiGjXM1jeeBJsln0RExtCm5iACwFXS2EUSORXj7oEfVG93S3b8IFup74Jzko+6tFl7NOioqOI5Xs0u1y0ddw/K4pew7PflMsJntgSIWP528QvNkm7jRfJ9RRHOgXOIdLY/aNLaZJkx5f13U6a691n+1uR7PSecH0Mjo0Lz44fDdRlEtA/6lSIF4mN3TjyVDYjXcxOVUe0BhCU8LDz0Y0/lmXLV+xuXQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(366004)(39830400003)(136003)(396003)(346002)(376002)(451199018)(31686004)(2906002)(36756003)(44832011)(4744005)(5660300002)(31696002)(38100700002)(4326008)(66476007)(66946007)(8676002)(66556008)(6512007)(41300700001)(110136005)(6506007)(2616005)(26005)(8936002)(186003)(478600001)(6486002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjUvcUpZRkd6ZkRYZi9XbHVJNC85aWZaY0xxVDFSWTFzUlUwTkdldnppY1Fv?= =?utf-8?B?NTZJeS9ZT1lzNkpXTkI3OUNoNEFWbHBTQ0FlVWpMRUk1Z00vZlZ4UFlkY3VL?= =?utf-8?B?UEovaXZuWWEwZ3RvNHZTOU5kNWtsS3hQWmpEWnFzSVc4ek9jMTZyM0pxdWNG?= =?utf-8?B?V2ZMOXNZeTlBWUdPNTkybEpCRGhJUkloV2ZaOUlobEt6MCs5MXRoNG1LQ1d0?= =?utf-8?B?UGw3cjl2K2lXV1JEaExkbERwNUpobFJZUWxsNlUzY2p2YUgxWEtsTXRWNmNH?= =?utf-8?B?VDdrdWpYWnErc3FiTi9wZHlYRkIzdWZ0SHA2ajFHU1FVRWdUSDlHc3YwQWZ1?= =?utf-8?B?NUo5SllBbWRNSHB3ZHNSTFZrNlN2NGRac0xYK0xIbEROamthZHM1aW9kZENQ?= =?utf-8?B?ZVVmcVVkc2JOQlRiVmlYVGcrT0tHcEJtbmpuNGVNSitKRldwWnRrNGVFQ1pL?= =?utf-8?B?TnFhZUhoUzdqUHhsR3dEZ0pKdnlnbHZlZyt4NXMyaXEyanE1bFYwM0FNL2NV?= =?utf-8?B?R3k4b2d0SXFKeC9iaXJmU3l5ZitSa3ZSYXUvWnU1T0dzdWViWCtybU53NVlu?= =?utf-8?B?WmxHeWdJQTVDVjZ4ditmNmJwSmwwcGNNUkRIYzRuRlVWOVhwWmJzQmM3RnhE?= =?utf-8?B?djBCMlpLMy9xbC9DejE5K3l6MFhHaFlLVkE1dy9kK1R1ZDVlL28zRnI3cFo4?= =?utf-8?B?dVRiRU9DZ1BjZWlGd3FpK1hXbzJ2eTBOalJvZU9ISlBTbTU5ZUFkSXkrWnJW?= =?utf-8?B?ZDlHanNyMnM2Y3BwNUN1MHlQc3k1eStmVy9MeGFOeHpGVlpXa2NhbVJQY2U4?= =?utf-8?B?VEZEK0VCenQvZFZuK1VPSXNnZ2RmWTYwWDFvTFgva04yTngyQWVNbFVXeFhS?= =?utf-8?B?UzYvY21tSUNzMVh0YzVHQkR6NmwwZDFlVmc4SFpkZmZCRUNyQ2RHTUwwYUpW?= =?utf-8?B?QlNYc0hTUjNMRjUzT3VySExXb29DV0FOM0pPc20waW9sTlg2alRreW13TG56?= =?utf-8?B?RXpzbmlaNjFjbEhJd2RSUVRDVU10V0o2TC9hOGM2TzlMU1lWc29iS0R0V3g1?= =?utf-8?B?MUVrN2dIVEY4NllYelNyaDRaUnJmQVBzWi8wdTZVRy80Q29KT1N6cGtOamt5?= =?utf-8?B?L2dEQnhMYWh1ZVpiMlBtN1BWZENlajVzMEx2ZjI5b3d2MllaSVNoVnVBbC9n?= =?utf-8?B?THBtQ1JKWGhBd1hQR3ZFOWo5ODIzaHFEY1VERTVmV3oxVlFXdGhGczdwa0JS?= =?utf-8?B?bUgwcU1mM3lzWkZpbzI2ZUdaN2JhUllCU0ViYmdDcmZLTzZMSGEyRVA4OUNU?= =?utf-8?B?ZWVhSnFvZ09McmtIRUdXL095bWxiTnkxM25tNXUyTzhrWWZ6SmRtdFNzOWdh?= =?utf-8?B?MEg1bytxZ0NYUmo1Qyt1MnNVVkwzaVNMV3FEY2NJSXJlMWF4Y1lxY3gzMW9C?= =?utf-8?B?RFY4bzZxSzZIdGprd1dicjFKRE5CN2VpRTlCWU5ON2NZS2xqOTl2cWhqT3pJ?= =?utf-8?B?NDZhNXVtRzdKeE1TT2R2b3RnOWJ2MXhUZ0lHSi80dVBMSWl1ZStFcDZKT3ds?= =?utf-8?B?bnMzNkdSS1BKSmtPbUQwZ2JTODdFODI2bFNDTUlXQzN1cGwvTU5mNzhpZ2VG?= =?utf-8?B?NzdMdDBRdi9zOXhxMlBHRGpLVUJVK3NQa29aMmh3MG11ekRIcFA4YlMrQlFa?= =?utf-8?B?VU40WHVDb05DRHVzd0FOL3B5b1ZobGFOMzI5L3NIM2M0RVpwZ2x0aGRPVWpM?= =?utf-8?B?NFZrM2lNS3NENUNWWE9MYnVpM09MdDlMSENPckMwUEZiRDl0czhqb2JJVVdD?= =?utf-8?B?ODFjMTV3b1RINk5PeHhQVy9iMkswK0MwMUMwSUZuQmt6S21VMHkwMUJ3TGtm?= =?utf-8?B?UytSdnFPMnk1dzR5V3R5allkeVVyTFF2cEpVdGtZMUR4Z25nVWNxYkdIcVZ1?= =?utf-8?B?UEREM1FmN2kxYXJKbnpqV25wc1lieDkvUWR1M0ZjOW5Wblc1T091OFVUd2J5?= =?utf-8?B?VC91bG9mZEY0b1owNXdxN3I4U3RYLzN3dWIwQWsvNnkxdWlCT3hrVlNTVDV1?= =?utf-8?B?YUdvVVh3alkwUzFENzZ6bGJ2S2t3R1k1VVJ0KzA0SURmbThRZjV4R2hRQmsw?= =?utf-8?Q?4Glv7wn2U1a8zj1Krilo7fMJX?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54832762-fa7b-45b4-06db-08db007ff96e X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 16:03:04.9734 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sqN8fEeXHsfstWmi8iB/yAMdDf4Se6wWCXbju8ibiHkcBxnQWa2Fyb8NpXAzThH4M4bQ7mABNY1sR8z2SCFo6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB8513 X-Spam-Status: No, score=-3033.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Simon> + > Simon> + dwarf2_per_objfile *per_objfile = get_dwarf2_per_objfile (objfile); > Simon> + > Simon> + cooked_index_vector *table > Simon> + = (gdb::checked_static_cast > Simon> + (per_objfile->per_bfd->index_table.get ())); > > Like right here could be a method call. > > The cooked index dumper should probably start with a call to 'wait' to > ensure that no background work is being done. Ah, that makes sense. > Simon> + const char *start_addr_str > Simon> + = paddress (current_inferior ()->gdbarch, start_addr); > > I was curious why the inferior.h include was needed. > I suspect the objfile's arch is preferred here. Ah, I forgot that objfiles had arches. Makes sense. I'll send a v2 with those fixed. Simon