From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 665BA3858418 for ; Thu, 18 Aug 2022 07:25:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 665BA3858418 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-582-4LNqEdoSO8mcQLWhgyyVHw-1; Thu, 18 Aug 2022 03:25:33 -0400 X-MC-Unique: 4LNqEdoSO8mcQLWhgyyVHw-1 Received: by mail-wm1-f71.google.com with SMTP id i7-20020a1c3b07000000b003a534ec2570so777208wma.7 for ; Thu, 18 Aug 2022 00:25:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=BNEadijW5RLbndDl+GAznIUbM5xTFxEyXh7otAgBmFY=; b=nTdEsUMFrgZeNTeTsSLCnwk3IgEQC/4Biei7tTHhyIwchBlc0fT6YLBrrCL6HctPIM f52/0p93cFGrpi5qDn+t1+ViNOO1Bp9vtGLzpyDJIPYoZs+bdPvYUbNfHWOyHKfjauWa Siie4QjfePRhmAlJPkRCuIJNYo5ovjYE08fYHcxS0yA34mqdSZwS+5TNdw0zsqSHMHX4 ftJTHo4Y1G7Rf5Gxex3m3Fg7mlHLX1Qq7ZVM8hLkPa72Y9Bh/00tCTCEtAXv6iPGTI2C +0QNVBfFIOtxAwj0Osc6s1NqrjNGrXHtXivDNUu3GbO2dtuRQ4VX/dh7n20jWDmCHZxW nOuQ== X-Gm-Message-State: ACgBeo0v4pYKcdstBrhRAWEBJKpM7UCSh+W4rEKs6BADD/QDsb/Oad7r 9lEA3EdTaF0f0iWBNzJB+52NJyWN/bl80IIjOfUQHXsiGACFprNEdaGWWXBno1D7og9ZdM9RRF2 3dj2EkLtmjxJb6C3fr46PVA== X-Received: by 2002:a05:600c:2317:b0:3a5:a3b7:31f with SMTP id 23-20020a05600c231700b003a5a3b7031fmr4212833wmo.6.1660807532350; Thu, 18 Aug 2022 00:25:32 -0700 (PDT) X-Google-Smtp-Source: AA6agR72D5eIeSAsA8td3F5wTFHM4O7Q/O/8I8wzPME6nqvI2ij18GVlwbns+VwlF3wC56MTQZFDxQ== X-Received: by 2002:a05:600c:2317:b0:3a5:a3b7:31f with SMTP id 23-20020a05600c231700b003a5a3b7031fmr4212816wmo.6.1660807532130; Thu, 18 Aug 2022 00:25:32 -0700 (PDT) Received: from [10.43.2.105] (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id x2-20020adfffc2000000b0021e5bec14basm601022wrs.5.2022.08.18.00.25.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Aug 2022 00:25:31 -0700 (PDT) Message-ID: <73fc7290-2168-adcf-b97b-01d81968bcdf@redhat.com> Date: Thu, 18 Aug 2022 09:25:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: [PINGv2][PATCH v4 00/15] Clean gdb.base when testing with clang To: Bruno Larsen , gdb-patches@sourceware.org References: <20220720194441.168906-1-blarsen@redhat.com> From: Bruno Larsen In-Reply-To: <20220720194441.168906-1-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Aug 2022 07:25:37 -0000 ping 2! On 20/07/2022 21:44, Bruno Larsen wrote: > When testing GDB with clang, gdb.base had over 50 more failures than when > testing with gcc. Examining the failed tests led to a few clang bugs, a > few GDB bugs, and many testsuite assumptions that could be changed. > > After this patch series, nothing should be changed for testing with gcc, > and testing with clang should only show non-trivial failures for > maint.exp and macscp.exp, along with the same GCC failures. > > Changes in v4: > * Added new test to step through a function's epoligue > * renamed gdb_step_until_regexp -> gdb_step_until > * small style and wording changes in patches 1 and 2 > * Dropped patch 3 - no longer necessary > * patch 4 was reworked based on Andrew's suggestion > small note, Andrew has OK'd patched 5 and 6 (currently 4 and 5) in v3; > > Changes in v3: > * Fixed some issues that only showed up on CXX_FOR_TARGET=clang > * rebased on current master > > Changes in v2: > * Introduced gdb_step_until_regexp, based on Pedro's and Andrew's suggestions > * reworked fixes for: skip.exp, skip-solib.exp and msym-bp-shl.exp > * Used Pedro's suggestion for call-ar-st > * reordered patches slightly > > Bruno Larsen (15): > gdb/testsuite: introduce gdb_step_until > gdb/testsuite: Add a proc to test where compiler links the epilogue > Change gdb.base/skip-solib.exp deal with lack of epilogue information > gdb/testsuite: change gdb.base/nodebug.exp to not fail with clang > update gdb.base/info-program.exp to not fail with clang > fix gdb.base/access-mem-running.exp for clang testing > Fix gdb.base/call-ar-st to work with Clang > add xfails to gdb.base/complex-parts.exp when testing with clang > gdb/testsuite: fix gdb.base/msym-bp-shl when running with Clang > explicitly test for stderr in gdb.base/dprintf.exp > gdb/testsuite: Update gdb.base/so-impl-ld.exp > [gdb/testsuite]: fix gdb.base/jit-elf.exp when testing with clang > gdb/testsuite: fix gdb.base/info-types-c++ with clang > gdb.base/skip.exp: Use finish to exit functions > gdb/testsuite: Add test to step through function epilogue > > gdb/testsuite/gdb.base/access-mem-running.c | 2 +- > gdb/testsuite/gdb.base/call-ar-st.exp | 13 ++- > gdb/testsuite/gdb.base/complex-parts.exp | 5 + > gdb/testsuite/gdb.base/dprintf.exp | 10 ++ > gdb/testsuite/gdb.base/info-program.exp | 2 +- > gdb/testsuite/gdb.base/info-types.exp.tcl | 109 ++++++++++++------ > gdb/testsuite/gdb.base/jit-elf.exp | 2 +- > gdb/testsuite/gdb.base/msym-bp-shl.exp | 8 ++ > gdb/testsuite/gdb.base/nodebug.exp | 12 +- > gdb/testsuite/gdb.base/skip-inline.exp | 23 ++-- > gdb/testsuite/gdb.base/skip-solib-lib.c | 3 +- > gdb/testsuite/gdb.base/skip-solib-main.c | 3 +- > gdb/testsuite/gdb.base/skip-solib.exp | 12 +- > gdb/testsuite/gdb.base/skip.exp | 32 +++-- > gdb/testsuite/gdb.base/so-impl-ld.exp | 13 +-- > gdb/testsuite/gdb.base/solib1.c | 5 +- > .../gdb.base/step-through-epilogue.c | 15 +++ > .../gdb.base/step-through-epilogue.exp | 86 ++++++++++++++ > gdb/testsuite/lib/gdb.exp | 62 ++++++++++ > 19 files changed, 334 insertions(+), 83 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/step-through-epilogue.c > create mode 100644 gdb/testsuite/gdb.base/step-through-epilogue.exp > -- Cheers, Bruno