From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122967 invoked by alias); 20 Sep 2019 10:56:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122959 invoked by uid 89); 20 Sep 2019 10:56:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Sep 2019 10:56:12 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2F9811E595; Fri, 20 Sep 2019 06:56:10 -0400 (EDT) Subject: Re: [PATCH v4] Replace solib_global_lookup with gdbarch_iterate_over_objfiles_in_search_order To: Christian Biesinger , gdb-patches@sourceware.org References: <20190920025847.43084-1-cbiesinger@google.com> From: Simon Marchi Message-ID: <744d88b3-c2af-0a98-c1ff-07ac898d7c5c@simark.ca> Date: Fri, 20 Sep 2019 10:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <20190920025847.43084-1-cbiesinger@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-09/txt/msg00398.txt.bz2 On 2019-09-19 10:58 p.m., Christian Biesinger via gdb-patches wrote: > All implementations of either function use it for the same purpose (except > Darwin, which is a no-op): to prefer a symbol in the current objfile over > symbols with the same name in other objfiles. There does not seem to be a > reason to have both mechanisms for that purpose. Hi Christian, This LGTM, it is fine to push after the SPU removal patch. Thanks, Simon