From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 781CC3858CDA for ; Thu, 19 Jan 2023 22:03:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 781CC3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 933CB5D373; Thu, 19 Jan 2023 22:03:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674165803; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=16bzJctgel3/aGPj+WNl3A9KEvetNUBWSuIqRasbeqg=; b=Te9lpqSFh8G/YABiUqwBg8DlxqvG8/kuniWjwSvZcbcuL5psdj4hVRPMtNz8FGBXqOBQmy fjGsC1iDd5Eq5kh0e7spWomohXr4x2LYBiplHpbf2Go9zAonGHc6RFdYSkwpNL6qSLMaxY t7CvPJmFbtJlIlrAwlHibtWGyGpTZyw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674165803; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=16bzJctgel3/aGPj+WNl3A9KEvetNUBWSuIqRasbeqg=; b=xn665IcK6E5oi+zOpzmnuLYYqzrUMvtAraMyM0DKjgB1bhmOBP79sDTA2FUNFbnwQ4tgvT wmVh6VFzSQ7cXgCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8B7AD134F5; Thu, 19 Jan 2023 22:03:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lQviISu+yWONBAAAMHmgww (envelope-from ); Thu, 19 Jan 2023 22:03:23 +0000 MIME-Version: 1.0 Date: Thu, 19 Jan 2023 22:03:23 +0000 From: tdevries To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Use "maint ignore-probes" in no-libstdcxx-probe.exp In-Reply-To: <20230119185607.1729073-1-tromey@adacore.com> References: <20230119185607.1729073-1-tromey@adacore.com> User-Agent: Roundcube Webmail Message-ID: <745361076afa0335a48885e07cd91240@suse.de> X-Sender: tdevries@suse.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-01-19 18:56, Tom Tromey via Gdb-patches wrote: > While looking at some test output, I saw that no-libstdcxx-probe.exp > was not being run. However, it occurred to me that Tom de Vries' new > "maint ignore-probes" command could be used to enable this test > unconditionally. > --- Hi, nice to see the new command being used :) I've tried out the patch, works for me. LGTM. Thanks, - Tom > gdb/testsuite/gdb.cp/no-libstdcxx-probe.exp | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/gdb/testsuite/gdb.cp/no-libstdcxx-probe.exp > b/gdb/testsuite/gdb.cp/no-libstdcxx-probe.exp > index b10daa638e6..752298af55d 100644 > --- a/gdb/testsuite/gdb.cp/no-libstdcxx-probe.exp > +++ b/gdb/testsuite/gdb.cp/no-libstdcxx-probe.exp > @@ -21,12 +21,11 @@ if {[prepare_for_testing "failed to prepare" > $testfile $srcfile {debug c++}]} { > return -1 > } > > -if {![runto_main]} { > - return -1 > -} > +# This tests that $_exception gives an error when the systemtap probes > +# are not available, so simulate this by disabling them. > +gdb_test "maint ignore-probes libstdcxx .*" ".*OBJNAME: ''" > > -if { [skip_libstdcxx_probe_tests] == 0 } { > - untested "Have libstdc++ stap probe" > +if {![runto_main]} { > return -1 > }