From: Simon Marchi <simon.marchi@ericsson.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>,
<gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>
Subject: Re: [RFA] Remove a VEC from py-unwind.c
Date: Wed, 27 Jun 2018 20:21:00 -0000 [thread overview]
Message-ID: <745711f5-5b82-893a-a20d-25ab1ff7cb36@ericsson.com> (raw)
In-Reply-To: <20180627184414.GB15881@embecosm.com>
On 2018-06-27 02:44 PM, Andrew Burgess wrote:
> * Tom Tromey <tom@tromey.com> [2018-06-05 10:04:50 -0600]:
>
>> This removes a use of VEC from py-unwind.c, replacing it wit
>> std::vector. It also changes saved_regs to hold a gdbpy_ref<>,
>> simplifying the memory management.
>>
>> Tested against gdb.python on x86-64 Fedora 26.
>>
>> gdb/ChangeLog
>> 2018-06-05 Tom Tromey <tom@tromey.com>
>>
>> * python/py-unwind.c (unwind_info_object) <saved_regs>: Now a
>> std::vector.
>> (unwind_infopy_str, pyuw_create_unwind_info)
>> (unwind_infopy_add_saved_register, pyuw_sniffer)
>> (unwind_infopy_dealloc, unwind_infopy_add_saved_register):
>> Update.
>> (struct saved_reg): Add constructor.
>> <value>: Now a gdbpy_ref<>.
>
> FWIW I took a look through this patch and it looks good.
>
> Thanks,
> Andrew
LGTM too, thanks Andrew for taking a look.
Simon
prev parent reply other threads:[~2018-06-27 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 16:04 Tom Tromey
2018-06-27 18:44 ` Andrew Burgess
2018-06-27 20:21 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=745711f5-5b82-893a-a20d-25ab1ff7cb36@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).