From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93193 invoked by alias); 27 Jun 2018 20:21:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93178 invoked by uid 89); 27 Jun 2018 20:21:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=burgess, Burgess X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Jun 2018 20:21:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1530130903; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wAl92AWpW2kVZx/8deFLA3P3jI+W66AK5ps6WwtjJC8=; b=SgDqANj4HP1K913U6CkS5+IYJuhhrfcwlw+kobsYPD7UuSgrt9mD2Ebv6aix2yKf z47T+MwXtkDMXU27gU5Mns2rOfzDZrPfAEpHcWfHXEo/DJWiypzVfQLX69uiOYwU r1iwMAhYRChS1OGF69aOg48ipq9V7gVMNEU2U+e63nA=; Received: from ESESSMB504.ericsson.se (Unknown_Domain [153.88.183.122]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 5D.4F.31169.7D1F33B5; Wed, 27 Jun 2018 22:21:43 +0200 (CEST) Received: from ESESSMR503.ericsson.se (153.88.183.112) by ESESSMB504.ericsson.se (153.88.183.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 27 Jun 2018 22:21:43 +0200 Received: from ESESBMB503.ericsson.se (153.88.183.170) by ESESSMR503.ericsson.se (153.88.183.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 27 Jun 2018 22:21:43 +0200 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB503.ericsson.se (153.88.183.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 27 Jun 2018 22:21:42 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xHt1K1SowFzsu8VAG/6uUOQpPCO468Tmf0Sruilw9MU=; b=IEMLOe6iytRXWeWl9y1g0D3qmc6XbiYoVEd1b9fBhoZ/P7Hu+Yrfbi4yIil39uxh43MlzBYL7lk0P2YcxOCdntu76kI22I+23yE/uJANkBy7Cq90obES6yGxsnXoG5gebFgVMJZoWF2phUfdaDjUNQHX66skWZ+vwCOkZvntXOQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [100.94.229.156] (129.192.64.65) by SN6PR15MB2399.namprd15.prod.outlook.com (2603:10b6:805:24::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.23; Wed, 27 Jun 2018 20:21:38 +0000 Subject: Re: [RFA] Remove a VEC from py-unwind.c To: Andrew Burgess , CC: Tom Tromey References: <20180605160450.19876-1-tom@tromey.com> <20180627184414.GB15881@embecosm.com> From: Simon Marchi Message-ID: <745711f5-5b82-893a-a20d-25ab1ff7cb36@ericsson.com> Date: Wed, 27 Jun 2018 20:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180627184414.GB15881@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00671.txt.bz2 On 2018-06-27 02:44 PM, Andrew Burgess wrote: > * Tom Tromey [2018-06-05 10:04:50 -0600]: > >> This removes a use of VEC from py-unwind.c, replacing it wit >> std::vector. It also changes saved_regs to hold a gdbpy_ref<>, >> simplifying the memory management. >> >> Tested against gdb.python on x86-64 Fedora 26. >> >> gdb/ChangeLog >> 2018-06-05 Tom Tromey >> >> * python/py-unwind.c (unwind_info_object) : Now a >> std::vector. >> (unwind_infopy_str, pyuw_create_unwind_info) >> (unwind_infopy_add_saved_register, pyuw_sniffer) >> (unwind_infopy_dealloc, unwind_infopy_add_saved_register): >> Update. >> (struct saved_reg): Add constructor. >> : Now a gdbpy_ref<>. > > FWIW I took a look through this patch and it looks good. > > Thanks, > Andrew LGTM too, thanks Andrew for taking a look. Simon