From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116478 invoked by alias); 23 Oct 2017 20:04:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116389 invoked by uid 89); 23 Oct 2017 20:04:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:sk:EUR03-V, H*RU:sk:EUR03-V, H*r:sk:EUR03-V X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Oct 2017 20:04:28 +0000 Received: from ESESSHC024.ericsson.se (Unknown_Domain [153.88.183.90]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 87.23.07039.A4B4EE95; Mon, 23 Oct 2017 22:04:26 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.90) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 23 Oct 2017 22:04:25 +0200 Received: from [142.133.48.78] (192.75.88.130) by DB4PR07MB315.eurprd07.prod.outlook.com (2a01:111:e400:982f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.3; Mon, 23 Oct 2017 20:04:23 +0000 Subject: Re: [PATCH] Fix faulty use of obstack_free() to *shrink* dont_print_statmem_obstack. Instead use obstack_blank_fast() with a "negative" size. A real stack data structured would be appropriate here. Added unit test gdb/testsuite/gdb.cp/printstaticrecursion.exp. From: Simon Marchi To: Patrick Frants , References: <1508405381-16638-1-git-send-email-osscontribute@gmail.com> <0d612f89-a3a9-afea-965b-7c364b660235@ericsson.com> <6cc773d7-ee68-5f5c-46f4-cc4a044c9d3e@ericsson.com> Message-ID: <74923492-b63d-b4fa-9682-3394fe47184c@ericsson.com> Date: Mon, 23 Oct 2017 20:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <6cc773d7-ee68-5f5c-46f4-cc4a044c9d3e@ericsson.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: BN6PR21CA0008.namprd21.prod.outlook.com (2603:10b6:404:8e::18) To DB4PR07MB315.eurprd07.prod.outlook.com (2a01:111:e400:982f::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 957a341b-b41c-4d21-4bf4-08d51a514209 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603229);SRVR:DB4PR07MB315; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB315;3:oSKAtK76Ck0u8apKN5iPbOcXUNdmjT0BWJ02icXp44z+6Yu4Y2yoc1zlRPQ1zr91nj4o5+9n4rUlupkHR95ScDq3P5q6b/21+gXWK1koW7t2WaXpgbszBU2nlXqxdwP2rNGRK8Xp6HhA1DexCSdmMTuv+HNGW+tkkqoUres3BllxIE+y9uKcD5ZyUM166hf5ejCQsCL5HY8kn9jb+SnuFCtcibj57N4eMzboa9W6lZSKGIkwbyEZbIo9QTpcgOYB;25:PRwiWIZ9f4/U3U0mgHocWwruXndOO6kc6fmt2aLYfOuW3ibyVh6JaplBYqeKlxl5TVezbm43jCfC/+zj3UuhPlzjnMv9QNCwNjGzN4k/tkNj1lmVST9iDFdAElw7EagbnF31Jw1GDM9IEb5RjsyjNCTRF79Z1RXoidn5M0t/c7l7bDlHF8UzlG9Ai8zF40fBrucvZkrF2voUXn93HxqBGLrmQiI4FhCoocJbn1nosnWtumWq4psyakCuPzD2IteM7dQSlYKpMxF8g4hxPuR1DLuoGSLG/NmMNm9fgX6pJDSGAhKlHcU3CVZlhtojBSFIXQYOTUNrQLpyT6Hc59TzoxbiiKW5xF3wHw4GXylwIn8=;31:arWKXSV2ejEjwuA2v3Gmw7tZlHGwLPzQw1B1kWgh8tGVvbkytqTj+CsBErUM6votxMkzibru6yDkEZA8DdC7zWJUuV3I+F5F9T77Mv8gZOTP+PizD7Gazch1Iv2muLslzSr00oLNAC+0XlEoDSzWG7sizjqPL3dllCjH9D7Wi8HoGY7D4KxFtxd3/j3L0AHIzlgLvFqdijCXEFLPmkwfS5I/XquLfoehbKKAAb5O73k= X-MS-TrafficTypeDiagnostic: DB4PR07MB315: X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB315;20:nVtGIte6aBPgyAYR8d3h9ZGTTw6oITCIhfRTvimxaLN9aLg1O0pnvj6DZrO+vuKM1BSSQTuFvtdMT4/eaOtHt9H8qkiL8Tod7S4SSJ6PGht6eemxXC8uLGOZ+bmayt81RgTP3eaDGONR/e3MGuvrqlrjVJIW/GXPqacFhAtrFgEzm9L8t/p2lQQSWMjcnibBaxOhw+aF5OVL3b9oOurunNrQZcyfvLgJpymgPp2ldCued1J0Sj2fLtoMvhYVUTc02rxzVobUT5S5D8ZIBxlM2y4W31NEL6fui1NvJ/vFasmnVBTwy9a5MkLdH4VruA42Ck9NL7C7x1P+BNxvGETbwbCZSVGfCo80sCIf/m/i1QZUCZdAQ5hnGWnXthpnxmRmyavHUy1c9Zk1TtsQ07DbJkiGWHubjn6q6vvG/hZaxatqR3GQUr9SH3ykf59fEZm7Udqw+CzbTVEsWrWbJXhJ2L/ynTvGjwRkByaeczZl2cfEGuhZp1hsDnJG+6g5rD0V;4:DXtZuGVspiIWI85/dXqI45u2cOHsq1Zgqex2gZHeD2Yway+DPQqSQeAA6sEP+l5o+aQgOq0phgs/Q0h9QB9sUcAoLjzitpQpK90arUa0apVvP1ePCvIt9Y29Zc039PbcArimUQrxYuq6Rz5JZ6+i4l2o+dFm+yYouCdHcl3zNVeohtdkUZAkFZfnL7k3kPGNV7JT1/rPat8/3el907IXlBkFSMXCnHM/uJWufm9NqUodaggjB+fyxQMAoUz1bA3YO1EZ1qIHDa7YBz+mTX7xXuJoHozI6XJtXRILkzcPu0gdw3y8rEkad5jdz32sFWsL9tfoapAggo6qMtlTgmw/NqfDf4xc8siyPDzzrRuqx88= X-Exchange-Antispam-Report-Test: UriScan:(250305191791016)(22074186197030); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(10201501046)(3231020)(93006095)(93001095)(6041248)(20161123558100)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB4PR07MB315;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB4PR07MB315; X-Forefront-PRVS: 046985391D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(39860400002)(376002)(346002)(199003)(189002)(24454002)(377424004)(33646002)(101416001)(105586002)(106356001)(6486002)(229853002)(16526018)(65826007)(2950100002)(5660300001)(50986999)(97736004)(6116002)(3846002)(6666003)(54356999)(4001150100001)(76176999)(50466002)(31686004)(68736007)(64126003)(31696002)(23676002)(65956001)(66066001)(65806001)(86362001)(47776003)(189998001)(2870700001)(2906002)(25786009)(7736002)(305945005)(53546010)(966005)(6246003)(53936002)(6306002)(8936002)(478600001)(83506002)(39060400002)(58126008)(49976008)(8676002)(36756003)(93886005)(81166006)(81156014)(16576012)(316002)(78286006)(219693003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR07MB315;H:[142.133.48.78];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTU7MjM6S3pXcUtWbXFud0psSHQ5Mkk4S05Rekk0ais1?= =?utf-8?B?MU93cTd1cDJCL2lEeHVNY0FUaTFxbTZpcmtsL0FkNzFlU1QwSjNaVTZMcXJ5?= =?utf-8?B?OG1NakJtek54ek1Va3YyYmhsMFZXRmRLdDNlTVVJbnY3ZEwzZFZNQWwya3Rx?= =?utf-8?B?WGRFVGdBcjV0ekFJdGNOYzFTRE8rZFdreUZGS2F6VmhmSVZZS2hWcFlxMnYw?= =?utf-8?B?NTcvbmM0cWd5RWh5RTk4U0NkdWhhb3Y4QmtjMUxvVXdOSTYvTFZGeExFWWRm?= =?utf-8?B?eTMxbVZkRGlzUWpCdVBnM3BGVC9lTlNtODBHdDZnKzFLZXJnbnVVNEdyWDli?= =?utf-8?B?eUNTRnppYmZSQU5uM2xTVDdzMUJlNEVORE5KVThVUDRrZFBrVUZNSmRkYWo0?= =?utf-8?B?S0t5NDM0SmFKbUFhejVraG4wQldGQmt4VmVPKzJ6QUxINHNLNXhWUW13R1ZC?= =?utf-8?B?Q2VLOTBJWjlETVkrRGxVa1grQ3dDR3ozSEZjMGh6Zkk1YmhiT3ByYXFlVGhE?= =?utf-8?B?bnZwYkpZd2w5bGNDeXJTNEMrNnVJTXZSZzhMN01ZYnFnWjIvZ2orLzIwM3l5?= =?utf-8?B?a3Y3VEp2NnZ4V2Vhak1pMnRsV2MzbElYUVUza2NnNDEraWI0cjdvU0c3a21M?= =?utf-8?B?NW1aRWZzUDlWU2E5RkN2VXo3UDlaazlXcjdkOHRVRGVmUi9mV0E2dXdiQ3BU?= =?utf-8?B?NDdBcHRSRG53ZmwvNUc5WXJwV2l5eStLRENQY3JGcUJkUDFxUCtvU29Tc3BQ?= =?utf-8?B?NUxyR2x2dXFySkZYZ3o1aVVXeXdFSHpMOURZNmpXcWdlR3FjUk13dmtPNHpS?= =?utf-8?B?MGYweTZ1QUlyYnkzb0tPSnZuOFk0UmlLSHcrTHBVVkU2OFEvTXhRTVFNSXBR?= =?utf-8?B?Q3pSWmhvYytkbi9YS3FpQ1MzRk9mS3VvSm9VL3hMMzNWaFJtTHIyeWRFRmdh?= =?utf-8?B?SW1ldGMzVzA2OGtzVnNNdGwrMTUyRDl4UTlpYVVnUE5YL3JYOEIwYitrSHd2?= =?utf-8?B?QjBTdHF2QlpiejZJZEp4eUNkeWdWUllHTERQcDZoVmZBRkNCQ0xiZmtYVFli?= =?utf-8?B?QnB1WW4rcGY4bDA2ODdMOGkxQjlML3Z6akZEdTJXakkwV1pGTkpscnA0a0FI?= =?utf-8?B?OVM4alVZUEhzTHBhdkwxaFJoTjN5bFhUQ3dlV3FGTDh6VlF2UzNjZUg4UjR0?= =?utf-8?B?VWpGYTN5M3diZlEwNUUwMEdiay9STnplcDBaOEtJOCsrT3BtTTNuV2RONUhm?= =?utf-8?B?dDNocEp6bmFXTzNhNFplaHYzelB6NWw5U1hOdE1DcnFUWFVSOUVQdUlDdG4w?= =?utf-8?B?RFNSMUdaak04bW5ic1NRMC9rS21kS2lUT0pzZ20zNjJja0JCMUZIMjJkalpu?= =?utf-8?B?SERMQ1p2eHVqaGZsYXFuZFJ5U1hsZnVNSVZIWlJVSGgzNTJaRCtYQW1DYWs3?= =?utf-8?B?aGhLS29FdjRLYUJzRkh0WWVCVHNEMmRMME5tRHJYRW9rMlMwank3RWFLMW1M?= =?utf-8?B?WjREMjZUZUY1OVh5NXNXaHNuMGJCYm9YdkltU0liaC9GT05UTkFpd0VETmpI?= =?utf-8?B?VUpnZEtxZmpreEFCKzA4cHNoK1JqK24raktGelRwZitRQnRGWEJFMTdmekZV?= =?utf-8?B?MmgxNGtkMmNwQmVLeU5NOTdpSzlMVTI0b3ZCYVFiMk9hNnBtdi9MdmJZVFhB?= =?utf-8?B?QWdvN3FONmJ6UjBVLysya3g5dFBRdUZuSEtxckl2YWRJUlMvMXlhZFZXVFVH?= =?utf-8?B?ckU1YThKaGtKSjk3MVM0TzZ1V0VUMXhqRVVEbXF2L21XUnBrcDVPZW9FSWJK?= =?utf-8?B?ZHB2a0p3dkZ2eDlFRVNvQTBtTjYyaWh3RFJRcHg3U29YbGNQMlJHeElSek1T?= =?utf-8?B?ZHFWUkl0V1R2UU9MbFF2WHB1QVBpZEpZODNyZm9QSmJveXhhQy92UXVUWXJ2?= =?utf-8?B?MEFIV2kxY3JrUmJ6R0lGOTRTZnVzUUR4K2JHbmROMHR4RWp4UkF4c1ZKRUt3?= =?utf-8?B?Vk1PRUlaTWEvb2pxbi9Tak1nUERTWFBlUERnPT0=?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB315;6:Kpj2meIulSpkI9dtPFxUXghv0eDZUwLLXBpfB+JTRrv01mytZIIRn2rRkc+iE4WFgdGSqVos8Srv3FhqHh7LxntzCVNdYf1vMkAfzn5K97J7EalkLw04fQNGz8QlVxtElXfRHdsUvIyE+/ydpxAD+7VSovpeFIeACagSCC+NeSSHAxfnlYHdR/iPDx/5Wwv4bIrneyxTcNNql6zlJvvZbujUNs6ocoHydfj8tlSFxUofP4wYtLX1qSNcfuzDzIzSa7p0fd/rYfI7TygVqzoEEoR+olfcjyEONtlfUmQFVp5K9UcqP/r8ttlV/n0cjqDQuUTwyXgCLt8EIMKTNWAaGpcTxAYZLF4JO2Pk6uNC+Sg=;5:RtCtOUX4egKb5foJiFB1CboGqj/U3M+0vRrvomAGoLR9tumQN4+ZAOqJF/rmHA3xIp8Z2bS3fOTp7i3k7ueoIyWN2OsHCu6e2FgHhMEjLhBuoyF0+A1FZtQ6LwxOF5RUdtdYEBVCHIPloJVfdxN9r0/bGXAk8hDkzwANIw4YDI4=;24:oFRX4NgDiM7nPRKcUcMcDumPPB1uOMoqaJqMfQSuDnH+NfPISpF7J/CpIWKMa8P3aosb15d5N1avc8QADd32qysp6XR8y+fwSvJiI95pZlc=;7:2JxZUdvkDB8MCFsEu5yEKlmWN4BRwlgvrvuDk2kPbQbLHkNXjHzJaqqgENXhOIZOxP6+oXt1JkhOJJJ6ypqAuMpZRSwvbQZFPAjUx38yzeD+C3Ixd+nRlb8cC9uN4wmWzCvbBjbRoa1FIa5dYloWbUe3/n1/5x7GwvMvY2cb4oahRnkeN5BtFJnMu4UyDXM6pnLggs7WbRdFyeQSMBkCLA07c9s2unDa8x46g07+QeqNzG72m+8IJt51a9eoGHht SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2017 20:04:23.9903 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 957a341b-b41c-4d21-4bf4-08d51a514209 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB315 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00731.txt.bz2 On 2017-10-23 03:37 PM, Simon Marchi wrote: > I've stepped over the obstack_free call and noticed something strange, it changes the > value of obstack::object_base... > > (top-gdb) p dont_print_statmem_obstack > $6 = {chunk_size = 256, chunk = 0x3b8b5a0, object_base = 0x3b8b5b0 "2\020`", > next_free = 0x3b8sb5c0 "0\270\270\003", chunk_limit = 0x3b8b6a0 "p\265\270\003", temp = {i = 0, > p = 0x0}, alignment_mask = 15, chunkfun = {plain = 0x798604 , > extra = 0x798604 }, freefun = {plain = 0x798732 , > extra = 0x798732 }, extra_arg = 0x0, use_extra_arg = 0, maybe_empty_object = 0, > alloc_failed = 0} > (top-gdb) p free_to_ptr > $7 = (void *) 0x3b8b5b8 > (top-gdb) n > 383 if (last_set_recurse != recurse) > (top-gdb) p dont_print_statmem_obstack > $8 = {chunk_size = 256, chunk = 0x3b8b5a0, object_base = 0x3b8b5b8 "1\020`", > next_free = 0x3b8b5b8 "1\020`", chunk_limit = 0x3b8b6a0 "p\265\270\003", temp = {i = 0, > p = 0x0}, alignment_mask = 15, chunkfun = {plain = 0x798604 , > extra = 0x798604 }, freefun = {plain = 0x798732 , > extra = 0x798732 }, extra_arg = 0x0, use_extra_arg = 0, maybe_empty_object = 0, > alloc_failed = 0} > > > As you can see, object_base goes from 0x3b8b5b0 to 0x3b8b5b8. And indeed, looking at obstack_free, > I see: > > if (__obj > (void *) __o->chunk && __obj < (void *) __o->chunk_limit) \ > __o->next_free = __o->object_base = (char *) __obj; \ > > So when you free, it resets object_base to that point... why does it do that? It doesn't make sense > to me. > > At least, that seems to explain why the obstack is empty after having called > obstack_free, even though we didn't ask it to free the whole obstack. > > Simon > After following a crash course about obstacks on IRC (thanks Tom!), I understood that obstack_free is normally used to free completed objects. object_base points to the beginning of the object currently being constructed, so obstack_free sets it to the beginning of the newly freed area, so that the next object to be constructed will be placed there. In the libc manual [1], it is stated clearly that obstack_blank should be used with a negative size to make the current object smaller: You can use obstack_blank with a negative size argument to make the current object smaller. Just don’t try to shrink it beyond zero length—there’s no telling what will happen if you do that. For negative sizes, obstack_blank seems equivalent to obstack_blank_fast. So I am now pretty much convinced that your fix is good, in that it does what the original code intended (but failed) to do. Could you address the comments from my previous mails and submit a new version? While at it, I noticed there is a missing space in: obstack_blank_fast(&dont_print_statmem_obstack, shrink_bytes); before the opening parenthesis. Thanks! Simon [1] https://www.gnu.org/software/libc/manual/html_node/Growing-Objects.html#Growing-Objects