From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 4BFCC3896C18 for ; Tue, 15 Nov 2022 15:01:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4BFCC3896C18 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0F8CB1E0D3; Tue, 15 Nov 2022 10:01:35 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1668524495; bh=LyyGgKv2ZpV8S+wilJ1Q/mnAuqlcdr9z6vtGcPHbm+s=; h=Date:Subject:To:References:From:In-Reply-To:From; b=GdVUjASzJlGVz/327xydsAsFA5Nku4yiabw5Q4KmgCiGkVWSrhmGVcQ70cuAxDuN5 9c+jyI1CC5xTEGyo2JmE8kL6/NNLrf2EKYpKpU9nzL3+nhec2OVHWAM573kqI0lqdO vtSKCgD7Tqiw/9AtihV5VG/z3T9NM8UdlWGkoN1M= Message-ID: <74ccb7a0-46af-073d-afdc-830ad5d022c8@simark.ca> Date: Tue, 15 Nov 2022 10:01:34 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 00/14] Remove all uses of 'then' keyword from the testsuite Content-Language: fr To: Andrew Burgess , gdb-patches@sourceware.org References: From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/15/22 05:42, Andrew Burgess via Gdb-patches wrote: > It was pointed out to me (off-list) that in this patch: > > https://sourceware.org/pipermail/gdb-patches/2022-November/193744.html > > I had made use of TCL's 'then' keyword, which apparently is not the > preferred way to write if statements these days, at least, not for > single line conditions. And it certainly seems that NOT using 'then' > is more common in the GDB testsuite. > > As my use of 'then' was due to copy&paste from another test, this > series aims to prevent the same mistake happening again by removing > all uses of 'then' for if statements where the condition fits on a > single line. > > The change was generated with sed, I sanity checked them all by eye, > and didn't see any obvious mistakes. Tested on x86-64 GNU/Linux and > didn't see any test regressions. > > Thoughts? Hi Andrew, I'm totally fine with that. Simon