From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id AE82A385843D for ; Thu, 23 Mar 2023 00:18:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE82A385843D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E300C5C07F; Thu, 23 Mar 2023 00:18:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679530692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZV9QWOHqNhUJdeJP2/WJwri7o5Kqw95KgaMxOQYCRg=; b=OijC3tOfLqIKHkgDoLch/jUfOmKDLpJv7QX10b3WdD9Pj2RmkD4LoCK73jUWZnfvigTjnJ V5kuMVw6tibYG4Z/3eoyVX9O5ED/q7xJzDWRRw8rujNN7ZqJ2wfc3+OUh8IxQggduBY4Br Qrz6Xeh3oarZQQDkdBOsv92NlcG12JM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679530692; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZV9QWOHqNhUJdeJP2/WJwri7o5Kqw95KgaMxOQYCRg=; b=+XhbJYgd93yeHRBRqyJAiO/uKc0Wc1c1EmTpXcngwJZ6XxhvAHRi0yrxedhpBnrFfPlOsY 8PilNyhL+Duj1ECw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CB93313413; Thu, 23 Mar 2023 00:18:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JT9jMMSaG2SnUwAAMHmgww (envelope-from ); Thu, 23 Mar 2023 00:18:12 +0000 Message-ID: <74dd1fa6-b4b4-183c-e46a-66e5d6abedd4@suse.de> Date: Thu, 23 Mar 2023 01:18:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [pushed 1/3] [gdb/testsuite] Fix gdb.cp/*.exp for remote host To: Simon Marchi , gdb-patches@sourceware.org References: <20230322083819.14320-1-tdevries@suse.de> <20230322083819.14320-2-tdevries@suse.de> <105cde3c-37ab-af0f-4c5e-8ac9b03dceb2@simark.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: <105cde3c-37ab-af0f-4c5e-8ac9b03dceb2@simark.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/22/23 16:05, Simon Marchi wrote: > > > On 3/22/23 04:38, Tom de Vries via Gdb-patches wrote: >> Fix a few test-cases in gdb.cp/*.exp for remote host using new proc >> include_file. > > Starting with this patch, I see: > > info variable everywhere^M > All variables matching regular expression "everywhere":^M > ^M > File /home/simark/src/binutils-gdb/gdb/testsuite/gdb.cp/m-static.h:^M > 8: const int gnu_obj_4::everywhere;^M > (gdb) FAIL: gdb.cp/m-static.exp: info variable everywhere > Hi Simon, thanks for reporting this. I don't see this on openSUSE Leap 15.4 and Tumbleweed, but I managed to reproduce on Ubuntu 20.04 (though with the readnow board, it disappears again). Anyway, the problem is that I changed the matching to be more strict, and that's what we're seeing the effect of. I'll propose a patch that reverts things to the way things were before, with less strict matching. As for what I'm seeing: ... (gdb) info variable everywhere^M All variables matching regular expression "everywhere":^M ^M File /data/vries/gdb/src/gdb/testsuite/gdb.cp/m-static.h:^M 8: const int gnu_obj_4::everywhere;^M ^M File /data/vries/gdb/src/gdb/testsuite/gdb.cp/m-static1.cc:^M 8: const int gnu_obj_4::everywhere;^M (gdb) PASS: gdb.cp/m-static.exp: info variable everywhere ... the combination of line 8 with m-static1.cc doesn't seem to make sense. I don't know this as a known issue, so I'll file a PR about it. Thanks, - Tom