Re: [PATCH] Add initializers to comp_unit_head

[tdevries <tdevries@suse.de>]

On 2022-12-25 15:33, Tom Tromey wrote:
>>>>>> tdevries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
>> FWIW, I've rebased the patch attached to the PR on your patch, and I'm
>> left with the patch below, which makes the length field of
>> comp_unit_head private.
> 
>>    /* Return the total length of the CU described by this header.  */
>> -  unsigned int get_length () const
>> +  unsigned int get_length (bool include_initial = true) const
>>    {
>> -    return initial_length_size + length;
>> +    unsigned int res = m_length;
>> +    if (include_initial)
>> +      res += initial_length_size;
>> +    return res;
> 
> I think that since the callers all statically decide which length they
> want, there should probably just be two methods with different names.
> 

OK, so how about:
- get_length_with_initial
- get_length_without_initial
?

Thanks,
- Tom

> Tom