From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by sourceware.org (Postfix) with ESMTPS id 74B563858D33 for ; Wed, 22 Feb 2023 18:11:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 74B563858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f53.google.com with SMTP id j3so4405778wms.2 for ; Wed, 22 Feb 2023 10:11:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZGuKHXNjWrkDGyqsGE0rtZkuFj/VS2RzDu4UlQ3pQIk=; b=cScR/TG1w55otjWzXfIYEuEoEXvB30SHKD21NNDDH8embFg0FqbE2Zm2sgMiqEYWSk I9GvJeYFalwVmpmzN00RRSMsI4JV/qeUwFnKW7u+ojBdsvgyGNpamMKP/ylPRnM387Jw 7vukF+JbenvqBJECDzg7ZsO74W4i6gE9MfYD/funRwZ9j8h4UeHF+b2511lFDRb+fWJV wJpqvaxx4BNxKl1q6drjkVamTg4I4nBajdA7u48Gvs4NyQZ/WjeWVGaWni0ySjd1XBg0 5+g0HitUCkRbZbmLd3NChrucISYYm5gGuzc2PyO4XX2LmVbYBFJp2pW0rvMtqDlGwnd6 hLrA== X-Gm-Message-State: AO0yUKX8FkD9yXbsM4RTtVQ4ANfpGRDaDXhZ/QlcdcvV7qWyB2p4u1xJ dE22I4Agbpo9np6SwdZ2fak= X-Google-Smtp-Source: AK7set/v3/BVln2QUhYysq6dVgzaWdeqfT3TIn7n1fJQiVZs3OIFM5Ddsl0qOyNb+kf75BLadJSwGQ== X-Received: by 2002:a05:600c:4aa7:b0:3e2:66b:e90e with SMTP id b39-20020a05600c4aa700b003e2066be90emr1366750wmp.10.1677089467228; Wed, 22 Feb 2023 10:11:07 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id k9-20020a5d6289000000b002c56af32e8csm6961424wru.35.2023.02.22.10.11.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Feb 2023 10:11:06 -0800 (PST) Subject: Re: [PATCH] gdb.reverse/time-reverse.exp: test both time syscall and C time function (was: Re: [pushed] [gdb/testsuite] Require syscall time in gdb.reverse/time-reverse.exp) To: Tom de Vries , gdb-patches@sourceware.org Cc: Luis Machado References: <20230221131027.29637-1-tdevries@suse.de> <5df97d91-9a28-c8b1-053e-82deb52318e4@palves.net> From: Pedro Alves Message-ID: <74fcf54f-585c-2d8a-92c0-e19f21af8a75@palves.net> Date: Wed, 22 Feb 2023 18:11:06 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,BODY_8BITS,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-02-22 5:06 p.m., Tom de Vries wrote: > On 2/22/23 17:12, Pedro Alves wrote: >> On 2023-02-21 1:10 p.m., Tom de Vries via Gdb-patches wrote: >>> On aarch64-linux, I run into: >>> ... >>> Running gdb.reverse/time-reverse.exp ... >>> gdb compile failed, gdb.reverse/time-reverse.c: In function 'main': >>> gdb.reverse/time-reverse.c:39:12: error: 'SYS_time' undeclared \ >>>    (first use in this function); did you mean 'SYS_times'? >>>     syscall (SYS_time, &time_global); >>>              ^~~~~~~~ >>>              SYS_times >>> gdb.reverse/time-reverse.c:39:12: note: each undeclared identifier is \ >>>    reported only once for each function it appears in >>> UNTESTED: gdb.reverse/time-reverse.exp: failed to prepare >>> ... >>> >>> Fix this by adding a new proc have_syscall, and requiring syscall time, such >>> that we have instead: >>> ... >>> UNSUPPORTED: gdb.reverse/time-reverse.exp: require failed: \ >>>    expr [have_syscall time] >>> ... >>> >>> Tested on x86_64-linux and aarch64-linux. >> >> I think the patch below would be even better.  Does it work on aarch64? >> > > It does for me. Thanks. > > FWIW, doing an strace on the exec, I don't see any syscall related to time. Googling around, it seems like Aarch64 uses the vDSO for time. > > LGTM. > Thanks, I've merged it, with one small tweak: >> --- a/gdb/testsuite/gdb.reverse/time-reverse.c >> +++ b/gdb/testsuite/gdb.reverse/time-reverse.c >> @@ -20,6 +20,12 @@ >>   #include >>   #include >>   +#ifdef USE_SYSCALL >> +# define my_time(TLOC) syscall (SYS_time, &time_global) I did not mean to hardcode the global here. I meant to write instead: # define my_time(TLOC) syscall (SYS_time, TLOC) Fixed in the pushed version. >> +#else >> +# define my_time(TLOC) time (TLOC) >> +#endif >> +