From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46106 invoked by alias); 12 Dec 2017 01:25:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46095 invoked by uid 89); 12 Dec 2017 01:25:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=damn, guys X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Dec 2017 01:25:55 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vBC1PnMb004837 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 11 Dec 2017 20:25:53 -0500 Received: by simark.ca (Postfix, from userid 112) id 36E561E59B; Mon, 11 Dec 2017 20:25:49 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 3819D1E4C4; Mon, 11 Dec 2017 20:25:48 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 12 Dec 2017 01:25:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Sergio Durigan Junior , Simon Marchi , GDB Patches , Tom Tromey , Eli Zaretskii Subject: Re: [PATCH v2] Implement pahole-like 'ptype /o' option In-Reply-To: References: <20171121160709.23248-1-sergiodj@redhat.com> <20171128212137.15655-1-sergiodj@redhat.com> <87o9n5drbn.fsf@redhat.com> <99286acb-ce9f-42f0-41c3-ef10e03171ff@ericsson.com> <87tvwxc6t9.fsf@redhat.com> <964bae42-6e60-4e9d-048c-ef570c1d3a5b@redhat.com> <87fu8gdgl8.fsf@redhat.com> <0d314798-6e0d-f7a9-ace8-3cb43bda9947@redhat.com> <87shcg94hp.fsf@redhat.com> Message-ID: <750e0e54f663f81c1f7bf7207bc1e814@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 12 Dec 2017 01:25:49 +0000 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00266.txt.bz2 On 2017-12-11 19:51, Pedro Alves wrote: >>> So from that angle, I see value in not printing the offsets >>> of union members. >> >> Since it's still not clear whether the offsets should be printed or >> not >> in this case, and I am not a global maintainer, I adjusted the code to >> print them and will post the patch as a reply to the v4 e-mail. This >> way you can decide which version is best. > > Fun, just when I agreed with not printing the offsets... :-P :-) Damn, sorry for starting you guys on that track! I just wanted to know if it was intentional or not, I am fine with either. Simon