Re: [PATCH v3 0/3] Enable ptrace support for aarch64 sve

[Simon Marchi <simark@simark.ca>]

On 2018-06-15 12:18 PM, Alan Hayward wrote:
> This set of patches adds the ptrace support for SVE.
> 
> Patch 1 includes macros/defines copied from the Linux kernel headers.
> Previously, there was reservation about the copyright/ownership issues
> about putting this into gdb. These header contents were all fully written
> by Arm, who own the copyright and released it to Linux under GPL3 license.
> This patch simply repackages the same code and releases it with the
> same license and "provided by Arm" comment. There is precedence for
> Arm doing the same in other FSF projects, and it falls within GPLs
> copyleft policy.
> 
> I've also kept all the defines in a single file as it only contains
> the relevant sections from two headers.
> 
> Apologies for the delay on submitting this, as I was seeking
> clarification to the above. I'm hoping this alleviates any concerns.
> It's also a more robust solution than selectively compiling support.
> 
> Patches 2 and 3 fix up all the review comments from v2.
> In particular, patch 3 changes is_sve_tdesc to the only method I
> could find - checking the number of registers.
> 
> Ran make check on x86 and aarch64.
> Tested SVE and non-SVE built gdb on Aarch64 SVE emulator.
> 
> In addition, I've still got the following awaiting review:
> [PATCH] Support large registers in regcache transfer_regset
> https://sourceware.org/ml/gdb-patches/2018-06/msg00303.html

Thanks, the patchset LGTM.

Note the typo in the third patch's title, "gdbsever".

Simon