From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 06BAA38582B2
 for <gdb-patches@sourceware.org>; Thu, 22 Sep 2022 16:13:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 06BAA38582B2
Received: from [10.0.0.11] (unknown [217.28.27.60])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 4E5161E0D3;
 Thu, 22 Sep 2022 12:13:25 -0400 (EDT)
Message-ID: <75190099-2c5e-4616-fbf4-045aa4f5535b@simark.ca>
Date: Thu, 22 Sep 2022 12:13:25 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] gdbserver: remove unused for loop
Content-Language: en-US
To: Enze Li <enze.li@hotmail.com>, gdb-patches@sourceware.org
Cc: pedro@palves.net, enze.li@gmx.com
References: <OS3P286MB21526C37D0DF8D10963532CDF04E9@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <OS3P286MB21526C37D0DF8D10963532CDF04E9@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Sep 2022 16:13:27 -0000



On 2022-09-22 09:30, Enze Li via Gdb-patches wrote:
> In this commit,
> 
>   commit cf6c1e710ee162a5adb0ae47acb731f2bfecc956
>   Date:   Mon Jul 11 20:53:48 2022 +0800
> 
>     gdbserver: remove unused variable
> 
> I removed an unused variable in handle_v_run.  Pedro then pointed out
> that the for loop after it was also unused.  After a period of smoke
> testing, no exceptions were found.
> 
> Tested on x86_64-linux.
> ---
>  gdbserver/server.cc | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/gdbserver/server.cc b/gdbserver/server.cc
> index c619206d5d2d..366a843ea894 100644
> --- a/gdbserver/server.cc
> +++ b/gdbserver/server.cc
> @@ -2984,9 +2984,6 @@ handle_v_run (char *own_buf)
>    char *new_program_name = NULL;
>    int i;
>  
> -  for (p = own_buf + strlen ("vRun;"); p && *p; p = strchr (p, ';'))
> -    p++;
> -
>    for (i = 0, p = own_buf + strlen ("vRun;"); *p; p = next_p, ++i)
>      {
>        next_p = strchr (p, ';');
> 
> base-commit: aaf3f3f3bb38a59125ea34afa0ef7e0e14c2e916

Thanks, this is ok.

Simon