From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90161 invoked by alias); 2 Feb 2018 19:05:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90146 invoked by uid 89); 2 Feb 2018 19:05:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Feb 2018 19:05:02 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w12J4ugh030319 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 2 Feb 2018 14:05:01 -0500 Received: by simark.ca (Postfix, from userid 112) id 6025F1E74E; Fri, 2 Feb 2018 14:04:56 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id CB9711E093; Fri, 2 Feb 2018 14:04:55 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 02 Feb 2018 19:05:00 -0000 From: Simon Marchi To: Leszek Swirski Cc: Leszek Swirski via gdb-patches Subject: Re: [PATCH] MI: Allow non-raw varobj evaluation In-Reply-To: References: <20180124173223.213808-1-leszeks@google.com> <9bc195e52123f5d878778ebebd074ee4@polymtl.ca> Message-ID: <75368b74740c890c3e1a78739bbed799@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 2 Feb 2018 19:04:56 +0000 X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00041.txt.bz2 On 2018-02-02 04:00, Leszek Swirski via gdb-patches wrote: > On Fri, 2 Feb 2018, 04:27 Simon Marchi, > wrote: >> >> Also, from what I understand we don't have a test for this, so I >> converted your example >> to a test case. If you are fine, I would push the following patch. > > That looks fantastic, I'm happy for you to push the amended patch and > thank you for your due diligence. Thanks for the fix, the patch is now pushed. Simon