From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7184E3858D3C for ; Sun, 14 Nov 2021 02:21:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7184E3858D3C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1AE2KKaR031605 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 13 Nov 2021 21:20:26 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1AE2KKaR031605 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A8C421E813; Sat, 13 Nov 2021 21:20:19 -0500 (EST) Message-ID: <757ab640-06e5-7e89-a0a8-6dc355e6edfa@polymtl.ca> Date: Sat, 13 Nov 2021 21:20:19 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 1/3] gdb: Add aliases for read_core_file_mappings callbacks Content-Language: en-US To: Aaron Merey , gdb-patches@sourceware.org Cc: tom@tromey.com, lsix@lancelotsix.com References: <20211110014755.532490-1-amerey@redhat.com> <20211110014755.532490-2-amerey@redhat.com> From: Simon Marchi In-Reply-To: <20211110014755.532490-2-amerey@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 14 Nov 2021 02:20:20 +0000 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Nov 2021 02:21:35 -0000 On 2021-11-09 20:47, Aaron Merey wrote: > Add aliases read_core_file_mappings_loop_ftype and > read_core_file_mappings_pre_loop_ftype. Intended for use with > read_core_file_mappings. > > Also add build_id parameter to read_core_file_mappings_loop_ftype. This patch LGTM, thanks. Simon