From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by sourceware.org (Postfix) with ESMTPS id DF06A3857C47 for ; Fri, 10 Dec 2021 21:56:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DF06A3857C47 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f52.google.com with SMTP id t18so17167167wrg.11 for ; Fri, 10 Dec 2021 13:56:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=zvqf7vbS0VRcK7k9spF7XIsa7H9+IsW5q3s1tMNPKE8=; b=0MKTihtdeKWxi73Wyronij5pbcX7+A8GrB13DlBemvegVFJxpc81lcWCYM3elrCFXR AukDQwoncr/xo7c6uD+TcUhyOvJ+Dw/OHAqQFnH9Q2sxnxYZht10pru1WJAMJWAA3Atd HjHJ0Fw9dD3um8U/qV+muaJzELfGSolc+ma9ANK7ZqfPBVH8GLWkr2az3kkBCSLr7wUH oO06IRLC/ZnVfINsp4uDullHKJ1FkKNEsPbE9KrKWgt72T9KkhqU2MvUoV/D7R515i9q F0NxtGNp09hhkQY2y4LbnT8/alGXVxkrdg1GlKiKJ6fDYnifRYylNVrd/nfMx7d1FzSf S1HQ== X-Gm-Message-State: AOAM533QTtRcE7LjTgOawDin5coGkmqTxz0f+5RWYx6WKgvlasDqHMdW Kx1TtWjBDmJRQdz9qhMaE3kvdjGefCk= X-Google-Smtp-Source: ABdhPJw8/wIHzyoAWLSS0qiio1Gtk1Mj6ER4ghkVjQSQ8VM43ZrDU9AkR1FjmPYmzS5cINneLErUYQ== X-Received: by 2002:a5d:4c4e:: with SMTP id n14mr16531346wrt.514.1639173395984; Fri, 10 Dec 2021 13:56:35 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:d3db:ac91:4b9e:1449? ([2001:8a0:f912:1a00:d3db:ac91:4b9e:1449]) by smtp.gmail.com with ESMTPSA id t189sm3946wma.8.2021.12.10.13.56.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 13:56:35 -0800 (PST) Message-ID: <757f0aed-decd-ab44-619a-2e0d6df59cf1@palves.net> Date: Fri, 10 Dec 2021 21:56:34 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH 11/12] gdb/testsuite: Remove duplicates from gdb.mi/mi2-amd64-entry-value.exp Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <20211126230038.103225-1-lsix@lancelotsix.com> <20211126230038.103225-12-lsix@lancelotsix.com> From: Pedro Alves In-Reply-To: <20211126230038.103225-12-lsix@lancelotsix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 21:56:38 -0000 On 2021-11-26 23:00, Lancelot SIX via Gdb-patches wrote: > mi_expect_stop "breakpoint-hit" .* {{name="inv",value=""}} .* .* {.* disp="keep"} "no: invalid: stop" > mi_gdb_test "-stack-list-variables --all-values" {\^done,variables=\[{name="inv",arg="1",value=""}\]} "no: invalid: -stack-list-variables" > > -if {[mi_runto_main] == -1} { > - return -1 > +with_test_prefix "setup for set print-entry-values only" { > + if {[mi_runto_main] == -1} { > + return -1 > + } > } > mi_gdb_test "-gdb-set print entry-values only" {\^done} "only: set print entry-values" > mi_send_resuming_command "exec-continue" "only: entry_equal: continue" > @@ -83,8 +87,10 @@ mi_send_resuming_command "exec-continue" "only: invalid: continue" IWBN to get this grouped properly while at it. Would you mind removing the "only:" etc. manual prefixes instead, converting that to the with_test_prefix prefix? Like: with_test_prefix "only" { if {[mi_runto_main] == -1} { return -1 } - mi_gdb_test "-gdb-set print entry-values only" {\^done} "only: set print entry-values" - mi_send_resuming_command "exec-continue" "only: entry_equal: continue" + mi_gdb_test "-gdb-set print entry-values only" {\^done} "set print entry-values" + mi_send_resuming_command "exec-continue" "entry_equal: continue" } etc?