From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"blarsen@redhat.com" <blarsen@redhat.com>,
"cel@us.ibm.com" <cel@us.ibm.com>
Cc: "will_schmidt@vnet.ibm.com" <will_schmidt@vnet.ibm.com>
Subject: Re: [PATCH] PowerPC, fix gdb.reverse/finish-reverse-bkpt.exp and gdb.reverse/next-reverse-bkpt-over-sr.exp
Date: Wed, 23 Nov 2022 17:56:38 +0000 [thread overview]
Message-ID: <75b124722aa20466d5044fa115b679b61ff83010.camel@de.ibm.com> (raw)
In-Reply-To: <ace89c525e06240c9bdc08377e1830d818a5988e.camel@us.ibm.com>
Carl Love <cel@us.ibm.com> wrote:
>I have updated the patch, below. If you could take a quick look and
>make sure it works on your system that would be great. Assuming it is
>OK, hopefully we can get a maintainer to bless it and we will get the
>patch committed.
This approach makes sense to me. The one thing that may not be
quite optimal is that having finish-reverse-bkpt.exp use the same
source file as finish-reverse.exp starts looking to be more trouble
than it may be worth.
Would it make sense to create a new finish-reverse-bkpt.c file
that contains just the stripped-down test case (using the function
pointer) required to do the "break *callee" test?
Same for next-reverse-bpkt-over-sr.exp vs. step-reverse.c.
Bye,
Ulrich
next prev parent reply other threads:[~2022-11-23 17:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 16:14 [PATCH] Fix test next-reverse-bkpt-over-sr.exp Carl Love
2022-09-28 7:35 ` Bruno Larsen
2022-11-14 21:05 ` [PATCH] PowerPC, fix gdb.reverse/finish-reverse-bkpt.exp and gdb.reverse/next-reverse-bkpt-over-sr.exp Carl Love
2022-11-21 16:36 ` [PING] " Carl Love
2022-11-22 9:42 ` Bruno Larsen
2022-11-22 16:53 ` Carl Love
2022-11-23 8:44 ` Bruno Larsen
2022-11-23 17:56 ` Ulrich Weigand [this message]
2022-11-23 23:33 ` Carl Love
2022-11-28 18:52 ` Carl Love
2022-11-29 8:52 ` Bruno Larsen
2022-11-29 16:50 ` Carl Love
2022-11-29 16:57 ` [PATCH V4] " Carl Love
2022-11-30 11:30 ` Ulrich Weigand
2022-12-01 1:33 ` Carl Love
2022-12-01 15:50 ` [PATCH V5] " Carl Love
2022-12-01 16:02 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=75b124722aa20466d5044fa115b679b61ff83010.camel@de.ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=blarsen@redhat.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).