From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126566 invoked by alias); 18 Oct 2017 11:46:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 126325 invoked by uid 89); 18 Oct 2017 11:46:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=bare X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Oct 2017 11:46:21 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D1F53A790; Wed, 18 Oct 2017 11:46:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D1F53A790 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0B59581195; Wed, 18 Oct 2017 11:46:17 +0000 (UTC) Subject: Re: [PATCH 1/2] GDB test suite: Add helper for locating core files To: "Maciej W. Rozycki" References: <1505760152-28775-1-git-send-email-arnez@linux.vnet.ibm.com> <1505760152-28775-2-git-send-email-arnez@linux.vnet.ibm.com> <20171007094545.1bba5c51@pinnacle.lan> Cc: Andreas Arnez , Kevin Buettner , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <75d57d56-379a-037f-1db3-c9c563b76d9d@redhat.com> Date: Wed, 18 Oct 2017 11:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00560.txt.bz2 Hi Maciej, On 10/17/2017 07:19 PM, Maciej W. Rozycki wrote: > On Tue, 17 Oct 2017, Pedro Alves wrote: >> Wouldn't an UNTESTED or UNSUPPORTED be better? It's what >> we tend to do with other cases of unsupported/untested tests. > > I think UNSUPPORTED is the right status; UNTESTED is meant for missing > tests really; see: > > UNTESTED > A test was not run. This is a placeholder, used when there is no real > test case yet. > > vs: > > UNSUPPORTED > There is no support for the tested case. This may mean that a > conditional feature of an operating system, or of a compiler, is not > implemented. DejaGnu also uses this message when a testing > environment (often a "bare board" target) lacks basic support for > compiling or running the test case. For example, a test for the > system subroutine gethostname would never work on a target board > running only a boot monitor. > IMHO, this "placeholder" status of UNTESTED is pretty useless, at least for GDB. I don't recall ever adding such a placeholder testcase, and I don't think GDB uses it like that. I think a more useful distinction would be: - UNSUPPORTED to indicate that the feature isn't supported by GDB or the remote stub. E.g., in this case we'd use it if the GDB port does not support debugging core dumps at all. - UNTESTED to indicate that the feature is supported by GDB but the test wasn't run because it's not possible to run it, or we choose to not run it, in the current test environment, e.g., because of a board limitation. In this case, we skip core tests when the host or target boards are remote, even though the feature is supported by GDB (even with "target remote" and cross debugging, at least on some ports). We use UNTESTED in many places already meaning something like the above (instead of placeholder status), though I'm not aware of rationale written down anywhere. The above is just my intuition, and most of these untested/unsupported calls predate my involvement with GDB. Thanks, Pedro Alves