From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2071.outbound.protection.outlook.com [40.107.20.71]) by sourceware.org (Postfix) with ESMTPS id B03023836645 for ; Thu, 26 May 2022 07:39:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B03023836645 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=L7wv/wUTOS+aW6y+Lji8sd38wtB4WdTsDjSVf70V8qMkIoVxdfCPaUqooI1t4fl+GN5BcPruVxvLzJ8lbvWfmd55HS/W03/mrJtBNo9ixyezQ7VENh/KX2xMbPjUdagyVwbpL9Wri0UTp2HLkEf+80Dpb2bcOBjwBEnaV0HXUoBcQ+wl7z1OxKVZ6knJ8Re9wPLo98e+7kGSy5V0wgyVgr2Ka2nEtgEtKwR9AxFzEGoO+1PZ2OCM+D/utBowcVHLWPSDh3NNuU8heGHTL5kcKtJ1jp4p8aycf9u6Y7F561yajL6GJLcyocpOsyj4iPPiZb2qSvS35UoYXzj3d66g8w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6XUB9RKk5/Em9thwNBlbt7H7SBtj+q16Gbo7NQF9P5Y=; b=RGEbZig0hzGFtcVsxGAjf9LpQMyUSKOyFwBaNfd/5wGZkyXyOF0XfayTDhkaJE8GkPScmMUglNe4brj19cqQXOvt/CN10p63JCv4ulltVt3M+bGBFYpuf2Pj1mGgwKM5rOrneCrJ4kWWfNCsTfgJ7Ei+S0WYTXSlfasdH6Q4KG0zXZh23nryqTspXxhayigsN56EiLzP2q8lwCUzPNbTEwXWaRCVosKX5Ciwfk5QVQqq+xA/RM5VWn5ugGy8ZxKpc4ArZazziK9XOXeFejzveDVMeG8Rwix/iTrqK1z/4vJLuMeefcm6z5uMXnjvzk/tChwTuKP3Bt0t0Vu5MRtUKg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM5PR0101CA0021.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::34) by DBAPR08MB5672.eurprd08.prod.outlook.com (2603:10a6:10:1ad::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Thu, 26 May 2022 07:39:16 +0000 Received: from VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:16:cafe::cc) by AM5PR0101CA0021.outlook.office365.com (2603:10a6:206:16::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 07:39:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT056.mail.protection.outlook.com (10.152.19.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13 via Frontend Transport; Thu, 26 May 2022 07:39:15 +0000 Received: ("Tessian outbound 42cead292588:v119"); Thu, 26 May 2022 07:39:15 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e4937e3181746a81 X-CR-MTA-TID: 64aa7808 Received: from a67b6d9e82ad.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F76E0BDD-0633-47DE-BC75-8A52A6A7ACB8.1; Thu, 26 May 2022 07:39:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a67b6d9e82ad.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 26 May 2022 07:39:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jDvs03EyRNtZ893Qjrx2psjhWiNOpsrLyn05UABBF7rpUjZ/mCoUzIkiaLdy+VBJLijgM/D271iyOSWvJxApCQqi+Se0Rq/KIEWGk+P8dfT1oFhAdw1ZAXjJZJQUL5C7Y4inBJNu6JeWGDrwmos8zExTxxt67Bpkey6Kbzx543bvpcLjLmE5mEMTkcQMhF61klOH4Tg9wyC9YPq22LkNnNYO8nC1krhNZ+sW5WgWVaPXvw+dHaePG4xTKV/cFW/ryX25CJw6zkgC7C3QkxQM/8HFEbBQTwmqz8G5PNXpErn56LW+6cx6hy5sRs0n7dt/tk/GvhKr8oHyYN5z2xOnyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6XUB9RKk5/Em9thwNBlbt7H7SBtj+q16Gbo7NQF9P5Y=; b=NQl9AqA3rEQnv55CJwGbTY7fiBc1vzoGE9nGkMH9N3taSiBh/x1ltrjYlwR9cOdPgPmYynYNkhh5voKap1T88mFDKS+GPHnVF8jTv6AQxkhFIkjNw6izmKdkTJFi50cHmhW1i0CYxhM+h15teBDAdTFz/tixlb9myZ5/RUtk3TABIh3XMxGLQwnyCHoP1zJIurSlpbbOXhTM0FSKWqFTcML5j2mSjpoaA/YgKh+ICBAuAiXsRhwZpZPbj8qQgP7NLO2wSfQGVq7GsmGQx/vyvFHvrYKXKABFaHxqroK06lGYM5tv2pEtSrw7MVjCZLwts2NtPAWBy4UV524GHV80hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DBBPR08MB6172.eurprd08.prod.outlook.com (2603:10a6:10:1f4::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5273.14; Thu, 26 May 2022 07:39:06 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5273.023; Thu, 26 May 2022 07:39:06 +0000 Message-ID: <75ed8a8e-6f30-7f2b-2b86-8477ae9590a4@arm.com> Date: Thu, 26 May 2022 08:39:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] gdb/arm: d0..d15 are 64-bit each, not 32-bit Content-Language: en-US To: Yvan Roux , gdb-patches@sourceware.org Cc: Torbjorn SVENSSON References: <20220525151407.GB11828@gnbcxd0114.gnb.st.com> From: Luis Machado In-Reply-To: <20220525151407.GB11828@gnbcxd0114.gnb.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0359.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::35) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 6c1b510c-32f9-493d-692f-08da3eead5b4 X-MS-TrafficTypeDiagnostic: DBBPR08MB6172:EE_|VE1EUR03FT056:EE_|DBAPR08MB5672:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RPHJuqwSBa7SuOUirDq+w7p2c9/FI1lpDQ5N+sRgYJobgvTsp2LrCUL+spF9E6RiQhArBmnyzb0kWWJh1g8oBKUXNuo9u751xTPGNbe/SxuGKBbfuxlLMTNz2aYjoFBmdI3m0exdhXGPU9+nS3lw81h+N04dexTY9QLWYjeZ8H+FIPVOQRCeMVSag/3p1Q7lu1ybPS1lw3Yk2iJdD8oowWz2eFxESe5CqQRaZDGYDvnSQUqG2L6bijggBxp3+Yu3Zq3vMmF9JrjPZM5Wp8ql2mBW8QY4V6vTmeGmg0DK8oHEi210cSV5ZBTHZDZqAdO4eFg27wCYUpCyEY83jGnBibgPbJJPA+3kfxtSwFN3pSISKxFO4Dsco3TqpYd+pi0EIW1udyt2AcNFlU3XKgawHVWPl1aKkodicu4TawCJUqStUShRed106T3ikGIrkhMGhkePsIkJUUI6zMEiUBX2jL+lhy5b2Vkx2h954/Fu8gWMA6hyMPARIzHpci6/ci7NNWXlEvZWTWgSNSmtQ0GXrguFdns9vQKtW5/iSvN80RIWmlmkZjMivuxYBPYNjffEj6402kaMUJo8oHhCjrWdXfTFAHaTw6B58toqRoq+vJ05o0K/PG6/xWpEw7gStsMYyPf2C3eu1qaG4QxyWeI3pKQAkfkYPgTnMJKWxzn6Fxa4Rpv7Cn1MbtiEElg6UrPvJQR0r4V3mYN8gCuws2FN1MmlZwd/zrpcSVMAFMHYyq5BKx4RwJAcD+LWHj5eAMuNGF/84ECVfp8daU6TKgugIQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6512007)(38100700002)(31686004)(2906002)(26005)(53546011)(31696002)(6506007)(316002)(36756003)(8936002)(4326008)(8676002)(66946007)(66556008)(66476007)(44832011)(186003)(2616005)(86362001)(508600001)(6486002)(83380400001)(5660300002)(101420200003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6172 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cf3e8d47-4dcd-415b-ef6b-08da3eead019 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ptKYWhvt/dZnjp6EEmhs6rc8SkIFezqTF7/mSEL5RhoxOfnj7T7448/yaO475aTwr0SrbJvXpGZmQIfAkCb37qrm/0LBd3j0LtrYPQqcDHpCJO50SZ7bEGN5iJ+KNOBc8wPpyd438TFwtMktk+U3zeWIlNacvjY05ZYFRebvmhZdKx52rhMsNX6u+EpsiZZVbHi9czjDwujxIk0eNtY3coD6/0BiNVHlS62tGd3Py+qIBO6m7W3htk8lvd5CuuyZ4gPJ9+h+vT9cZJgdd4+meeSSpJp1QCO0w9PrzjlCMUGjDR5Zl0aYrhdoSG7W5ocP30mxJg1S+QSpNV9rKpMmHn95Q1x3K3rzO/d6OgG3yt2et5pLWYBsa9fJsOqw1EiK0ZCRfYUhiXlBk7Y9J8fCVmGP5KgIZ9etEWCqqAjS2+2hIqwXfraWEjQxBLuDoFBG1NlbKLmiza96BLZtZzHHhIE4q7hlodf7MuHT3NhMSE6gdfhpokmggnH12/H+PxrI+O6n4lux5IUa0pznHA4sCgR7b+Ewtsy4yvGcQBTQ4L92r8EzlEZNMekouRp1sm5V1J3o8KmdYK6792fTuY3QNtabtENKMNqPuOLT2tHdtIftWcbI7BVF82NWUFihNk+7bPFe/LO9YtBB5hKrOFrsNUT06sDWIIKa2Q3GOr4GJP2xX6iUIqsEmqcq0+LoXtoIPcPrJMyA7DK0INpYle1rKsK8omK6olqQaguTRhENg7X9C5ovEJmqQ3gHs9wyAQe9 X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(46966006)(40470700004)(8676002)(83380400001)(6512007)(70586007)(40460700003)(8936002)(70206006)(5660300002)(4326008)(356005)(36860700001)(508600001)(6486002)(81166007)(6506007)(316002)(36756003)(53546011)(31696002)(186003)(86362001)(82310400005)(2906002)(44832011)(26005)(2616005)(336012)(31686004)(47076005)(101420200003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2022 07:39:15.3892 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c1b510c-32f9-493d-692f-08da3eead5b4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5672 X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 07:39:21 -0000 On 5/25/22 16:14, Yvan Roux wrote: > Hi, > > When unwinding the stack, the floating point registers d0 to d15 > needs to be handled as double words, not words. needs -> need > > Only the first 8 registers has been confirmed fixed with this patch > on a STM32F407-DISC0 board, but the upper 8 registers on Cortex-M33 > should be handled in the same way. > > The test consisted of running a program compiled with float-abi=hard. > In the main function, a function took a double as an argument was function took a double -> function taking a double? > called. After the function call, a hardware timer was used to > trigger an interrupt. > In the debug session, a breakpoint was set in the function called > from main to verify the content of the registers using "info float" > and another breakpoint in the interrupt handler was used to check > the same registers using "info float" on frame 2 (the frame just > before the dummy frame created for the signal handler in gdb). > > Signed-off-by: Torbj�rn SVENSSON > Signed-off-by: Yvan Roux > --- > gdb/arm-tdep.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index 49664093f00..6c0aca274f5 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -3464,10 +3464,10 @@ arm_m_exception_cache (struct frame_info *this_frame) > > /* Extended stack frame type used. */ > fpu_regs_stack_offset = unwound_sp + sp_r0_offset + 0x20; > - for (i = 0; i < 16; i++) > + for (i = 0; i < 8; i++) > { > cache->saved_regs[ARM_D0_REGNUM + i].set_addr (fpu_regs_stack_offset); > - fpu_regs_stack_offset += 4; > + fpu_regs_stack_offset += 8; > } > cache->saved_regs[ARM_FPSCR_REGNUM].set_addr (unwound_sp + sp_r0_offset + 0x60); > fpu_regs_stack_offset += 4; > @@ -3476,10 +3476,10 @@ arm_m_exception_cache (struct frame_info *this_frame) > { > /* Handle floating-point callee saved registers. */ > fpu_regs_stack_offset = 0x90; > - for (i = 16; i < 32; i++) > + for (i = 8; i < 16; i++) > { > cache->saved_regs[ARM_D0_REGNUM + i].set_addr (fpu_regs_stack_offset); > - fpu_regs_stack_offset += 4; > + fpu_regs_stack_offset += 8; > } > > arm_cache_set_active_sp_value (cache, tdep, unwound_sp + sp_r0_offset + 0xD0); Thanks. This is OK with the commit message nits fixed.