From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2082.outbound.protection.outlook.com [40.107.116.82]) by sourceware.org (Postfix) with ESMTPS id 58E653858D35 for ; Tue, 10 Oct 2023 14:43:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 58E653858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f+9QglQOlrOjX1NJDGu0kP0+Y4OfhfK3ahcvk1z6KVzVrDJ/Cp52bohgVEwC+v7wYqePK3jg8eBIYcCOudrM9fYIboZFqD5FbpGUZ8F2SSZc6IIkLvnv0eFRtpSaGuk1xTUQuxaxATB6P4yl7VYdeuyT2q2sLFdPX+FDvuSiSjc7rsYKctSx0HIsRjEfGxnY9R9FJ/JYnD7p1IUO+MGzkeiO3lk8xAcnTZRR2s0V4EMuigyW7y+yKPI7wlq6XOUmIhnAixR4YslKNhT6j3hXnI7tgXxSzMgAOzodyTZmutz8air0eYW+HJ+a/5Bck1p9d3LKrMeepWLFxQfzhgHi8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cugan1lPtkqwj7BvRT9Xfuf4V21zYE0Z5FSDFzS0EX4=; b=j4zl7MbjFIAI+KBuTD5Jc7pj3V+eIOXD95wgx7BucUWzpsZbe5C2+UnwwaXR9gg3Fatt3svzQsAkvwmwkKI0RDJiAf3ONafXoio4HdAHrKEwphx8Im2X18zeCHUWQIsdDOMwm6BAHnU7kRxd43L45nDemGP7WUJUlCyg1gE+zTRrlUsFiOZWDCm7is/3jew2cFq5T9LunsZryr5oHZHReSWjxpAlyeWo7qTws0gfZr3y8vq5NWCt0Rs178rh+NLMQy/zgeYpUSFPYWVEDd/tb7c7n37cW5lNZjuvnxAtSD/XVmjW/3JgxJFrIhTa+G8e0a2NLZNJ90ghDBpTp9iCWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cugan1lPtkqwj7BvRT9Xfuf4V21zYE0Z5FSDFzS0EX4=; b=PyJSzx2mZqW+d4pelstLNOZXTmAvefExQ1jNRc/PWCuj5YiH8ZV+wgMQSzsZTmZZSMEXk4dxS4nwVRZ/cy8coXORq9yCc87ea6UkVrLmLkcym4Zlz1XBLKoeEbyp1TaNrAtv3H8bvK3MoqD1Y25pensneU122ic7ybAczKL82HZZxz67VXVKffebAjl1jyahpqSqXvOiY9O7+EbhGqrjK37RNg2zODB6h3C451ZC8QafD9i9FoEdcLiBcDilq+f+j+dzfTytSNdBNJ2wbg495T/pWLvPXJClp7Knz6hhWn6i4cNfGgNbmSMGb3Rt84v2EFIoW3GP0ccUgB0EID+Rgg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT3PR01MB5509.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:61::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.42; Tue, 10 Oct 2023 14:43:08 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a%6]) with mapi id 15.20.6863.032; Tue, 10 Oct 2023 14:43:08 +0000 Message-ID: <75ee7957-e049-4105-940d-3b8d4c334f4d@efficios.com> Date: Tue, 10 Oct 2023 10:43:06 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] Various inferior / arch cleanups To: John Baldwin , gdb-patches@sourceware.org References: <20230929182541.138320-1-simon.marchi@efficios.com> <0b4cad10-dc87-6645-e397-18f26c9f04dc@FreeBSD.org> Content-Language: fr From: Simon Marchi In-Reply-To: <0b4cad10-dc87-6645-e397-18f26c9f04dc@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQXPR0101CA0025.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:15::38) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT3PR01MB5509:EE_ X-MS-Office365-Filtering-Correlation-Id: e8268253-59f7-4c0e-864b-08dbc99f37f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aLg5l9RYKHSCwM7jx0f5aP8yEGeB9R1CuMFxuEAbSv1UaWUoMRRByywrXxUrxg/40BPhP6GW2rA4Xwcs8hMYlG/IZ8JAwkQPcoSMBesvCUpY9sDqPG0upnxc6k/jgVfr81VGWeFCAwaEAiK15BPQUjyD8RShThi7/ZuzwrFyUhA2WTE7YWGQbhuezm9tzdZcgQJHWD0W7J6snvptl2gJcIjQHuu1YBnvh0eCSbFOPPw+igUo0R/CUipCiVwZ7hmlhi7YmTQQFyxFXRuHn2ZneZvHnltCKq4/FgOAWkTXXbWTKjUuezKP+HG/iIIvEODNnmzsE7dHIUhZIQG4apfcRWmARsGBge72jM8747kSlPEe2o02lR/rLIDlLGY8gxGfqzbXCOJhGiax1tYu3DS7ut3K6LiF0J6bM5eIG94eh2hdrT3i/XGOBaj8AocxowpILwYQtcfLynPD7M7JSf1FrJrfzXlg6B+wV9GTjxbwRGQlgXUujM5cGx2Jkjga+NTCY7JvFeW06B149bslznK5NABdZRmOGY2dxF27rnHBfrpy57wgXdPkIFWH2DYXJMdYo6ycF7G+VqX/LgaiXFvtUFwJbz/zaKIcrhe/Hg1HBO+1JCJQZvvvQnoCFBt48gwqXt7HFvqk7g7tdr0jZt6lRw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39830400003)(346002)(376002)(396003)(366004)(136003)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(6512007)(53546011)(6506007)(2616005)(478600001)(6486002)(26005)(83380400001)(2906002)(5660300002)(66556008)(316002)(66476007)(66946007)(8676002)(8936002)(44832011)(41300700001)(36756003)(31696002)(38100700002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEVsc2JaT2wwZ3Y3aTF0dlFoRnp6VHVaUmF4aDVYam9VU2RMRjZnejNCclNY?= =?utf-8?B?Nys4Tmh5N0tXTDVaRWxQWG1mRVhERURSUnFraTFNNmNmekV3QVFUY1haaDAz?= =?utf-8?B?RHg0QTBpNDMvaUdITzY5M0dETTNBS3M2UkVpUUR2ZUZFT0tITW1NeHc1dmVT?= =?utf-8?B?K2c5WGoybkp0SG8rcjV2cjZEYkpOOG5QMWRNYlRVRk9DQ1h0SEJWREFwdXhm?= =?utf-8?B?MHBmaUFRSEFPYXdkMkpFV3kwejBDdDJNSDYzNlc4K0xqTW5xZjhHNENKc1NZ?= =?utf-8?B?aUsrcENOWHZ2TlJ1bXN2bjJmWkZWSUxlNVdmMUJ4dndiNXdsbDlKSjlmS3V2?= =?utf-8?B?OE8wUHFrcGhYSWl2Ky9SRUlrUEVzYWU5eEdUOE9VM1NiVitDaGRYVVdXd2E4?= =?utf-8?B?WVYralRzeXRINGVJbkpaYUgrZnJ4dFBrMXNwQmRLYnpZTldSZmtUOVU4NzI0?= =?utf-8?B?VXQ2TkhMdHNrQXRUU2J3azRZTUNwWnVKRlF5VzZDcEIweXhiSU1NTEN2K3lS?= =?utf-8?B?WndRUFllNitYZS9zc1VvdjRKUGRWckhsajEzL0lqZkJGMHAwZmpzV3BJVTZV?= =?utf-8?B?MFRqZHpTb3NLSlBTZzFhcVJudWJiTTJWaVNQTVQ0eUU3VkdWQ1BUZjU3c0lv?= =?utf-8?B?VHEzVS81SDU5d0M5VERNY2ROeW9ZL1o3Y3JISzdsQ1NMNkozeHJhbGMwdVF2?= =?utf-8?B?OWxDVmI5a1Jzd1Y4NkF5ZGJsekVKdjFucFVyOXgyR2sxaFVhOU1WM3BtSmd0?= =?utf-8?B?WDY0bVMzek05SFZnNUE3cnFqbFY5VUZ5Y1JMbXRFSFppSDQrdEFvREIzM1A5?= =?utf-8?B?Q2NOd2ZHS3hEbTBXL3ExMTJJRjdBeWpVZGQwV1ZpRGowOVJld2g1czNEVWhs?= =?utf-8?B?a2tLdkNuM0JjYk5ZMGdFbmM0djBlL3VmZ0tJQjZMZmVEb1M3ZVNJWVRUSzlR?= =?utf-8?B?ck9lSlhuSXIreWpJT3hKSHFNV3B0VzlMKzFUZ2xkaWZPTUdNVE9OMXZZMW5C?= =?utf-8?B?WE13a3BsUFJGV21SYjgrbzdtSUt2OUw2WHFYekc5MTd0MTRYSS83eXlqaWQw?= =?utf-8?B?YVJnL1crY0toRi9nM1dUQkhadVFBUEhFbTF4cWZjaVVUcDZEYWk2YWh6QkVV?= =?utf-8?B?TzRyaW1saDRzMjR5STVycTlPMlRZMEpGUXoxeTM3Vzk1SU5RZEExQzVDSERx?= =?utf-8?B?SUNxdlkwMi9vTlVUYzJnWHV0V0FaaWtod0lWVzNNYWNVR3NObXlrRDRLQi95?= =?utf-8?B?Wkw5TTZUcWVacnhhQzFOdzRFY003TnJLZXJVNy9VTkd4aGNOVFRTaUlUMHJr?= =?utf-8?B?clRSZ3pYb0xXSm9Pbm1zcjZENjY0bm8wUnlUTWZlNG1mTVdLdGN6VTBhNGVw?= =?utf-8?B?NUdlTFIvQVh3Mk5WVUtzVVdITzY1MHdQUDNhWVg3ckhiUFFSMU5JdEw5aW1i?= =?utf-8?B?Vks3dFY5M2JyNW42aW1peEtCYnNQZDF1OTcwS1NnaFRHQy85Ui84ZEc5YnZm?= =?utf-8?B?VHY0bmpDMWFxZlJUSWZ2NjhIM0pHYzFGcnlzMUc5UEQ5Wk01SkIyMjhJRFRY?= =?utf-8?B?WEFYSGxGM3FVTTdmNjhMYjRwV0RTVndGNWNmWm01b3ZUU2dDUWtac3hEWUVB?= =?utf-8?B?Ymx0eEIrRzRqMUF6aFlBWjlWLzRRbEFyV0gwZlI4TWRzRTBSNUp3SXdYMER2?= =?utf-8?B?NlFaV2dQendzeDROWTU4M3Y4ZCtEMnNSMndPbzI0ZDU3dFlxSGs3Tis2dDBm?= =?utf-8?B?N0R5WnBFRnZkQUFtU0p1MHc2aXV2SzlPazEzTnNlWWNRNVgzQ040NUFyM2da?= =?utf-8?B?ZkFPemRTZDVDS3NTbHRmazJJT1VYMFFUaEZnOG9YRXlITlZmdWxXQzd4ZW1V?= =?utf-8?B?emhvQWxhQk9qUEpaQ0QxSDk4bmFTMWt6YlR1VS9XeVZjT01XY3pIaEhTeUJ0?= =?utf-8?B?dk51ck0xVVEwalo3NEtZREY3Y091SUc4M2ZxcHI0VGhoOU8xUUNsQS9XeUsy?= =?utf-8?B?azhHUDExVmtvamRxcXlEaElkdnJaVTJ1eFlRei9ZT3FjQ0VNaW4zMitmVTFi?= =?utf-8?B?alJsZVAyZjRMYkhXdk42bjRSaVhyWXNhMkVFQTVIcjd4UHVJWXpLS28xemNI?= =?utf-8?Q?8uDD+MlScv09ffEAbNL0/tSvp?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8268253-59f7-4c0e-864b-08dbc99f37f2 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 14:43:08.1343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9nwuNaKK0ZDkXDh6jxwGuKfdaBI8wQML/dKZPq7ioGdE5eFpeRqyJl8o15zwke0YwZqFVUm4tuZ5DfGLTr4asw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB5509 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/6/23 18:05, John Baldwin wrote: > On 9/29/23 2:24 PM, Simon Marchi via Gdb-patches wrote: >> I'm in the middle of a bigger change, moving things around, and >> extracted these patches which make sense on their own, I think. No >> changes in behavior expected. >> >> Simon Marchi (5): >> gdb: add inferior::{arch, set_arch} >> gdb: add inferior parameter to architecture_changed observable >> gdb: move set_target_gdbarch to inferior::set_arch >> gdb: remove target_gdbarch >> gdb: scope down registers_changed call in inferior::set_arch >> >> gdb/aarch64-linux-nat.c | 14 ++-- >> gdb/ada-lang.c | 7 +- >> gdb/ada-tasks.c | 9 +-- >> gdb/aix-thread.c | 5 +- >> gdb/amd-dbgapi-target.c | 4 +- >> gdb/amd64-linux-nat.c | 2 +- >> gdb/arc-tdep.c | 5 +- >> gdb/arch-utils.c | 31 +++------ >> gdb/arm-fbsd-tdep.c | 2 +- >> gdb/arm-tdep.c | 15 ++-- >> gdb/auxv.c | 21 +++--- >> gdb/break-catch-syscall.c | 2 +- >> gdb/breakpoint.c | 16 ++--- >> gdb/bsd-uthread.c | 15 ++-- >> gdb/btrace.c | 3 +- >> gdb/cli/cli-dump.c | 5 +- >> gdb/compile/compile-c-symbols.c | 12 ++-- >> gdb/compile/compile-cplus-symbols.c | 12 ++-- >> gdb/compile/compile-object-load.c | 52 +++++++------- >> gdb/corefile.c | 3 +- >> gdb/corelow.c | 2 +- >> gdb/cp-namespace.c | 3 +- >> gdb/cp-support.c | 3 +- >> gdb/d-namespace.c | 3 +- >> gdb/darwin-nat-info.c | 12 ++-- >> gdb/dcache.c | 6 +- >> gdb/disasm.c | 11 +-- >> gdb/elfread.c | 4 +- >> gdb/fbsd-nat.c | 2 +- >> gdb/filesystem.c | 3 +- >> gdb/frame-unwind.c | 3 +- >> gdb/gcore-elf.c | 2 +- >> gdb/gcore.c | 49 ++++++------- >> gdb/gdbarch.h | 24 +------ >> gdb/gnu-nat.c | 6 +- >> gdb/i386-darwin-nat.c | 8 +-- >> gdb/i386-tdep.c | 6 +- >> gdb/ia64-vms-tdep.c | 2 +- >> gdb/infcmd.c | 8 +-- >> gdb/inferior.c | 19 ++++- >> gdb/inferior.h | 33 +++++---- >> gdb/infrun.c | 19 ++--- >> gdb/jit.c | 5 +- >> gdb/linux-nat.c | 10 +-- >> gdb/linux-tdep.c | 6 +- >> gdb/memattr.c | 9 +-- >> gdb/mep-tdep.c | 4 +- >> gdb/mi/mi-interp.c | 8 +-- >> gdb/mi/mi-main.c | 2 +- >> gdb/microblaze-tdep.c | 2 +- >> gdb/mips-linux-nat.c | 6 +- >> gdb/mips-linux-tdep.c | 5 +- >> gdb/mips-tdep.c | 15 ++-- >> gdb/moxie-tdep.c | 4 +- >> gdb/msp430-tdep.c | 3 +- >> gdb/netbsd-nat.c | 2 +- >> gdb/nto-procfs.c | 5 +- >> gdb/nto-tdep.c | 29 ++++---- >> gdb/observable.h | 5 +- >> gdb/ppc-linux-nat.c | 2 +- >> gdb/ppc-linux-tdep.c | 2 +- >> gdb/printcmd.c | 66 +++++++++--------- >> gdb/proc-service.c | 2 +- >> gdb/process-stratum-target.c | 2 +- >> gdb/process-stratum-target.h | 3 +- >> gdb/procfs.c | 24 ++++--- >> gdb/progspace.c | 10 +-- >> gdb/python/py-finishbreakpoint.c | 2 +- >> gdb/python/py-inferior.c | 16 ++--- >> gdb/python/py-objfile.c | 5 +- >> gdb/python/py-progspace.c | 5 +- >> gdb/python/py-record-btrace.c | 2 +- >> gdb/python/py-unwind.c | 2 +- >> gdb/python/python.c | 4 +- >> gdb/ravenscar-thread.c | 7 +- >> gdb/record-btrace.c | 2 +- >> gdb/record-full.c | 19 +++-- >> gdb/regcache-dump.c | 6 +- >> gdb/regcache.c | 8 +-- >> gdb/remote-sim.c | 2 +- >> gdb/remote.c | 73 +++++++++++--------- >> gdb/rl78-tdep.c | 6 +- >> gdb/rs6000-aix-nat.c | 5 +- >> gdb/rs6000-tdep.c | 2 +- >> gdb/rust-parse.c | 5 +- >> gdb/rx-tdep.c | 5 +- >> gdb/s390-linux-nat.c | 2 +- >> gdb/scoped-mock-context.h | 2 +- >> gdb/sol-thread.c | 13 ++-- >> gdb/solib-darwin.c | 30 ++++---- >> gdb/solib-dsbt.c | 26 +++---- >> gdb/solib-frv.c | 19 ++--- >> gdb/solib-rocm.c | 2 +- >> gdb/solib-svr4.c | 88 ++++++++++++++---------- >> gdb/solib.c | 37 +++++----- >> gdb/sparc64-tdep.c | 14 ++-- >> gdb/symfile-mem.c | 4 +- >> gdb/symfile.c | 11 +-- >> gdb/symtab.c | 6 +- >> gdb/target-descriptions.c | 4 +- >> gdb/target.c | 33 +++++---- >> gdb/target.h | 2 +- >> gdb/tracefile-tfile.c | 25 ++++--- >> gdb/tracefile.c | 3 +- >> gdb/tracepoint.c | 31 ++++----- >> gdb/tui/tui-disasm.c | 2 +- >> gdb/unittests/frame_info_ptr-selftests.c | 2 +- >> gdb/value.c | 4 +- >> gdb/windows-nat.c | 2 +- >> gdb/windows-tdep.c | 10 +-- >> gdb/z80-tdep.c | 2 +- >> 111 files changed, 667 insertions(+), 577 deletions(-) >> >> >> base-commit: 4ebfd53de03599b73838ee339e47652ac26c37c0 > > I only skimmed these, but these seem ok to me in principle. Thanks, will add your Reviewed-By. I don't think we have a tag for "I gave it a quick look and I think it makes sense, I thought that's what Acked-By was for, but the definition we're about to put in MAINTAINERS is different, so I'll stick with Reviewed-By even if it's not a thorough review. Simon