From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id D4012388A824 for ; Mon, 25 May 2020 15:14:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D4012388A824 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1A8921E5F9; Mon, 25 May 2020 11:14:16 -0400 (EDT) Subject: Re: [PATCH v4 8/9] gdb/testsuite: support passing inferior arguments with native-gdbserver board To: Tom de Vries , Michael Weghorn , gdb-patches@sourceware.org Cc: Simon Marchi References: <20200429111638.1327262-1-m.weghorn@posteo.de> <20200513094758.523845-1-m.weghorn@posteo.de> <20200513094758.523845-8-m.weghorn@posteo.de> <55eba66f-4c1c-def8-3ea8-894a29fbe66c@simark.ca> <6970f13d-8044-f4bd-ba2b-b43b3467272b@simark.ca> From: Simon Marchi Message-ID: <75fd89b3-dfb1-a40d-e4f9-fb6d1b2f5554@simark.ca> Date: Mon, 25 May 2020 11:14:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2020 15:14:18 -0000 On 2020-05-19 2:46 p.m., Tom de Vries wrote: > On 19-05-2020 19:22, Simon Marchi wrote: >> So I'd keep "inferior_args", >> although we can make it accept a list instead of a string, and apply the >> treatment you have shown above. >> >> Or, I like the procedures that accept optional arguments using shell-like switches, >> so we could do: >> >> set inferior_args [list a b c] >> gdb_run_cmd -inferior-args $inferior_args >> >> This is untested, I always forget how tcl converts between strings and lists >> exactly, but you should see the point. That makes it easier to add other parameters >> in the future. > > Yep, sounds good to me. I think I'll do that, but as a separate change. So I'll merge the series as-is, to get the fix and test in, and then look into adding the `-inferior-args` option to gdb_run_cmd and friends. Simon