Re: [PATCH 07/23] Documentation for memory tagging remote packets

[Luis Machado <luis.machado@linaro.org>]

Thanks for reviewing this Eli.

On 7/17/20 2:54 AM, Eli Zaretskii wrote:
>> Date: Wed, 15 Jul 2020 16:44:57 -0300
>> From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
>> Cc: catalin.marinas@arm.com, david.spickett@linaro.org
>>
>> +If the number of memory tags, @var{N}, is greater than or equal to the number
>> +of memory tag granules, @var{G}, only @var{G} tags will be stored.
>> +
>> +If @var{N} is less than @var{G}, the behavior is that of a fill operation,
>> +and the tag bytes will be used as a pattern that will get repeated until
>> +@var{G} tags are stored.
> 
> The symbols inside @var should be lower-case, per our conventions.
> They look better in the printed manual that way.

I've made them lower case and updated their names to nt and ng. I also 
updated another offender in the packet description (@var{mXX}).

> 
>> +For AArch64 GNU/Linux systems, this feature also requires access to the smaps
>> +file in the proc filesystem so memory mapping page flags can be inspected.
> 
> "proc" should have the @file markup (and should probably be "/proc"?).
> 
> The patch is OK with those nits fixed.
> 
> Thanks.
> 

I rephrased it to read "...access to the @file{/proc/@var{pid}/smaps} 
file...".

Thanks!