From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id BB90B3858C54 for ; Tue, 9 Aug 2022 07:56:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB90B3858C54 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 621AC1FE15; Tue, 9 Aug 2022 07:56:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4D83C13AA1; Tue, 9 Aug 2022 07:56:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Ne+8ET0T8mIHBgAAMHmgww (envelope-from ); Tue, 09 Aug 2022 07:56:45 +0000 Message-ID: <762dd14c-01a5-79e8-6ec7-aae38b8813eb@suse.de> Date: Tue, 9 Aug 2022 09:56:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] gdb/csky support .reg2 for kernel 4.x and later Content-Language: en-US To: jiangshuai_li , gdb-patches References: <59e8ee98-af6f-4254-befe-de11cbd0e69c.jiangshuai_li@linux.alibaba.com> From: Tom de Vries In-Reply-To: <59e8ee98-af6f-4254-befe-de11cbd0e69c.jiangshuai_li@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Aug 2022 07:56:48 -0000 On 8/9/22 04:29, jiangshuai_li wrote: > >On 8/1/22 04:40, Jiangshuai Li via Gdb-patches wrote: > >> +      warning (_("Unknow size %ld of section .reg2, can not get value" > >> +                 " of float registers."), len); > > > >This broke the build on the gdb-armhf-ubuntu20_04 builder ( see > >https://builder.sourceware.org/buildbot/#/builders/170/builds/246 ): > >... > >../../binutils-gdb/gdb/csky-linux-tdep.c: In function ‘void > >csky_supply_fregset(const regset*, regcache*, int, const void*, size_t)’: > >../../binutils-gdb/gdb/csky-linux-tdep.c:194:18: error: format ‘%ld’ > >expects argument of type ‘long int’, but argument 2 has type ‘size_t’ > >{aka ‘unsigned int’} [-Werror=format=] >  >  194 |       warning (_("Unknow size %ld of section .reg2, can not get > >value" > >       | > >^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >   195 |    " of float registers."), len); > >... > > > >There are uses of %z in gdb, but very few, so I suppose the way to fix > >this is to use %s and pulongest. > > Thanks, i have used your suggestion to fix it, a patch has been committed. > Thanks for fixing it, and I see the gdb-armhf-ubuntu20_04 builder is back to green status, yay ! Thanks, - Tom