From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58025 invoked by alias); 24 Jun 2019 14:23:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58014 invoked by uid 89); 24 Jun 2019 14:23:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=resist, nearly, managed X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Jun 2019 14:23:21 +0000 Received: by mail-wr1-f68.google.com with SMTP id x4so14126724wrt.6 for ; Mon, 24 Jun 2019 07:23:21 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id m9sm12730628wrr.14.2019.06.24.07.23.18 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2019 07:23:19 -0700 (PDT) Subject: Re: [PATCH 00/66] Clean up the TUI To: Tom Tromey , gdb-patches@sourceware.org References: <20190623224329.16060-1-tom@tromey.com> From: Pedro Alves Message-ID: <763ce433-bac5-6df0-d186-b4b441d6a441@redhat.com> Date: Mon, 24 Jun 2019 14:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190623224329.16060-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-06/txt/msg00531.txt.bz2 On 6/23/19 11:42 PM, Tom Tromey wrote: > On the other hand, working on the TUI changed my mind about the TUI > generally. I've become a fan. I think it would be good to improve > the TUI for users, but to do that I think we first have to improve its > code. Ahah, welcome on board. :-) > > This series is a start at this. It's already quite long, > unfortunately, and yet is still incomplete. Still, I think it is > progress. This series: > > * Splits tui_win_info into subclasses, one per window type. > > * Adds virtual methods, particularly in an attempt to remove all the > code that switches based on the type of the window. This is > important to make it simpler to add new window types. > > * Changes tui_gen_win_info into a real base class for tui_win_info. > > * Removes the uses of unions from the window class hierarchy. > > * Simplifies and C++-ifies various other minor things along the way. > Hurray! As I think you know, I attempted something like this over 7 years ago, but doing it in C wasn't nearly as nice and I just gave up. Being a TUI user myself, I was so happy to see this series that I couldn't resist and started reading it straight away. Thanks so much for working on this. Looks like only patches up to #49 made it to the list (and I haven't received a copy of the missing ones either). Anyway, I skimmed patches #1-#49, and I sent a few responses for some very minor things, but overall all of it seems good to me. Looking forward to see this merged. > I tested this by trying the various TUI features by hand. However, > I'm not sure I managed to test them all. If you have this on a branch, I volunteer to test a bit. Thanks, Pedro Alves