From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 6C81B3840C34 for ; Sun, 14 Jun 2020 18:09:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6C81B3840C34 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C649C1E111; Sun, 14 Jun 2020 14:09:47 -0400 (EDT) Subject: Re: [PATCH 3/3] gdb/testsuite: fix minor things in jit tests To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <5260086312a9ec7d276a432ca88126924e0f2b5d.1590397723.git.tankut.baris.aktemur@intel.com> From: Simon Marchi Message-ID: <763ff5ab-8f7e-b8db-75ef-e363109a0887@simark.ca> Date: Sun, 14 Jun 2020 14:09:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <5260086312a9ec7d276a432ca88126924e0f2b5d.1590397723.git.tankut.baris.aktemur@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2020 18:09:49 -0000 On 2020-05-25 5:38 a.m., Tankut Baris Aktemur via Gdb-patches wrote: > gdb/testsuite/ChangeLog: > 2020-05-25 Tankut Baris Aktemur > > * gdb.base/jit-elf-so.exp: Refer to the global main_loader_basename > variable. > * gdb.base/jit-reader-simple.exp: Fix typo ("Built" -> "Build"), > and use the already-defined 'options' variable. > --- > gdb/testsuite/gdb.base/jit-elf-so.exp | 2 +- > gdb/testsuite/gdb.base/jit-reader-simple.exp | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/jit-elf-so.exp b/gdb/testsuite/gdb.base/jit-elf-so.exp > index 51c1d33ff9b..091fe5df812 100644 > --- a/gdb/testsuite/gdb.base/jit-elf-so.exp > +++ b/gdb/testsuite/gdb.base/jit-elf-so.exp > @@ -50,7 +50,7 @@ set jit_solib_srcfile ${srcdir}/${subdir}/${jit_solib_basename}.c > # On success, return 0. > # On failure, return -1. > proc compile_jit_dlmain {options} { > - global main_loader_srcfile main_loader_binfile > + global main_loader_srcfile main_loader_binfile main_loader_basename > set options [concat $options debug] > > if { [gdb_compile ${main_loader_srcfile} ${main_loader_binfile} \ > diff --git a/gdb/testsuite/gdb.base/jit-reader-simple.exp b/gdb/testsuite/gdb.base/jit-reader-simple.exp > index 930c59c0124..d8a54a37ce7 100644 > --- a/gdb/testsuite/gdb.base/jit-reader-simple.exp > +++ b/gdb/testsuite/gdb.base/jit-reader-simple.exp > @@ -77,12 +77,12 @@ if {[build_shared_jit] == -1} { > return > } > > -# Built the program that loads the JIT library. > +# Build the program that loads the JIT library. > set srcfile_dl $testfile-dl.c > set binfile_dl $binfile-dl > set options [list debug shlib=${binfile_lib}] > if {[gdb_compile ${srcdir}/${subdir}/${srcfile_dl} $binfile_dl executable \ > - [list debug shlib=$binfile_lib]] == -1 } { > + $options] == -1 } { > untested "failed to compile" > return -1 > } > -- > 2.17.1 > This LGTM, and it seems it could be pushed on its own? Simon