From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 8CF403858C55 for ; Thu, 29 Sep 2022 21:31:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8CF403858C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4Mdml22l5Wz3c8b; Thu, 29 Sep 2022 21:31:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Mdml21wx2z3LBF; Thu, 29 Sep 2022 21:31:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664487086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A2OVmDQf2f7wWSzRKQfeQVYEPqUPtFZwRftYRkfDzlg=; b=rGXGhhn7CngJGr8gSOqWed4QMemiZnWFYe7SAVGsAaTCyLnogrVvl8+YEXF/+sfH4EkZsM W9Uqj8Y7lxJ2PnG64Ku0qfYoOZ+1Q7TaR07fHoFm/k12sKl+GQOQ4gH359KjZB7Vqyb5fQ aY9MbesU2Y/kGclhxgLb28PKEAH9S0cupSkeGaca8VAvc2bTgWFV+aPN1Ib3M/M5cAyN9S EZ7oDSf0wMiDb1rYd2TFotAYF6UoZObYxPz58TKsdkfx6W/Fodj0mqSFZ+1T6rM66kN7AL N4FAU0iHj0UHeOPuJsJ7TiwQ+4Z32quiGIFnb9xCeSqPjlUEpzOYqqvOsxJimQ== Received: from [IPV6:2601:648:8600:ddb0:7860:627c:ae67:72f5] (unknown [IPv6:2601:648:8600:ddb0:7860:627c:ae67:72f5]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Mdml16Cx5zyyB; Thu, 29 Sep 2022 21:31:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <7670d26b-51de-ccc7-742d-096599759e07@FreeBSD.org> Date: Thu, 29 Sep 2022 14:31:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH 0/3] Small cleanups in auxv.c Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20220929204354.751741-1-simon.marchi@polymtl.ca> From: John Baldwin In-Reply-To: <20220929204354.751741-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1664487086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A2OVmDQf2f7wWSzRKQfeQVYEPqUPtFZwRftYRkfDzlg=; b=jIalZZN6zd3r9Lqkr7LYfYX2CL1W8SkzzDPHN5xwz82eeDKI2rpgfUWGAcw8O3BbcLwyNh URQnGwmVC1O0btvnvUUjZ1AWrlLyT56UOcsxeughGuD3u6+eirlgth/BxcC8+W5fbjd4Ak mabqhfl9L6o3nE4d+qbK3e8hyAcXb70rcGABJDk9hyb9ahymBc9GwE6ODk80kiSMmTp8lU Kg6jFnbLHSVPtifzMs1uofEAFvOMENVLCcY4mk1LPhTyxy127PMvLpETPmV+5/OQU5GQxf tVCO08XRaMTebrss6ITGVPnWz0bpbHaZL6cWBbfZuog0QBd2WZ5G6gcNgkggeQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1664487086; a=rsa-sha256; cv=none; b=lfZVKWr4+/pcRqRePsLdggMWJqcjmaYjJBMpDMDYAvBZ+eI+LovrkbjHMiyoaedP8SAvnW vblCfeZ7PzlmJGgtXJtEAkOST/IcT+8ZnlPMitaTBVAtE+clD+rCXplVm1fvaq1anGwf7N lzdznAIWcDeZZXBrbLRv81os6BDNvc+KwXm8tCYy9/qWId5flDa96d+ylcvB1wJSQ0oot5 lr9dViNuxNzzlXgQFK58STJHYLeA6JaTy/jzX1ZimbSCGpgIyiqlEqRYGl8Kpp5ToZ7Umq 3IzFzewJ8vSSqDcSVAu5QksdtwAwiKAgqaw8cH90sptiEcKjJMbx2mL1PJliFQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2022 21:31:30 -0000 On 9/29/22 1:43 PM, Simon Marchi via Gdb-patches wrote: > I'm currently reviewing an auxv-related patch, and found these little > cleanups could be done. > > Simon Marchi (3): > gdb: constify auxv parse functions > gdb: make fprint_target_auxv static > gdb: make target_auxv_parse static and rename > > gdb/auxv.c | 38 +++++++++++++++++++++----------------- > gdb/auxv.h | 18 ++++-------------- > gdb/gdbarch-components.py | 4 ++-- > gdb/gdbarch-gen.h | 4 ++-- > gdb/gdbarch.c | 2 +- > gdb/ppc-linux-nat.c | 10 +++++----- > gdb/s390-linux-nat.c | 10 +++++----- > gdb/target-debug.h | 2 +- > gdb/target-delegates.c | 14 +++++++------- > gdb/target.h | 4 ++-- > 10 files changed, 50 insertions(+), 56 deletions(-) > > > base-commit: 31282a849107d95d3cfe115ba160f976dd99844c These all look fine to me. -- John Baldwin