GDB 11.1 release prep update (2021-07-11)

GDB 11.1 release prep update (2021-07-11)

[Joel Brobecker]

Hi everyone,

Here is a quick status of where we are today, in terms of the GDB 11.1
release.

We branched last week (hurray!), and so far, we haven't received news
of any major issues. So we're left with the issues listed below,
with some being absolutely blocking, and others being a bit less so.

For those who have the time and expertise, it would be awesome if
we could prioritize those issues.

Thank you!

---

Added Since the Last Update:
----------------------------

* [SimonM] <PR gdb/28056>
  linux-tdep.c:2550: internal-error: displaced_step_prepare_status linux_displaced_step_prepare on s390x-linux-gnu

        Looks like Simon fixed it, but PR still open. I am guessing
        that was just an oopsie. Wrote Simon to double-check.

Other Ongoing Items:
--------------------

  * [LuisM] <PR corefiles/27909>
    AArch64 MTE fixes and corefile support
    https://sourceware.org/bugzilla/show_bug.cgi?id=27909

      Status 2021-07-11:
        - 2 patches already approved
        - 1 patch under discussion -- looks like good progress between
          Pedro and Luis:
          https://sourceware.org/pipermail/gdb-patches/2021-July/180747.html
        - 1 patch waiting for review on non-AArch64 part:
          https://sourceware.org/pipermail/gdb-patches/2021-July/180537.html

  * [HannesD] some Python-suport changes for the TUI interface

       I'm getting concerned about this one, as there does not seem
       to have been a review on those patches since they were posted
       early June. There was a ping sent on June 29th.

    [PATCHv2 1/2] Implement locals TUI window
    https://sourceware.org/pipermail/gdb-patches/2021-June/179539.html
    (I think this patch should provide more information in the commit
    message about what its goal is)

    [PATCHv2 2/2] Use method children instead of to_string in pretty printers
    https://sourceware.org/pipermail/gdb-patches/2021-June/179540.html
    (same suggestion)

  * [TomDV/Simon] <PR gdb/28004>
    DW_AT_ranges with form DW_FORM_sec_offset problem
    https://sourceware.org/bugzilla/show_bug.cgi?id=28004

    Not a blocker for branching, but should be fixed before the release.


Not Critical, but Requested:
----------------------------

  * [SimonM as reviewer] <PR gdb/24069>
    gdb on OSX Mojave hangs in darwin_decode_message
    https://sourceware.org/bugzilla/show_bug.cgi?id=24069

        I know that the state of GDB on MacOS is very poor at the moment,
        and so having this PR fixed for 11.1 would be very nice. I don't
        think this PR should block the release, though. This is not new,
        and I'm not sure whether we can expect for us to converge without
        too much delay. There are good signs, though, with regular
        activity on the PR, lately. So let's see how it goes...

  * [BerndE] Improve debugging of optimized code
    https://sourceware.org/pipermail/gdb-patches/2021-January/175617.html

    (2021-05-31) v2 posted at:
      [0/4] https://sourceware.org/pipermail/gdb-patches/2021-May/179367.html
      [1/4] https://sourceware.org/pipermail/gdb-patches/2021-May/179368.html
      [2/4] https://sourceware.org/pipermail/gdb-patches/2021-May/179370.html
      [3/4] https://sourceware.org/pipermail/gdb-patches/2021-May/179369.html

  * [Sergey with Simon as reviewer] <PR tdep/26633>
    Add Z80 CPU support
    https://sourceware.org/bugzilla/show_bug.cgi?id=26633

    Patch submitted at:
    https://sourceware.org/pipermail/gdb-patches/2020-September/172083.html

    (May 24th) High-level pre-review done at:
    https://sourceware.org/pipermail/gdb-patches/2021-May/179191.html

    No movement since then. Not blocking for branching since it would
    be safe to backport after branching. Not blocking for release either.

  * [Simon] <PR gdb/26868>
    Follow-up on x86-64 stub submission
    https://sourceware.org/bugzilla/show_bug.cgi?id=26868

    This is the submission in question:
    https://sourceware.org/pipermail/gdb-patches/2020-November/173182.html

    For me, although I am not a lawyer, I don't think we can accept
    the contribution without the author signing a copyright assignment
    form.

  * [PhilippeW] Fix/complete option list/description in manual and in gdb --help

    RFA v2 (2021-06-20):
        [RFAV2] Fix/complete option list/description in manual and in gdb --help.
        https://sourceware.org/pipermail/gdb-patches/2021-June/180186.html


-- 
Joel

Re: GDB 11.1 release prep update (2021-07-11)

[Jonah Graham]

On Sun, 11 Jul 2021 at 10:44, Joel Brobecker <brobecker@adacore.com> wrote:

> Hi everyone,
>
> Here is a quick status of where we are today, in terms of the GDB 11.1
> release.
>
> We branched last week (hurray!), and so far, we haven't received news
> of any major issues. So we're left with the issues listed below,
> with some being absolutely blocking, and others being a bit less so.
>
> For those who have the time and expertise, it would be awesome if
> we could prioritize those issues.
>
>
Hi Joel,

I have an issue and will raise a bug (regression compared to 10.2) as soon
as possible with a reproducer. In the meantime, the summary looks like
doing an MI "-exec-interrupt --thread-group i1" causes an assertion failure:

~"/scratch/gdb/binutils-gdb/gdb/target.c:3768: internal-error: void
target_stop(ptid_t): Assertion `!proc_target->commit_resumed_state'
failed.\nA problem internal to GDB has been detected,\nfurther debugging
may prove unreliable."

I hit this when using Eclipse CDT on x86_64 linux.

If someone recognizes this as a duplicate, please let me know.

Jonah

Re: GDB 11.1 release prep update (2021-07-11)

[Jonah Graham]

On Sun, 11 Jul 2021 at 13:04, Jonah Graham <jonah@kichwacoders.com> wrote:

>
> On Sun, 11 Jul 2021 at 10:44, Joel Brobecker <brobecker@adacore.com>
> wrote:
>
>> Hi everyone,
>>
>> Here is a quick status of where we are today, in terms of the GDB 11.1
>> release.
>>
>> We branched last week (hurray!), and so far, we haven't received news
>> of any major issues. So we're left with the issues listed below,
>> with some being absolutely blocking, and others being a bit less so.
>>
>> For those who have the time and expertise, it would be awesome if
>> we could prioritize those issues.
>>
>>
> Hi Joel,
>
> I have an issue and will raise a bug (regression compared to 10.2) as soon
> as possible with a reproducer. In the meantime, the summary looks like
> doing an MI "-exec-interrupt --thread-group i1" causes an assertion failure:
>
> ~"/scratch/gdb/binutils-gdb/gdb/target.c:3768: internal-error: void
> target_stop(ptid_t): Assertion `!proc_target->commit_resumed_state'
> failed.\nA problem internal to GDB has been detected,\nfurther debugging
> may prove unreliable."
>
> I hit this when using Eclipse CDT on x86_64 linux.
>
> If someone recognizes this as a duplicate, please let me know.
>
> Jonah
>

Hi Joel,

The above issue is a regression, I have raised
https://sourceware.org/bugzilla/show_bug.cgi?id=28077 for it.

There is another regression, also affecting Eclipse CDT, when using
"-break-condition N" to remove a condition. I have raised
https://sourceware.org/bugzilla/show_bug.cgi?id=28076 for it.

Thanks
Jonah




>
>

Re: GDB 11.1 release prep update (2021-07-11)

[Jonah Graham]

On Sun, 11 Jul 2021 at 15:43, Jonah Graham <jonah@kichwacoders.com> wrote:

> On Sun, 11 Jul 2021 at 13:04, Jonah Graham <jonah@kichwacoders.com> wrote:
>
>>
>> On Sun, 11 Jul 2021 at 10:44, Joel Brobecker <brobecker@adacore.com>
>> wrote:
>>
>>> Hi everyone,
>>>
>>> Here is a quick status of where we are today, in terms of the GDB 11.1
>>> release.
>>>
>>> We branched last week (hurray!), and so far, we haven't received news
>>> of any major issues. So we're left with the issues listed below,
>>> with some being absolutely blocking, and others being a bit less so.
>>>
>>> For those who have the time and expertise, it would be awesome if
>>> we could prioritize those issues.
>>>
>>>
>> Hi Joel,
>>
>> I have an issue and will raise a bug (regression compared to 10.2) as
>> soon as possible with a reproducer. In the meantime, the summary looks like
>> doing an MI "-exec-interrupt --thread-group i1" causes an assertion failure:
>>
>> ~"/scratch/gdb/binutils-gdb/gdb/target.c:3768: internal-error: void
>> target_stop(ptid_t): Assertion `!proc_target->commit_resumed_state'
>> failed.\nA problem internal to GDB has been detected,\nfurther debugging
>> may prove unreliable."
>>
>> I hit this when using Eclipse CDT on x86_64 linux.
>>
>> If someone recognizes this as a duplicate, please let me know.
>>
>> Jonah
>>
>
> Hi Joel,
>
> The above issue is a regression, I have raised
> https://sourceware.org/bugzilla/show_bug.cgi?id=28077 for it.
>
> There is another regression, also affecting Eclipse CDT, when using
> "-break-condition N" to remove a condition. I have raised
> https://sourceware.org/bugzilla/show_bug.cgi?id=28076 for it.
>
> Thanks
> Jonah
>

Hi Joel,

I have one additional regression that I need to investigate. Simple version
is doing a detach causes a core dump. I will try to reduce it down and
submit a bug as soon as possible (tomorrow with any luck).

(gdb) detach
Detaching from program:
target:/scratch/eclipse/src/cdt/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/data/launch/bin/TargetAvail.exe,
process 2525168
Ending remote debugging.
[Inferior 1 (process 2525168) detached]
terminate called after throwing an instance of 'gdb_exception_error'
Aborted (core dumped)

Jonah




>
>
>
>
>>
>>
>

Re: GDB 11.1 release prep update (2021-07-11)

[Jonah Graham]

On Sun, 11 Jul 2021 at 22:21, Jonah Graham <jonah@kichwacoders.com> wrote:

>
> I have one additional regression that I need to investigate. Simple
> version is doing a detach causes a core dump. I will try to reduce it down
> and submit a bug as soon as possible (tomorrow with any luck).
>
>
Simon has pointed me at
https://sourceware.org/pipermail/gdb-patches/2021-January/175040.html as a
possible culprit, so I will check that first and report back.

Jonah

Re: GDB 11.1 release prep update (2021-07-11)

[Jonah Graham]

On Sun, 11 Jul 2021 at 22:23, Jonah Graham <jonah@kichwacoders.com> wrote:

>
> On Sun, 11 Jul 2021 at 22:21, Jonah Graham <jonah@kichwacoders.com> wrote:
>
>>
>> I have one additional regression that I need to investigate. Simple
>> version is doing a detach causes a core dump. I will try to reduce it down
>> and submit a bug as soon as possible (tomorrow with any luck).
>>
>>
> Simon has pointed me at
> https://sourceware.org/pipermail/gdb-patches/2021-January/175040.html as
> a possible culprit, so I will check that first and report back.
>
>
That was indeed the culprit. I have filed
https://sourceware.org/bugzilla/show_bug.cgi?id=28080 with more details.

Thanks,
Jonah

>

Re: GDB 11.1 release prep update (2021-07-11)

[Jonah Graham]

On Mon, 12 Jul 2021 at 11:37, Jonah Graham <jonah@kichwacoders.com> wrote:

>
>
> On Sun, 11 Jul 2021 at 22:23, Jonah Graham <jonah@kichwacoders.com> wrote:
>
>>
>> On Sun, 11 Jul 2021 at 22:21, Jonah Graham <jonah@kichwacoders.com>
>> wrote:
>>
>>>
>>> I have one additional regression that I need to investigate. Simple
>>> version is doing a detach causes a core dump. I will try to reduce it down
>>> and submit a bug as soon as possible (tomorrow with any luck).
>>>
>>>
>> Simon has pointed me at
>> https://sourceware.org/pipermail/gdb-patches/2021-January/175040.html as
>> a possible culprit, so I will check that first and report back.
>>
>>
> That was indeed the culprit. I have filed
> https://sourceware.org/bugzilla/show_bug.cgi?id=28080 with more details.
>

Hi Joel,

Thanks to the very fast turnaround from Simon, Baris and Pedro, all three
regressions have patches that resolve all the issues and the Eclipse CDT
integration tests passed GDB 11 + those patches.

Thank you everyone and I look forward to testing more of the prereleases as
they become available and include the referenced patches.

Jonah

~~~
Jonah Graham
Kichwa Coders
www.kichwacoders.com

Re: GDB 11.1 release prep update (2021-07-11)

[Joel Brobecker]

> Thanks to the very fast turnaround from Simon, Baris and Pedro, all three
> regressions have patches that resolve all the issues and the Eclipse CDT
> integration tests passed GDB 11 + those patches.
> 
> Thank you everyone and I look forward to testing more of the prereleases as
> they become available and include the referenced patches.

A big thank you indeed to everyone who contributed to the lightning-speed
fixes, and thanks to you Jonah for having reported those.

-- 
Joel

Re: GDB 11.1 release prep update (2021-07-11)

[Simon Marchi]

On 2021-07-11 10:43 a.m., Joel Brobecker wrote:
>   * [Sergey with Simon as reviewer] <PR tdep/26633>
>     Add Z80 CPU support
>     https://sourceware.org/bugzilla/show_bug.cgi?id=26633
> 
>     Patch submitted at:
>     https://sourceware.org/pipermail/gdb-patches/2020-September/172083.html
> 
>     (May 24th) High-level pre-review done at:
>     https://sourceware.org/pipermail/gdb-patches/2021-May/179191.html
> 
>     No movement since then. Not blocking for branching since it would
>     be safe to backport after branching. Not blocking for release either.

This is now done.

Simon