From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by sourceware.org (Postfix) with ESMTPS id 964843858D37 for ; Wed, 2 Mar 2022 16:17:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 964843858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f42.google.com with SMTP id y5so1494311wmi.0 for ; Wed, 02 Mar 2022 08:17:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=UU6Q44i6guLpHOK9Qpfcn1Lvhk0Aw2KUNetsV4nORAI=; b=kEgAFVDytM7VotJwgXJunoIaHDokeS1fuk9LfC2YfjC6sw2LmQCtyAuHUNkWH/AOy1 fvGrAeccwvE4l8Z0ZNKUCTCEKMa8ruDVpz7Y5ozqgWOigCZoPdWwKqd6jpRWo+j0/Egw SO5ewZq222W0LTMRBlsJ8KuGNKUNXRzgukcI+O0N+5EYugtpywBwsbRyJ0tLvYNAEa2P NaRH6PW/q6g1JCiH8eKdvLsLdVz9SZAf5rGP9zxsclPgrU4cCQdeQPPpNBI9mG3jm0CN aCCNMHz1GiNLF9E7VGQ/71Cdk3k7C7B9E6AEFhi8pSYtv1o9CLz6bB6pxTRYcXPXtuqU +P5g== X-Gm-Message-State: AOAM530i3bDzdvcMdlKIxKo0o+A3rVNjSz09myOotUFaI5Qrb5SIwNvp 0QmaJ1l4YKkbGJeYpYE7XaU= X-Google-Smtp-Source: ABdhPJxSh1ZqDqkaGyz9zM/WZIidwcRAm+IVVCmHbCF6A3VdOy+AKuvPQapGO/aqzUPXwAOieHkLBQ== X-Received: by 2002:a05:600c:29ce:b0:384:f345:aa4c with SMTP id s14-20020a05600c29ce00b00384f345aa4cmr424208wmd.41.1646237872484; Wed, 02 Mar 2022 08:17:52 -0800 (PST) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id m34-20020a05600c3b2200b00380e3225af9sm6799750wms.0.2022.03.02.08.17.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Mar 2022 08:17:51 -0800 (PST) Message-ID: <76afd937-0202-9bde-aee1-c8f3f1119777@palves.net> Date: Wed, 2 Mar 2022 16:17:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 03/11] Change gdb.base/skip-solib.exp deal with lack of epilogue information Content-Language: en-US To: Bruno Larsen , gdb-patches@sourceware.org References: <20220126195053.69559-1-blarsen@redhat.com> <20220126195053.69559-4-blarsen@redhat.com> From: Pedro Alves In-Reply-To: <20220126195053.69559-4-blarsen@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 16:17:54 -0000 On 2022-01-26 19:50, Bruno Larsen via Gdb-patches wrote: > When testing with clang, this feature worked, but the test failed > because it checked specifically to see if we were at the main function. > Without epilogue information, the inferior would be at libc_start_main > (or equivalent) instead. Having this test changed would allows us to > identify if the test stops working for real at some point. I'm having trouble understanding what you're saying. I wonder whether pasting a snippet of the failing case would help? > --- > gdb/testsuite/gdb.base/skip-solib.exp | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/skip-solib.exp b/gdb/testsuite/gdb.base/skip-solib.exp > index ce2b080229e..99833533b6a 100644 > --- a/gdb/testsuite/gdb.base/skip-solib.exp > +++ b/gdb/testsuite/gdb.base/skip-solib.exp > @@ -82,7 +82,7 @@ with_test_prefix "ignoring solib file" { > # We shouldn't step into square(), since we skipped skip-solib-lib.c. > # > gdb_test "step" "" > - gdb_test "bt" "#0\\s+main.*" > + gdb_test "bt 1" "#0.*main.*" Is the tweak here to change the regexp to match both "main" and "libc_start_main"? > } > > # > @@ -114,5 +114,12 @@ with_test_prefix "ignoring solib function" { > # the last line of square. > # > gdb_test "step" "" > - gdb_test "bt" "#0\\s+square.*" > + gdb_test_multiple "bt 1" "skipped multiply" { > + -re "#0\\s+square.*" { > + pass "skipped multiply" > + } > + -re "#0.*main.*" { > + pass "skipped multiply" > + } > + } > }