From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 69023385842A for ; Mon, 28 Feb 2022 18:34:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 69023385842A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 21SIYOP1010214 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Feb 2022 13:34:29 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 21SIYOP1010214 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1D70D1EDF0; Mon, 28 Feb 2022 13:34:24 -0500 (EST) Message-ID: <76ee0fd0-d42f-e811-bd96-1766e2514191@polymtl.ca> Date: Mon, 28 Feb 2022 13:34:23 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [RFC][PATCH v3 1/1][PR gdb/24069] gdb/darwin: skip over WIFSTOPPED wait4 status Content-Language: en-US To: Philippe Blain , gdb-patches@sourceware.org Cc: Dominique Quatravaux , Sam Warner , Louis-He <1726110778@qq.com> References: <20220216141540.96514-1-levraiphilippeblain@gmail.com> <20220224142321.585-1-levraiphilippeblain@gmail.com> <20220224142321.585-2-levraiphilippeblain@gmail.com> <50083fbd-bb00-da50-26a6-0bc5c6dcc34d@polymtl.ca> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 28 Feb 2022 18:34:24 +0000 X-Spam-Status: No, score=-3033.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2022 18:34:42 -0000 On 2022-02-28 12:52, Philippe Blain wrote: > Hi Simon, > > Le 2022-02-24 à 10:49, Simon Marchi a écrit : >> >> >> On 2022-02-24 09:23, Philippe Blain wrote: >>> From: Dominique Quatravaux >>>> >>> >>> PR gdb/24609 >>> * gdb/darwin-nat.c (darwin_nat_target::decode_message): Also >>> check for WIFSTOPPED upon MACH_NOTIFY_DEAD_NAME. >> >> Thanks, pushed. >> >> Simon >> > > I noticed that the Bugzilla entry was not updated when you pushed > that commit, whereas it was for the previous one [1]. I'm not sure > of what is the automation that makes this work... > > I thought it was because my changelog entry mistakenly used 24609 instead > of 24069, but that was the case also for v2 1/2, so I guess that's not > the cause... Patch #1 had a link to the correct bugzilla ticket in its commit message, so the connection was made. Patch #2 didn't have any mention of the bugzilla ticket, so there was no connection. The correct thing to do nowadays, according to our standard procedures, would have been to use the: Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=24069 trailer. But I often forget about it. Simon