public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>,
	Jonah Graham <jonah@kichwacoders.com>,
	Eli Zaretskii <eliz@gnu.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH master + 11] gdb/mi: handle no condition argument case for -break-condition
Date: Mon, 12 Jul 2021 16:53:05 -0400	[thread overview]
Message-ID: <76fa8266-05b0-b4a8-d34f-489e8db068ab@polymtl.ca> (raw)
In-Reply-To: <SN6PR11MB2893E086C7D2E9E3B3E25E7DC4159@SN6PR11MB2893.namprd11.prod.outlook.com>

> The error message has changed compared to previous GDB releases, not sure if that was intentional or if it matters, the old versions said:
> 
>  
> 
> ^error,msg="Argument required (breakpoint number)."
> 
>  
> 
> the new message renders as:
> 
>  
> 
> ^error,msg="-break-condition: Missing the <number> argument"
> 
>  
> 
> Eclipse CDT does not use the contents of error message (because we never send a command with such an error :-) so from my perspective it is fine to change the error message.
> 
>  
> 
> Jonah
> 
>      
> 
> The former error message was coming from the CLI’s “cond” command:
> 
>  
> 
>   (gdb) cond
> 
>   Argument required (breakpoint number).
> 
>  
> 
> In my opinion this message is equivalent to the new message in terms of descriptiveness,
> 
> except for the “-break-condition” prefix.  Let’s see what Simon or another maintainer
> 
> thinks about preserving the exact same error message.

I really don't mind.  The code part of the patch LGTM.  Eli, any
comments on the doc?

Simon

  reply	other threads:[~2021-07-12 20:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12  8:20 Tankut Baris Aktemur
2021-07-12  8:39 ` Aktemur, Tankut Baris
2021-07-12 13:36 ` Jonah Graham
2021-07-12 14:01   ` Aktemur, Tankut Baris
2021-07-12 20:53     ` Simon Marchi [this message]
2021-07-24 21:15 ` Joel Brobecker
2021-07-25  6:06   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76fa8266-05b0-b4a8-d34f-489e8db068ab@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jonah@kichwacoders.com \
    --cc=tankut.baris.aktemur@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).