From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id BF0113858D38 for ; Mon, 10 Apr 2023 21:29:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF0113858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4PwMZD5363z3xNH; Mon, 10 Apr 2023 21:29:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PwMZD4GQtz4Yfd; Mon, 10 Apr 2023 21:29:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681162196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rrj4U3xuCNYrTE5U45xptF709jAPf51wZzrIezAi9k8=; b=vOyAS9i0RoKZw2Skq2ShHGX/SyBGohNw69gcu4k7eUw1BrWlnbX/5qPkTrthBSPAWe/z9v 4DUBnmuEYExx/YQXhkOf/wEeMMc0Anudu+PrM5uGIFzBqSPMV2lNxfLlujLxs/zJEyd+Qx eya+VX9HZpBLah0EFcXm2FkOrZeXyE/uVtKmWWAsf0vjqCGHkmPUShD+DvFvEnyLsRTJPA QevFoQu61KaqZkJtdiyKaA9SAZQA8oJ+2HAOvFs9cc6Yldk+dZ7JBRYvBTirYspXv0/NZt OpHW80t8RewyQfjOKt0tb+tOkW8C4D8PL7bQGhm/U7ChXggn5ZJOqiRvW+lDrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681162196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rrj4U3xuCNYrTE5U45xptF709jAPf51wZzrIezAi9k8=; b=xG1/HRDw0ShlIufI2eDEUt3/yjZ6qp74E2ORLj6iG17Qbf7Rib5P1AbAGWii4IBbr5b4dd Jy/mW3gI2U2s9eXyNX6MVlcUoolPT9083tSx1H6S4qLXaqaREaAiekL9fAksbdWlC785gt xZSZ7IUm/ZAgdEwEdvZFSieY8ecPnqq9fK7g6VwG5TGDfli180+MAcjCqevorsD0CoAq2r aDAK6Kip3Nh6Ie3pPuxLvO8IssGaLfl8+QwMPFUNHODWXUFnAmEETJ8EDTgDOCPCGUxau/ +XqdxzDX9OgejQ3NRyGc+kZSZVNhUnfE28QTPWre92hOVBFVtZeErPYoEjfQBQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681162196; a=rsa-sha256; cv=none; b=TKFfDEEW0nz7pwZAHZxebGNXdq2mhdAaPSjdvXNXDocwgSU5JjKbUVZmzAjIVIlNRJrDwp sAAeYljhX9Q/+0HscdVJcKwlu04WFx0TrpEh2+CIV15kKdLaloj/vSvLwtdX24JvlFakwl wCMZB1yGy6xbECrXr1/a08RWZSBdcYdHd0TXL64tf+K1pKsvTN39ESPv2bY1yE19zXJj1l zm5I5/cE00LPHJLCXqjylCK2TPqCs37zdQ8UzeV2WsGYTnrvgeqvzqHTPDr1/U5kPGqbfi Wz4HB5eScMKVg6XtWrzUFxjdD3ppRGv/uCA5umE9J6D135r+S7kWfkmS0ub6qw== Received: from [IPV6:2601:648:8680:16b0:14bb:55bb:f654:b139] (unknown [IPv6:2601:648:8680:16b0:14bb:55bb:f654:b139]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PwMZD1JJHzfJn; Mon, 10 Apr 2023 21:29:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <775efb08-97d4-8e2c-dc04-9fc5d7322dcb@FreeBSD.org> Date: Mon, 10 Apr 2023 14:29:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v4 07/13] gdb: Update x86 Linux architectures to support XSAVE layouts. Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230318010905.14294-1-jhb@FreeBSD.org> <20230318010905.14294-8-jhb@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/6/23 6:43 PM, Simon Marchi wrote: >> -/* Get XSAVE extended state xcr0 from core dump. */ >> +/* See i386-linux-tdep.h. */ >> >> uint64_t >> -i386_linux_core_read_xcr0 (bfd *abfd) >> +i386_linux_core_read_xsave_info (bfd *abfd, x86_xsave_layout *layout) >> { >> asection *xstate = bfd_get_section_by_name (abfd, ".reg-xstate"); >> - uint64_t xcr0; >> + if (xstate == nullptr) >> + return X86_XSTATE_SSE_MASK; >> >> - if (xstate) >> + /* Check extended state size. */ >> + size_t size = bfd_section_size (xstate); >> + if (size < X86_XSTATE_AVX_SIZE) >> + return X86_XSTATE_SSE_MASK; >> + >> + char contents[8]; >> + if (! bfd_get_section_contents (abfd, xstate, contents, >> + I386_LINUX_XSAVE_XCR0_OFFSET, 8)) >> { >> - size_t size = bfd_section_size (xstate); >> - >> - /* Check extended state size. */ >> - if (size < X86_XSTATE_AVX_SIZE) >> - xcr0 = X86_XSTATE_SSE_MASK; >> - else >> - { >> - char contents[8]; >> - >> - if (! bfd_get_section_contents (abfd, xstate, contents, >> - I386_LINUX_XSAVE_XCR0_OFFSET, >> - 8)) >> - { >> - warning (_("Couldn't read `xcr0' bytes from " >> - "`.reg-xstate' section in core file.")); >> - return 0; >> - } >> - >> - xcr0 = bfd_get_64 (abfd, contents); >> - } >> + warning (_("Couldn't read `xcr0' bytes from " >> + "`.reg-xstate' section in core file.")); >> + return 0; >> } >> - else >> - xcr0 = 0; >> + >> + uint64_t xcr0 = bfd_get_64 (abfd, contents); >> + >> + if (!i387_set_xsave_layout (xcr0, size, layout)) >> + return 0; > > Should these 3 "return 0" be "return X86_XSTATE_SSE_MASK"? Yes, fixed. >> return xcr0; >> } >> >> +/* Implement the core_xfer_x86_xsave_layout gdbarch method. */ >> + >> +LONGEST >> +i386_linux_core_xfer_x86_xsave_layout (struct gdbarch *gdbarch, >> + gdb_byte *readbuf, ULONGEST offset, >> + ULONGEST len) > > I think the comment should be > > /* See i386-linux-tdep.h. */ Fixed. -- John Baldwin