From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [committed][gdb/testsuite] Fix tcl error in jit-elf-helpers.exp
Date: Sun, 24 May 2020 10:24:22 -0400 [thread overview]
Message-ID: <77635b98-dd74-41d7-42d3-ae3b88f896cf@polymtl.ca> (raw)
In-Reply-To: <20200512124337.GA27812@delia>
On 2020-05-12 8:43 a.m., Tom de Vries wrote:
> @@ -94,8 +96,10 @@ proc compile_and_download_n_jit_so {jit_solib_basename jit_solib_srcfile count}
> additional_flags=-DFUNCTION_NAME=[format "jit_function_%04d" $i] \
> additional_flags=-Xlinker \
> additional_flags=-Ttext-segment=$addr]
> - if { [gdb_compile_shlib ${jit_solib_srcfile} ${binfile} $options] != "" } {
> - untested "failed to compile ${jit_solib_basename}.c as a shared library"
> + if { [gdb_compile_shlib ${jit_solib_srcfile} ${binfile} \
> + $options] != "" } {
> + set f [file tail $binfile]
> + untested "failed to compile shared library $binfile"
> return -1
I just noticed, should it be `$f` instead of `$binfile` here?
Simon
next prev parent reply other threads:[~2020-05-24 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 12:43 Tom de Vries
2020-05-24 14:24 ` Simon Marchi [this message]
2020-05-25 10:29 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77635b98-dd74-41d7-42d3-ae3b88f896cf@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).