From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5F4AD3858D32 for ; Thu, 13 Jul 2023 17:36:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F4AD3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689269766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IGMV/NDsw6DgrfTV2iVkQoyvDRey+jpdlZgLeHPe2XE=; b=AKJo+kFHupqLuLNbP93UPhwDokZyH2VLYKHgKGL53Vj4f/aL5AgWnSnTRCcf6Gxuy3OwYM rL+ybQNCuqx2R/i2d8yEGk6HDLPkfik0jTYPGs7Z0NCMeBS0erIv4ACq6bsN6U3Ss8iHfD 6WxsZRZCxpdRXEVhPmTqkgtE6Advl/I= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-428-A1bsC-ylOOKV4q4foNSagw-1; Thu, 13 Jul 2023 13:36:03 -0400 X-MC-Unique: A1bsC-ylOOKV4q4foNSagw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9F7351C16FF8 for ; Thu, 13 Jul 2023 17:35:58 +0000 (UTC) Received: from [10.22.32.34] (unknown [10.22.32.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AC28C1ED96; Thu, 13 Jul 2023 17:35:57 +0000 (UTC) Message-ID: <7774b382-a663-f593-ea99-c52a8495aead@redhat.com> Date: Thu, 13 Jul 2023 10:35:56 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 4/4] gdb/doc: document '+' argument for 'list' command To: Bruno Larsen Cc: gdb-patches@sourceware.org References: <20230713102411.2279542-1-blarsen@redhat.com> <20230713102411.2279542-5-blarsen@redhat.com> From: Keith Seitz In-Reply-To: <20230713102411.2279542-5-blarsen@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/13/23 03:24, Bruno Larsen via Gdb-patches wrote: > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 20c9b24400d..cd86da50f46 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -9148,6 +9148,9 @@ Stack}), this prints lines centered around that line. If no > @code{list} command has been used and no solitary line was printed, > it prints the lines around the function @code{main}. > > +@item list + > +Same as using with no arguments. > + > @item list - > Print lines just before the lines last printed. > Grepping gdb.texinfo for "list +" definitely has a result: $ grep 'list +' gdb.texinfo @item list + list +[NSText initialize] This is from the same "Printing Source Line" section of the Manual that your patch touches. This is the blurb which gives a "complete description of the possible arguments for list". What your patch does is actually add "list +" to the "most commonly used" blurb at the top of the section. I'm not sure I really find that compelling, given that it is essentially synonymous with just repeating/hitting enter, documented just above it. To be clear, I am not entirely against it. I'll leave it to the documentation experts. [And I see we have a near mid-air collision with an Approved-by. So ignore me!] Keith