From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32502 invoked by alias); 29 Nov 2017 12:25:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32487 invoked by uid 89); 29 Nov 2017 12:25:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-6.7 required=5.0 tests=BAYES_00,GIT_PATCH_3,KAM_SHORT,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Nov 2017 12:25:02 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2163380B2A; Wed, 29 Nov 2017 12:25:01 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CDFAE60BE5; Wed, 29 Nov 2017 12:24:53 +0000 (UTC) Subject: Re: [PATCH v3] Add support for the readnever concept To: Sergio Durigan Junior , GDB Patches References: <1467838463-15786-1-git-send-email-brobecker@adacore.com> <20171129012139.17325-1-sergiodj@redhat.com> Cc: Joel Brobecker , Yao Qi , Eli Zaretskii From: Pedro Alves Message-ID: <779a2d21-badf-b54c-e1c9-2f869716fd71@redhat.com> Date: Wed, 29 Nov 2017 12:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171129012139.17325-1-sergiodj@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00767.txt.bz2 On 11/29/2017 01:21 AM, Sergio Durigan Junior wrote: > Changes from v2: > > - Fixed a few nits pointed by Eli in the docs. > > - Implemented Pedro's suggestion and moved the logic of readnever out > of the "*_build_psymtabs" and into the elf_symfile_read function. See my comments here: https://sourceware.org/ml/gdb-patches/2017-11/msg00766.html > While implementing the code for the 'symbol-file' command, I noticed a > bug in 'symbol_file_command': GDB adds the symbol file before > finishing parsing all the options, which means that the position of an > option in the command impacts whether it will be considered or not. I > changed the code there in order to only add the symbol file after all > options have been parsed. Is this the same as: https://sourceware.org/ml/gdb-patches/2017-11/msg00656.html ? Sounds like something that would be better split off to a precursor patch. > +++ b/gdb/testsuite/gdb.base/readnever.c > @@ -0,0 +1,43 @@ > +/* Copyright 2016-2017 Free Software Foundation, Inc. > + > + This program is free software; you can redistribute it and/or modify > + it under the terms of the GNU General Public License as published by > + the Free Software Foundation; either version 3 of the License, or > + (at your option) any later version. > + > + This program is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + GNU General Public License for more details. > + > + You should have received a copy of the GNU General Public License > + along with this program. If not, see . */ > + > +#include This include isn't necessary. > + > +static void > +fun_three (int a, char b, void *c) > +{ > + /* Do nothing. */ > +} > + > +static void > +fun_two (unsigned int p, const char *y) > +{ > + fun_three ((int) p, '1', (void *) y); > +} > + > +static void > +fun_one (int *x) > +{ > + fun_two (10, (const char *) x); > +} > + > +int > +main (void) > +{ > + int a = 10; > + > + fun_one (&a); > + return 0; > +} > +# Test invalid combination of flags. > +save_vars { GDBFLAGS } { > + append GDBFLAGS " --readnever --readnow" > + gdb_exit > + gdb_spawn_ignore_error > + > + set test "test readnow and readnever at the same time" > + gdb_test_multiple "" $test { > + eof { > + pass $test > + } > + } I had suggested to match GDB's error output before the eof, so I'm surprised to see only eof expected? > +} > + > # Default gdb_spawn procedure. > > -proc default_gdb_spawn { } { > +proc default_gdb_spawn { { ignore_error 0 } } { > global use_gdb_stub > global GDB > global INTERNAL_GDBFLAGS GDBFLAGS > @@ -1610,11 +1610,12 @@ proc default_gdb_spawn { } { > } > } > set res [remote_spawn host "$GDB $INTERNAL_GDBFLAGS $GDBFLAGS [host_info gdb_opts]"] > - if { $res < 0 || $res == "" } { > - perror "Spawning $GDB failed." > - return 1 > + if { !$ignore_error } { > + if { $res < 0 || $res == "" } { > + perror "Spawning $GDB failed." > + return 1 > + } > } Hmm, I think I'm now confused on why this is needed in the first place? GDB-the-executable should be starting successfully, print some error output, and exit. What error do you see here, exactly? > - > set gdb_spawn_id $res > return 0 > } Thanks, Pedro Alves