From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 0D8813894C37 for ; Thu, 13 May 2021 17:13:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0D8813894C37 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14DHDqMr009992 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 May 2021 13:13:57 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14DHDqMr009992 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 57AEE1E813; Thu, 13 May 2021 13:13:52 -0400 (EDT) Subject: Re: Using clang-format To: Tom Tromey Cc: Simon Marchi via Gdb-patches References: <87lf8p9pwg.fsf@tromey.com> <9e485731-875c-98e2-1894-6b1a45efa5c5@polymtl.ca> <8735ut6m2u.fsf@tromey.com> From: Simon Marchi Message-ID: <77cb0565-3501-cff3-f321-0df70026c4ac@polymtl.ca> Date: Thu, 13 May 2021 13:13:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <8735ut6m2u.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 13 May 2021 17:13:52 +0000 X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 May 2021 17:13:59 -0000 On 2021-05-11 4:40 p.m., Tom Tromey wrote: >>> gcc_type >>> compile_cplus_instance::convert_reference_base ( >>> gcc_type base, enum gcc_cp_ref_qualifiers rquals) >>> >>> But really, I don't think these should be blockers. It would take >>> someone some really bad faith to say that the above changes how they >>> read the code. > > I don't agree, mainly because I dislike that style, and I feel like I'm > generally above-board. Ok, and sorry about my original formulation, when re-reading it it sounds a bit strong. Simon